You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2021/05/02 13:53:32 UTC

[GitHub] [incubator-nuttx] maxikrie opened a new pull request #3645: boards/nucleo-h743zi2: added netnsh config

maxikrie opened a new pull request #3645:
URL: https://github.com/apache/incubator-nuttx/pull/3645


   ## Summary
   Created netnsh configuration, which is an almost identical copy from nucleo-h743zi/netnsh (except from change in board name).
   ## Impact
   This only affects the nucleo-h743zi2.
   ## Testing
   This was tested on the nucleo-h743zi2 and pinging works.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-nuttx] acassis commented on pull request #3645: boards/nucleo-h743zi2: added netnsh config

Posted by GitBox <gi...@apache.org>.
acassis commented on pull request #3645:
URL: https://github.com/apache/incubator-nuttx/pull/3645#issuecomment-833015802


   @btashton I will merge this PR. I think nsh, netnsh and usbnsh are important configs to have in the system. Your jumbo config idea is nice to validate many features, but sometimes people only want the Network support and removing all the features from jumbo will make this task more complicated.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-nuttx] btashton commented on pull request #3645: boards/nucleo-h743zi2: added netnsh config

Posted by GitBox <gi...@apache.org>.
btashton commented on pull request #3645:
URL: https://github.com/apache/incubator-nuttx/pull/3645#issuecomment-831002020


   @maxikrie  did you see the jumbo config that I created for this board?  My thought there was to pack a lot of features in it for testing including networking which keeps the build time and config count down.  Do you think that is reasonable or should we add this config?  I am not opposed to adding this one if you think it makes sense.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-nuttx] acassis merged pull request #3645: boards/nucleo-h743zi2: added netnsh config

Posted by GitBox <gi...@apache.org>.
acassis merged pull request #3645:
URL: https://github.com/apache/incubator-nuttx/pull/3645


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org