You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@parquet.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2019/08/05 09:11:00 UTC

[jira] [Commented] (PARQUET-1627) Update specification so that legacy timestamp logical types can be written for local semantics as well

    [ https://issues.apache.org/jira/browse/PARQUET-1627?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16899929#comment-16899929 ] 

ASF GitHub Bot commented on PARQUET-1627:
-----------------------------------------

nandorKollar commented on pull request #148: PARQUET-1627: Update specification so that legacy timestamp logical types can be written for local semantics as well
URL: https://github.com/apache/parquet-format/pull/148
 
 
   Make sure you have checked _all_ steps below.
   
   ### Jira
   
   - [ ] My PR addresses the following [Parquet Jira](https://issues.apache.org/jira/browse/PARQUET/) issues and references them in the PR title. For example, "PARQUET-1234: My Parquet PR"
     - https://issues.apache.org/jira/browse/PARQUET-XXX
     - In case you are adding a dependency, check if the license complies with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
   
   ### Commits
   
   - [ ] My commits all reference Jira issues in their subject lines. In addition, my commits follow the guidelines from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)":
     1. Subject is separated from body by a blank line
     1. Subject is limited to 50 characters (not including Jira issue reference)
     1. Subject does not end with a period
     1. Subject uses the imperative mood ("add", not "adding")
     1. Body wraps at 72 characters
     1. Body explains "what" and "why", not "how"
   
   ### Documentation
   
   - [ ] In case of new functionality, my PR adds documentation that describes how to use it.
     - All the public functions and the classes in the PR contain Javadoc that explain what it does
   
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> Update specification so that legacy timestamp logical types can be written for local semantics as well
> ------------------------------------------------------------------------------------------------------
>
>                 Key: PARQUET-1627
>                 URL: https://issues.apache.org/jira/browse/PARQUET-1627
>             Project: Parquet
>          Issue Type: Task
>          Components: parquet-format
>            Reporter: Zoltan Ivanfi
>            Assignee: Nandor Kollar
>            Priority: Major
>              Labels: pull-request-available
>
> The rules for TIMESTAMP forward-compatibility were created based on the assumption that TIMESTAMP_MILLIS and TIMESTAMP_MICROS have only been used in the instant aka. UTC-normalized semantics so far.
> From this false premise it followed that TIMESTAMPs with local semantics were a new type and did not need to be annotated with the old types to maintain compatibility. In fact, annotating them with the old types were considered to be harmful, since it would have mislead older readers into thinking that they can read TIMESTAMPs with local semantics, when in reality they would have misinterpreted them as TIMESTAMPs with instant semantics. This would have lead to a difference of several hours, corresponding to the time zone offset.
> In reality, however, this misinterpretation of timestamps has already been going on for a while, since Arrow annotates local timestamps with TIMESTAMP_MILLIS or TIMESTMAP_MICROS.
> To maintain forward compatibilty of local timestamps, the specification should allow annotating them with the legacy timestamp logical types.



--
This message was sent by Atlassian JIRA
(v7.6.14#76016)