You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2022/04/06 00:57:50 UTC

[GitHub] [pulsar] Anonymitaet commented on a diff in pull request #15005: [improve][workflow] Add PR guideline info to PR template

Anonymitaet commented on code in PR #15005:
URL: https://github.com/apache/pulsar/pull/15005#discussion_r843375267


##########
.github/PULL_REQUEST_TEMPLATE.md:
##########
@@ -1,9 +1,7 @@
 <!--
 ### Contribution Checklist
   
-  - Name the pull request in the form "[Issue XYZ][component] Title of the pull request", where *XYZ* should be replaced by the actual issue number.
-    Skip *Issue XYZ* if there is no associated github issue for this pull request.
-    Skip *component* if you are unsure about which is the best component. E.g. `[docs] Fix typo in produce method`.
+  - PR title format should be *[type][component] summary*. For details, see *[Guideline - Pulsar PR Naming Convention](https://docs.google.com/document/d/1d8Pw6ZbWk-_pCKdOmdvx9rnhPiyuxwq60_TrD68d7BA/edit#heading=h.trs9rsex3xom)*. 

Review Comment:
   @RobertIndie I've added a simple rule here. Does this LGTY?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org