[GitHub] [druid] maytasm edited a comment on pull request #11538: Fix hostname validation not skipping with `druid.client.https.validateHostnames=false` in java 8u275 and later

[GitBox <gi...@apache.org>]

maytasm edited a comment on pull request #11538:
URL: https://github.com/apache/druid/pull/11538#issuecomment-892425356


   @jon-wei I have added unit test to verify this fix. The unit test verify that CustomCheckX509TrustManager does set the EndpointIdentificationAlgorithm to null or empty String when validateServerHostnames is set to false. The disadvange to the unit test is that we do not / can not control the specific version of OpenJdk8 that Travis uses to run the unit test. Currently Travis uses openjdk version "1.8.0_252". Hence, the unit test ran in Travis actually does not verify the bug caused by Java 8u275+. The advantages are that 1) the unit test adds very very little additional runtime to the pipeline 2) the unit test ensure that no regression in Java version that is used by Travis tests (which are openjdk version "1.8.0_252", some version of 11 and some version of 15 -- got to lazy to check the specific version) and 3) You can still run the unit test locally against any Java version by changing your IDE Java version, which I did against 8u275 to verify that the fix works. (I also build D
 ruid and run the cluster with 8u275 to verify the fix). Anyway, having unit test is better than no unit test...although it will still fail code coverage as Travis does not use Java 8u275 or greater.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org