You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@gluten.apache.org by "GlutenPerfBot (via GitHub)" <gi...@apache.org> on 2024/03/22 00:30:44 UTC
[PR] [VL] Daily Update Velox Version (2024_03_22) [incubator-gluten]
GlutenPerfBot opened a new pull request, #5077:
URL: https://github.com/apache/incubator-gluten/pull/5077
Upstream Velox's New Commits:
```txt
79df29c3b by Jialiang Tan, Enable arbitrator in OperatorTestBase by default (9141)
dc561a358 by rexan, Handle ShortDecimal correctly inside `importFromArrow` (8957)
ffce11b15 by Mahadevuni Naveen Kumar, Add test for ParquetReaderBenchmark (8726)
1f4ce8c0c by Masha Basmanova, Extract SimpleFunctionApi.h from Type.h (9182)
c4d3f6f54 by youxiduo, Fix lead/lag for zero offset (9026)
9b4a210c0 by Pedro Pedreira, Upgrade folly to v2024.02.26.00 (from v2023.12.04.00) (8950)
0e65b22be by Masha Basmanova, Back out "Deshim //folly:dynamic to //folly/json:dynamic in velox" (9197)
94f52ecb8 by Ma, Rong, Fix read parquet for different encodings across row groups (9129)
86f12b756 by yuling.sh, Add order-sensitive metadata for aggregate functions (9050)
5ada3043e by mwish, Remove legacy codegen code (9176)
49d22aba7 by xiaoxmeng, Fix findPeerOperators in group execution mode (9188)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For additional commands, e-mail: commits-help@gluten.apache.org
Re: [PR] [VL] Daily Update Velox Version (2024_03_22) [incubator-gluten]
Posted by "PHILO-HE (via GitHub)" <gi...@apache.org>.
PHILO-HE commented on PR #5077:
URL: https://github.com/apache/incubator-gluten/pull/5077#issuecomment-2014614301
Hi @ulysses-you, I note you have one PR merged to Velox. Should the below gluten code be removed? If yes, please help do that in a separate PR. Thanks!
https://github.com/apache/incubator-gluten/blob/0702eb8f73051407eb0dd9da495000360f459edd/gluten-core/src/main/scala/io/glutenproject/backendsapi/SparkPlanExecApi.scala#L559
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For additional commands, e-mail: commits-help@gluten.apache.org
Re: [PR] [VL] Daily Update Velox Version (2024_03_22) [incubator-gluten]
Posted by "ulysses-you (via GitHub)" <gi...@apache.org>.
ulysses-you commented on PR #5077:
URL: https://github.com/apache/incubator-gluten/pull/5077#issuecomment-2014621797
@PHILO-HE thank you for the reminder, I will send a pr later
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For additional commands, e-mail: commits-help@gluten.apache.org
Re: [PR] [VL] Daily Update Velox Version (2024_03_22) [incubator-gluten]
Posted by "GlutenPerfBot (via GitHub)" <gi...@apache.org>.
GlutenPerfBot commented on PR #5077:
URL: https://github.com/apache/incubator-gluten/pull/5077#issuecomment-2014691896
===== Performance report for TPCH SF2000 with Velox backend, for reference only ====
<table border="1" cellpadding="0" cellspacing="0">
<tbody>
<tr>
<td><font color=#000000>query</font></td>
<td><font color=#000000>log/native_5077_time.csv</font></td>
<td><font color=#000000>log/native_master_03_21_2024_9d859d8e4_time.csv</font></td>
<td><font color=#000000>difference</font></td>
<td><font color=#000000>percentage</font></td>
</tr>
<tr>
<td><font color=#6F9915>q1</font></td>
<td><font color=#6F9915>37.14</font></td>
<td><font color=#6F9915>36.78</font></td>
<td><font color=#6F9915>-0.358</font></td>
<td><font color=#6F9915>99.04%</font></td>
</tr>
<tr>
<td><font color=#F92663>q2</font></td>
<td><font color=#F92663>23.74</font></td>
<td><font color=#F92663>23.82</font></td>
<td><font color=#F92663>0.073</font></td>
<td><font color=#F92663>100.31%</font></td>
</tr>
<tr>
<td><font color=#6F9915>q3</font></td>
<td><font color=#6F9915>37.08</font></td>
<td><font color=#6F9915>36.97</font></td>
<td><font color=#6F9915>-0.104</font></td>
<td><font color=#6F9915>99.72%</font></td>
</tr>
<tr>
<td><font color=#F92663>q4</font></td>
<td><font color=#F92663>38.06</font></td>
<td><font color=#F92663>38.29</font></td>
<td><font color=#F92663>0.229</font></td>
<td><font color=#F92663>100.60%</font></td>
</tr>
<tr>
<td><font color=#6F9915>q5</font></td>
<td><font color=#6F9915>70.86</font></td>
<td><font color=#6F9915>68.82</font></td>
<td><font color=#6F9915>-2.034</font></td>
<td><font color=#6F9915>97.13%</font></td>
</tr>
<tr>
<td><font color=#6F9915>q6</font></td>
<td><font color=#6F9915>8.85</font></td>
<td><font color=#6F9915>7.79</font></td>
<td><font color=#6F9915>-1.050</font></td>
<td><font color=#6F9915>88.12%</font></td>
</tr>
<tr>
<td><font color=#6F9915>q7</font></td>
<td><font color=#6F9915>82.88</font></td>
<td><font color=#6F9915>82.16</font></td>
<td><font color=#6F9915>-0.714</font></td>
<td><font color=#6F9915>99.14%</font></td>
</tr>
<tr>
<td><font color=#6F9915>q8</font></td>
<td><font color=#6F9915>87.96</font></td>
<td><font color=#6F9915>85.93</font></td>
<td><font color=#6F9915>-2.032</font></td>
<td><font color=#6F9915>97.69%</font></td>
</tr>
<tr>
<td><font color=#6F9915>q9</font></td>
<td><font color=#6F9915>120.52</font></td>
<td><font color=#6F9915>120.31</font></td>
<td><font color=#6F9915>-0.217</font></td>
<td><font color=#6F9915>99.82%</font></td>
</tr>
<tr>
<td><font color=#6F9915>q10</font></td>
<td><font color=#6F9915>45.35</font></td>
<td><font color=#6F9915>43.15</font></td>
<td><font color=#6F9915>-2.191</font></td>
<td><font color=#6F9915>95.17%</font></td>
</tr>
<tr>
<td><font color=#F92663>q11</font></td>
<td><font color=#F92663>20.25</font></td>
<td><font color=#F92663>20.44</font></td>
<td><font color=#F92663>0.191</font></td>
<td><font color=#F92663>100.94%</font></td>
</tr>
<tr>
<td><font color=#6F9915>q12</font></td>
<td><font color=#6F9915>30.48</font></td>
<td><font color=#6F9915>26.75</font></td>
<td><font color=#6F9915>-3.736</font></td>
<td><font color=#6F9915>87.74%</font></td>
</tr>
<tr>
<td><font color=#F92663>q13</font></td>
<td><font color=#F92663>47.12</font></td>
<td><font color=#F92663>48.78</font></td>
<td><font color=#F92663>1.660</font></td>
<td><font color=#F92663>103.52%</font></td>
</tr>
<tr>
<td><font color=#F92663>q14</font></td>
<td><font color=#F92663>17.08</font></td>
<td><font color=#F92663>21.16</font></td>
<td><font color=#F92663>4.084</font></td>
<td><font color=#F92663>123.91%</font></td>
</tr>
<tr>
<td><font color=#6F9915>q15</font></td>
<td><font color=#6F9915>30.40</font></td>
<td><font color=#6F9915>28.73</font></td>
<td><font color=#6F9915>-1.673</font></td>
<td><font color=#6F9915>94.50%</font></td>
</tr>
<tr>
<td><font color=#F92663>q16</font></td>
<td><font color=#F92663>14.16</font></td>
<td><font color=#F92663>14.42</font></td>
<td><font color=#F92663>0.257</font></td>
<td><font color=#F92663>101.81%</font></td>
</tr>
<tr>
<td><font color=#6F9915>q17</font></td>
<td><font color=#6F9915>100.74</font></td>
<td><font color=#6F9915>99.19</font></td>
<td><font color=#6F9915>-1.558</font></td>
<td><font color=#6F9915>98.45%</font></td>
</tr>
<tr>
<td><font color=#6F9915>q18</font></td>
<td><font color=#6F9915>145.55</font></td>
<td><font color=#6F9915>139.46</font></td>
<td><font color=#6F9915>-6.091</font></td>
<td><font color=#6F9915>95.82%</font></td>
</tr>
<tr>
<td><font color=#6F9915>q19</font></td>
<td><font color=#6F9915>16.57</font></td>
<td><font color=#6F9915>15.07</font></td>
<td><font color=#6F9915>-1.504</font></td>
<td><font color=#6F9915>90.92%</font></td>
</tr>
<tr>
<td><font color=#F92663>q20</font></td>
<td><font color=#F92663>26.75</font></td>
<td><font color=#F92663>27.86</font></td>
<td><font color=#F92663>1.113</font></td>
<td><font color=#F92663>104.16%</font></td>
</tr>
<tr>
<td><font color=#F92663>q21</font></td>
<td><font color=#F92663>226.09</font></td>
<td><font color=#F92663>226.99</font></td>
<td><font color=#F92663>0.898</font></td>
<td><font color=#F92663>100.40%</font></td>
</tr>
<tr>
<td><font color=#F92663>q22</font></td>
<td><font color=#F92663>13.78</font></td>
<td><font color=#F92663>14.13</font></td>
<td><font color=#F92663>0.345</font></td>
<td><font color=#F92663>102.50%</font></td>
</tr>
<tr>
<td><font color=#6F9915>total</font></td>
<td><font color=#6F9915>1241.41</font></td>
<td><font color=#6F9915>1226.99</font></td>
<td><font color=#6F9915>-14.412</font></td>
<td><font color=#6F9915>98.84%</font></td>
</tr>
</tbody>
</table>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For additional commands, e-mail: commits-help@gluten.apache.org
Re: [PR] [VL] Daily Update Velox Version (2024_03_22) [incubator-gluten]
Posted by "PHILO-HE (via GitHub)" <gi...@apache.org>.
PHILO-HE merged PR #5077:
URL: https://github.com/apache/incubator-gluten/pull/5077
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For additional commands, e-mail: commits-help@gluten.apache.org
Re: [PR] [VL] Daily Update Velox Version (2024_03_22) [incubator-gluten]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #5077:
URL: https://github.com/apache/incubator-gluten/pull/5077#issuecomment-2014103809
<!--
Licensed to the Apache Software Foundation (ASF) under one
or more contributor license agreements. See the NOTICE file
distributed with this work for additional information
regarding copyright ownership. The ASF licenses this file
to you under the Apache License, Version 2.0 (the
"License"); you may not use this file except in compliance
with the License. You may obtain a copy of the License at
http://www.apache.org/licenses/LICEGJ-2.0
Unless required by applicable law or agreed to in writing,
software distributed under the License is distributed on an
"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
KIND, either express or implied. See the License for the
specific language governing permissions and limitations
under the License.
-->
Thanks for opening a pull request!
Could you open an issue for this pull request on Github Issues?
https://github.com/apache/incubator-gluten/issues
Then could you also rename ***commit message*** and ***pull request title*** in the following format?
[GLUTEN-${ISSUES_ID}][COMPONENT]feat/fix: ${detailed message}
See also:
* [Other pull requests](https://github.com/apache/incubator-gluten/pulls/)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For additional commands, e-mail: commits-help@gluten.apache.org