You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hudi.apache.org by GitBox <gi...@apache.org> on 2022/07/23 10:35:12 UTC
[GitHub] [hudi] codope opened a new pull request, #6197: [HUDI-4071] Match ROLLBACK_USING_MARKERS_ENABLE in sql as datasource
codope opened a new pull request, #6197:
URL: https://github.com/apache/hudi/pull/6197
## *Tips*
- *Thank you very much for contributing to Apache Hudi.*
- *Please review https://hudi.apache.org/contribute/how-to-contribute before opening a pull request.*
## What is the purpose of the pull request
*(For example: This pull request adds quick-start document.)*
## Brief change log
*(for example:)*
- *Modify AnnotationLocation checkstyle rule in checkstyle.xml*
## Verify this pull request
*(Please pick either of the following options)*
This pull request is a trivial rework / code cleanup without any test coverage.
*(or)*
This pull request is already covered by existing tests, such as *(please describe tests)*.
(or)
This change added tests and can be verified as follows:
*(example:)*
- *Added integration tests for end-to-end.*
- *Added HoodieClientWriteTest to verify the change.*
- *Manually verified the change by running a job locally.*
## Committer checklist
- [ ] Has a corresponding JIRA in PR title & commit
- [ ] Commit message is descriptive of the change
- [ ] CI is green
- [ ] Necessary doc changes done or have another open PR
- [ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] XuQianJin-Stars closed pull request #6197: [HUDI-4071] Match ROLLBACK_USING_MARKERS_ENABLE in sql as datasource
Posted by GitBox <gi...@apache.org>.
XuQianJin-Stars closed pull request #6197: [HUDI-4071] Match ROLLBACK_USING_MARKERS_ENABLE in sql as datasource
URL: https://github.com/apache/hudi/pull/6197
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #6197: [HUDI-4071] Match ROLLBACK_USING_MARKERS_ENABLE in sql as datasource
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on PR #6197:
URL: https://github.com/apache/hudi/pull/6197#issuecomment-1193235292
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "097a89ecd59a67a4e71fbacd713ea94e94b3a402",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=10255",
"triggerID" : "097a89ecd59a67a4e71fbacd713ea94e94b3a402",
"triggerType" : "PUSH"
}, {
"hash" : "f688b79a48ad9686e1a43ce0f4ef029dd6a6d987",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=10267",
"triggerID" : "f688b79a48ad9686e1a43ce0f4ef029dd6a6d987",
"triggerType" : "PUSH"
}, {
"hash" : "5ce930743aa0edccd5d1d1fe8a7438f77ed15e19",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "5ce930743aa0edccd5d1d1fe8a7438f77ed15e19",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* f688b79a48ad9686e1a43ce0f4ef029dd6a6d987 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=10267)
* 5ce930743aa0edccd5d1d1fe8a7438f77ed15e19 UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #6197: [HUDI-4071] Match ROLLBACK_USING_MARKERS_ENABLE in sql as datasource
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on PR #6197:
URL: https://github.com/apache/hudi/pull/6197#issuecomment-1193108616
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "097a89ecd59a67a4e71fbacd713ea94e94b3a402",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=10255",
"triggerID" : "097a89ecd59a67a4e71fbacd713ea94e94b3a402",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 097a89ecd59a67a4e71fbacd713ea94e94b3a402 Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=10255)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #6197: [HUDI-4071] Match ROLLBACK_USING_MARKERS_ENABLE in sql as datasource
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on PR #6197:
URL: https://github.com/apache/hudi/pull/6197#issuecomment-1193174034
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "097a89ecd59a67a4e71fbacd713ea94e94b3a402",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=10255",
"triggerID" : "097a89ecd59a67a4e71fbacd713ea94e94b3a402",
"triggerType" : "PUSH"
}, {
"hash" : "f688b79a48ad9686e1a43ce0f4ef029dd6a6d987",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "f688b79a48ad9686e1a43ce0f4ef029dd6a6d987",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 097a89ecd59a67a4e71fbacd713ea94e94b3a402 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=10255)
* f688b79a48ad9686e1a43ce0f4ef029dd6a6d987 UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #6197: [HUDI-4071] Match ROLLBACK_USING_MARKERS_ENABLE in sql as datasource
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on PR #6197:
URL: https://github.com/apache/hudi/pull/6197#issuecomment-1193184170
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "097a89ecd59a67a4e71fbacd713ea94e94b3a402",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=10255",
"triggerID" : "097a89ecd59a67a4e71fbacd713ea94e94b3a402",
"triggerType" : "PUSH"
}, {
"hash" : "f688b79a48ad9686e1a43ce0f4ef029dd6a6d987",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=10267",
"triggerID" : "f688b79a48ad9686e1a43ce0f4ef029dd6a6d987",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* f688b79a48ad9686e1a43ce0f4ef029dd6a6d987 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=10267)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] XuQianJin-Stars commented on pull request #6197: [HUDI-4071] Match ROLLBACK_USING_MARKERS_ENABLE in sql as datasource
Posted by GitBox <gi...@apache.org>.
XuQianJin-Stars commented on PR #6197:
URL: https://github.com/apache/hudi/pull/6197#issuecomment-1193877176
hi @codope @xushiyan fix with [HUDI-4071] (Match ROLLBACK_USING_MARKERS_ENABLE in sql as datasource)](https://github.com/apache/hudi/pull/6206)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] xushiyan commented on pull request #6197: [HUDI-4071] Match ROLLBACK_USING_MARKERS_ENABLE in sql as datasource
Posted by GitBox <gi...@apache.org>.
xushiyan commented on PR #6197:
URL: https://github.com/apache/hudi/pull/6197#issuecomment-1193409613
@XuQianJin-Stars probably some scenarios in call procedure do not support using marker (i have not dived in the failures myself). if you have time, pls help check this. It should be set for each subclass of base procedure if not supporting marker, instead of at the base level.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #6197: [HUDI-4071] Match ROLLBACK_USING_MARKERS_ENABLE in sql as datasource
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on PR #6197:
URL: https://github.com/apache/hudi/pull/6197#issuecomment-1193174630
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "097a89ecd59a67a4e71fbacd713ea94e94b3a402",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=10255",
"triggerID" : "097a89ecd59a67a4e71fbacd713ea94e94b3a402",
"triggerType" : "PUSH"
}, {
"hash" : "f688b79a48ad9686e1a43ce0f4ef029dd6a6d987",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=10267",
"triggerID" : "f688b79a48ad9686e1a43ce0f4ef029dd6a6d987",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 097a89ecd59a67a4e71fbacd713ea94e94b3a402 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=10255)
* f688b79a48ad9686e1a43ce0f4ef029dd6a6d987 Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=10267)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #6197: [HUDI-4071] Match ROLLBACK_USING_MARKERS_ENABLE in sql as datasource
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on PR #6197:
URL: https://github.com/apache/hudi/pull/6197#issuecomment-1193108037
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "097a89ecd59a67a4e71fbacd713ea94e94b3a402",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "097a89ecd59a67a4e71fbacd713ea94e94b3a402",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 097a89ecd59a67a4e71fbacd713ea94e94b3a402 UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #6197: [HUDI-4071] Match ROLLBACK_USING_MARKERS_ENABLE in sql as datasource
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on PR #6197:
URL: https://github.com/apache/hudi/pull/6197#issuecomment-1193241714
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "097a89ecd59a67a4e71fbacd713ea94e94b3a402",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=10255",
"triggerID" : "097a89ecd59a67a4e71fbacd713ea94e94b3a402",
"triggerType" : "PUSH"
}, {
"hash" : "f688b79a48ad9686e1a43ce0f4ef029dd6a6d987",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=10267",
"triggerID" : "f688b79a48ad9686e1a43ce0f4ef029dd6a6d987",
"triggerType" : "PUSH"
}, {
"hash" : "5ce930743aa0edccd5d1d1fe8a7438f77ed15e19",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=10280",
"triggerID" : "5ce930743aa0edccd5d1d1fe8a7438f77ed15e19",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 5ce930743aa0edccd5d1d1fe8a7438f77ed15e19 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=10280)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] xushiyan commented on a diff in pull request #6197: [HUDI-4071] Match ROLLBACK_USING_MARKERS_ENABLE in sql as datasource
Posted by GitBox <gi...@apache.org>.
xushiyan commented on code in PR #6197:
URL: https://github.com/apache/hudi/pull/6197#discussion_r928174380
##########
hudi-spark-datasource/hudi-spark/src/main/scala/org/apache/spark/sql/hudi/command/procedures/BaseProcedure.scala:
##########
@@ -50,7 +50,7 @@ abstract class BaseProcedure extends Procedure {
HoodieWriteConfig.newBuilder
.withPath(basePath)
.withIndexConfig(HoodieIndexConfig.newBuilder.withIndexType(IndexType.BLOOM).build)
- .withRollbackUsingMarkers(false)
+ .withRollbackUsingMarkers(HoodieWriteConfig.ROLLBACK_USING_MARKERS_ENABLE.defaultValue.toBoolean)
Review Comment:
does not look like the right place to change. Looks like the original code is trying to overwrite and never use marker to rollback. otherwise it'll just skip setting it. This is for procedure maybe @XuQianJin-Stars can help clarify if we always want this to be `false`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #6197: [HUDI-4071] Match ROLLBACK_USING_MARKERS_ENABLE in sql as datasource
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on PR #6197:
URL: https://github.com/apache/hudi/pull/6197#issuecomment-1193235710
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "097a89ecd59a67a4e71fbacd713ea94e94b3a402",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=10255",
"triggerID" : "097a89ecd59a67a4e71fbacd713ea94e94b3a402",
"triggerType" : "PUSH"
}, {
"hash" : "f688b79a48ad9686e1a43ce0f4ef029dd6a6d987",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=10267",
"triggerID" : "f688b79a48ad9686e1a43ce0f4ef029dd6a6d987",
"triggerType" : "PUSH"
}, {
"hash" : "5ce930743aa0edccd5d1d1fe8a7438f77ed15e19",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=10280",
"triggerID" : "5ce930743aa0edccd5d1d1fe8a7438f77ed15e19",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* f688b79a48ad9686e1a43ce0f4ef029dd6a6d987 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=10267)
* 5ce930743aa0edccd5d1d1fe8a7438f77ed15e19 Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=10280)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #6197: [HUDI-4071] Match ROLLBACK_USING_MARKERS_ENABLE in sql as datasource
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on PR #6197:
URL: https://github.com/apache/hudi/pull/6197#issuecomment-1193125462
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "097a89ecd59a67a4e71fbacd713ea94e94b3a402",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=10255",
"triggerID" : "097a89ecd59a67a4e71fbacd713ea94e94b3a402",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 097a89ecd59a67a4e71fbacd713ea94e94b3a402 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=10255)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org