You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@seata.apache.org by "lokidundun (via GitHub)" <gi...@apache.org> on 2026/01/12 02:33:12 UTC
[PR] bugfix: fix KingbaseUndoLogManager INSERT_UNDO_LOG_SQL error [incubator-seata]
lokidundun opened a new pull request, #7929:
URL: https://github.com/apache/incubator-seata/pull/7929
<!--
Licensed to the Apache Software Foundation (ASF) under one or more
contributor license agreements. See the NOTICE file distributed with
this work for additional information regarding copyright ownership.
The ASF licenses this file to You under the Apache License, Version 2.0
(the "License"); you may not use this file except in compliance with
the License. You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing, software
distributed under the License is distributed on an "AS IS" BASIS,
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
See the License for the specific language governing permissions and
limitations under the License.
-->
<!-- Please make sure you have read and understood the contributing guidelines -->
- [x] I have read the [CONTRIBUTING.md](https://github.com/apache/incubator-seata/blob/2.x/CONTRIBUTING.md) guidelines.
- [ ] I have registered the PR [changes](https://github.com/apache/incubator-seata/tree/2.x/changes).
### Ⅰ. Describe what this PR did
Fix `KingbaseUndoLogManager `INSERT_UNDO_LOG_SQL error
According to the [official documentation of Kingbase](https://help.kingbase.com.cn/kadb/admin/ddl/ddl-sequence.html), when calling for the `nextval `function,
the usage is `INSERT INTO vendors VALUES (nextval('myserial'), 'acme');`.
In KingbaseUndoLogManager class
before
`"VALUES ('' + UNDO_LOG_TABLE_NAME.toUpperCase() + "_SEQ.nextval", ?, ?, ?, ?, ?, sysdate, sysdate)"`
after
`"VALUES (nextval('" + UNDO_LOG_TABLE_NAME.toUpperCase() + "_SEQ'), ?, ?, ?, ?, ?, sysdate, sysdate)"`
### Ⅱ. Does this pull request fix one issue?
<!-- If that, add "fixes #xxx" below in the next line, for example, fixes #97. -->
fixes #7926
### Ⅲ. Why don't you add test cases (unit test/integration test)?
Also correct KingbaseUndoLogManagerTest test method.
### Ⅳ. Describe how to verify it
### Ⅴ. Special notes for reviews
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org
For additional commands, e-mail: notifications-help@seata.apache.org
Re: [PR] bugfix: fix KingbaseUndoLogManager INSERT_UNDO_LOG_SQL error [incubator-seata]
Posted by "funky-eyes (via GitHub)" <gi...@apache.org>.
funky-eyes merged PR #7929:
URL: https://github.com/apache/incubator-seata/pull/7929
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org
For additional commands, e-mail: notifications-help@seata.apache.org
Re: [PR] bugfix: fix KingbaseUndoLogManager INSERT_UNDO_LOG_SQL error [incubator-seata]
Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #7929:
URL: https://github.com/apache/incubator-seata/pull/7929#issuecomment-3736710633
## [Codecov](https://app.codecov.io/gh/apache/incubator-seata/pull/7929?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:white_check_mark: All modified and coverable lines are covered by tests.
:white_check_mark: Project coverage is 71.61%. Comparing base ([`5e5979b`](https://app.codecov.io/gh/apache/incubator-seata/commit/5e5979b153829d0a61e45f09c9d29893d287cdd6?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`a33662d`](https://app.codecov.io/gh/apache/incubator-seata/commit/a33662d9dd0d84c8f7a3f0db0ca12e35ce8cd6ed?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## 2.x #7929 +/- ##
============================================
+ Coverage 71.58% 71.61% +0.02%
Complexity 883 883
============================================
Files 1294 1294
Lines 49554 49554
Branches 5884 5884
============================================
+ Hits 35475 35487 +12
+ Misses 11159 11149 -10
+ Partials 2920 2918 -2
```
| [Files with missing lines](https://app.codecov.io/gh/apache/incubator-seata/pull/7929?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...tasource/undo/kingbase/KingbaseUndoLogManager.java](https://app.codecov.io/gh/apache/incubator-seata/pull/7929?src=pr&el=tree&filepath=rm-datasource%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fseata%2Frm%2Fdatasource%2Fundo%2Fkingbase%2FKingbaseUndoLogManager.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-cm0tZGF0YXNvdXJjZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2VhdGEvcm0vZGF0YXNvdXJjZS91bmRvL2tpbmdiYXNlL0tpbmdiYXNlVW5kb0xvZ01hbmFnZXIuamF2YQ==) | `71.05% <100.00%> (ø)` | |
... and [11 files with indirect coverage changes](https://app.codecov.io/gh/apache/incubator-seata/pull/7929/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
[](https://app.codecov.io/gh/apache/incubator-seata/pull/7929?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
- :package: [JS Bundle Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org
For additional commands, e-mail: notifications-help@seata.apache.org