You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2020/11/06 10:52:12 UTC
[GitHub] [apisix-dashboard] nic-chen opened a new pull request #713: fix: create log dir if not exists
nic-chen opened a new pull request #713:
URL: https://github.com/apache/apisix-dashboard/pull/713
Please answer these questions before submitting a pull request
- Why submit this pull request?
- [x] Bugfix
- [ ] New feature provided
- [ ] Improve performance
close #709
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] codecov-io commented on pull request #713: fix: create log dir if not exists
Posted by GitBox <gi...@apache.org>.
codecov-io commented on pull request #713:
URL: https://github.com/apache/apisix-dashboard/pull/713#issuecomment-723016071
# [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/713?src=pr&el=h1) Report
> Merging [#713](https://codecov.io/gh/apache/apisix-dashboard/pull/713?src=pr&el=desc) into [v2.0](https://codecov.io/gh/apache/apisix-dashboard/commit/3a405f779c0d65ca68e52a9745662aca4272ecc1?el=desc) will **increase** coverage by `0.08%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/apisix-dashboard/pull/713?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## v2.0 #713 +/- ##
==========================================
+ Coverage 43.08% 43.16% +0.08%
==========================================
Files 18 18
Lines 1237 1237
==========================================
+ Hits 533 534 +1
+ Misses 615 614 -1
Partials 89 89
```
| [Impacted Files](https://codecov.io/gh/apache/apisix-dashboard/pull/713?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [api/internal/core/store/store.go](https://codecov.io/gh/apache/apisix-dashboard/pull/713/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmUvc3RvcmUuZ28=) | `78.94% <0.00%> (+0.65%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/713?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/713?src=pr&el=footer). Last update [3a405f7...761bc4a](https://codecov.io/gh/apache/apisix-dashboard/pull/713?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] membphis commented on pull request #713: fix: create log dir if not exists
Posted by GitBox <gi...@apache.org>.
membphis commented on pull request #713:
URL: https://github.com/apache/apisix-dashboard/pull/713#issuecomment-723358789
> fix: create log dir if not exists
please discuss in issue first. https://github.com/apache/apisix-dashboard/issues/709#issuecomment-723358684
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] membphis commented on pull request #713: fix: create log dir if not exists
Posted by GitBox <gi...@apache.org>.
membphis commented on pull request #713:
URL: https://github.com/apache/apisix-dashboard/pull/713#issuecomment-723362994
close this PR first. feel free to reopen it @nic-chen
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] membphis closed pull request #713: fix: create log dir if not exists
Posted by GitBox <gi...@apache.org>.
membphis closed pull request #713:
URL: https://github.com/apache/apisix-dashboard/pull/713
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org