You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2022/06/15 20:56:09 UTC

[GitHub] [beam] damccorm commented on a diff in pull request #21896: Use Go 1.18 for go-licenses

damccorm commented on code in PR #21896:
URL: https://github.com/apache/beam/pull/21896#discussion_r898410392


##########
release/go-licenses/Dockerfile:
##########
@@ -16,8 +16,11 @@
 # limitations under the License.
 ###############################################################################
 
-FROM golang:1.16-bullseye
-RUN go get github.com/google/go-licenses@v1.0.0
+FROM golang:1.18-bullseye
+
+WORKDIR /usr/src/app
+COPY go.mod ./
+RUN go install github.com/google/go-licenses@v1.0.0

Review Comment:
   I agree that latest is probably best, I just wanted to keep this change minimal since this was blocking others. #21901 bumps this to latest.
   
   If we run into issues with that we can also pin the version at a later date.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org