You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@stratos.apache.org by Vishanth Balasubramaniam <vi...@wso2.com> on 2015/04/25 22:05:16 UTC

[Code Review Notes] Stratos Load Balancer Extension API

Hi Devs,

Code review notes for* Stratos Load Balancer Extension API : Imesh*

*LoadBalancerExtension.java*

   - Methods comments wherever missing
   - LoadBalancerStatisticsNotifier should be moved to executor service
   (method: execute)
   - Remove 1 of the similar if block, isInfoEnabled (method:
   startTopologyEventReceiver)
   - we could capture LoadBalancerExtensionException (method:
   addTopologyEventListeners)
   - inMaintenanceEventListener is missing to reload the configuration
   (method: addTopologyEventListeners)
   - ErrorEnabled check could be ignored to print the error and make it a
   mandatory log


*LoadBalancerExtensionException.java*

   - serialVersionUID should be added


Regards,
Vishanth

-- 
*Vishanth Balasubramaniam*
Software Engineer
WSO2 Inc.; http://wso2.com
lean.enterprise.middleware

mobile: *+94771737718*
about me: *http://about.me/vishanth <http://about.me/vishanth>*