You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Alex Clemmer <cl...@gmail.com> on 2015/11/02 11:36:17 UTC

Review Request 39850: Process: Added headers to make `process/mime.hpp` standalone.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39850/
-----------------------------------------------------------

Review request for mesos, Artem Harutyunyan, Michael Hopcroft, Joris Van Remoortere, and Joseph Wu.


Repository: mesos


Description
-------

Process: Added headers to make `process/mime.hpp` standalone.


Diffs
-----

  3rdparty/libprocess/include/process/mime.hpp decdfb6bc2eb60bfc6b25bc7227b11e8a11d5aff 

Diff: https://reviews.apache.org/r/39850/diff/


Testing
-------


Thanks,

Alex Clemmer


Re: Review Request 39850: Process: Added headers to make `process/mime.hpp` standalone.

Posted by Cong Wang <cw...@twopensource.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39850/#review110544
-----------------------------------------------------------

Ship it!


Ship It!

- Cong Wang


On Nov. 16, 2015, 9:14 a.m., Alex Clemmer wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39850/
> -----------------------------------------------------------
> 
> (Updated Nov. 16, 2015, 9:14 a.m.)
> 
> 
> Review request for mesos, Artem Harutyunyan, Michael Hopcroft, Joris Van Remoortere, and Joseph Wu.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Process: Added headers to make `process/mime.hpp` standalone.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/include/process/mime.hpp decdfb6bc2eb60bfc6b25bc7227b11e8a11d5aff 
> 
> Diff: https://reviews.apache.org/r/39850/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Alex Clemmer
> 
>


Re: Review Request 39850: Process: Added headers to make `process/mime.hpp` standalone.

Posted by Alex Naparu <al...@outlook.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39850/#review110542
-----------------------------------------------------------

Ship it!


Ship It!

- Alex Naparu


On Nov. 16, 2015, 9:14 a.m., Alex Clemmer wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39850/
> -----------------------------------------------------------
> 
> (Updated Nov. 16, 2015, 9:14 a.m.)
> 
> 
> Review request for mesos, Artem Harutyunyan, Michael Hopcroft, Joris Van Remoortere, and Joseph Wu.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Process: Added headers to make `process/mime.hpp` standalone.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/include/process/mime.hpp decdfb6bc2eb60bfc6b25bc7227b11e8a11d5aff 
> 
> Diff: https://reviews.apache.org/r/39850/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Alex Clemmer
> 
>


Re: Review Request 39850: Process: Added headers to make `process/mime.hpp` standalone.

Posted by Joris Van Remoortere <jo...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39850/#review110818
-----------------------------------------------------------

Ship it!


Ship It!

- Joris Van Remoortere


On Dec. 15, 2015, 11:13 p.m., Alex Clemmer wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39850/
> -----------------------------------------------------------
> 
> (Updated Dec. 15, 2015, 11:13 p.m.)
> 
> 
> Review request for mesos, Artem Harutyunyan, Michael Hopcroft, Joris Van Remoortere, and Joseph Wu.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Process: Added headers to make `process/mime.hpp` standalone.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/include/process/mime.hpp ee7cac3fd01b3a04386c99adda64998dbf6820f0 
> 
> Diff: https://reviews.apache.org/r/39850/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Alex Clemmer
> 
>


Re: Review Request 39850: Process: Added headers to make `process/mime.hpp` standalone.

Posted by Alex Clemmer <cl...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39850/
-----------------------------------------------------------

(Updated Dec. 15, 2015, 11:13 p.m.)


Review request for mesos, Artem Harutyunyan, Michael Hopcroft, Joris Van Remoortere, and Joseph Wu.


Repository: mesos


Description
-------

Process: Added headers to make `process/mime.hpp` standalone.


Diffs
-----

  3rdparty/libprocess/include/process/mime.hpp ee7cac3fd01b3a04386c99adda64998dbf6820f0 

Diff: https://reviews.apache.org/r/39850/diff/


Testing
-------


Thanks,

Alex Clemmer


Re: Review Request 39850: Process: Added headers to make `process/mime.hpp` standalone.

Posted by Alex Clemmer <cl...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39850/
-----------------------------------------------------------

(Updated Dec. 15, 2015, 7:40 p.m.)


Review request for mesos, Artem Harutyunyan, Michael Hopcroft, Joris Van Remoortere, and Joseph Wu.


Repository: mesos


Description
-------

Process: Added headers to make `process/mime.hpp` standalone.


Diffs (updated)
-----

  3rdparty/libprocess/include/process/mime.hpp ee7cac3fd01b3a04386c99adda64998dbf6820f0 

Diff: https://reviews.apache.org/r/39850/diff/


Testing
-------


Thanks,

Alex Clemmer


Re: Review Request 39850: Process: Added headers to make `process/mime.hpp` standalone.

Posted by Alex Clemmer <cl...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39850/
-----------------------------------------------------------

(Updated Nov. 16, 2015, 9:14 a.m.)


Review request for mesos, Artem Harutyunyan, Michael Hopcroft, Joris Van Remoortere, and Joseph Wu.


Repository: mesos


Description
-------

Process: Added headers to make `process/mime.hpp` standalone.


Diffs (updated)
-----

  3rdparty/libprocess/include/process/mime.hpp decdfb6bc2eb60bfc6b25bc7227b11e8a11d5aff 

Diff: https://reviews.apache.org/r/39850/diff/


Testing
-------


Thanks,

Alex Clemmer


Re: Review Request 39850: Process: Added headers to make `process/mime.hpp` standalone.

Posted by Joseph Wu <jo...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39850/#review105290
-----------------------------------------------------------



3rdparty/libprocess/include/process/mime.hpp (line 18)
<https://reviews.apache.org/r/39850/#comment163802>

    Add `<string>` too.


- Joseph Wu


On Nov. 2, 2015, 2:36 a.m., Alex Clemmer wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39850/
> -----------------------------------------------------------
> 
> (Updated Nov. 2, 2015, 2:36 a.m.)
> 
> 
> Review request for mesos, Artem Harutyunyan, Michael Hopcroft, Joris Van Remoortere, and Joseph Wu.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Process: Added headers to make `process/mime.hpp` standalone.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/include/process/mime.hpp decdfb6bc2eb60bfc6b25bc7227b11e8a11d5aff 
> 
> Diff: https://reviews.apache.org/r/39850/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Alex Clemmer
> 
>