You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@groovy.apache.org by jwagenleitner <gi...@git.apache.org> on 2016/05/01 00:09:46 UTC

[GitHub] groovy pull request: Remove unused utility classes

GitHub user jwagenleitner opened a pull request:

    https://github.com/apache/groovy/pull/324

    Remove unused utility classes

    These are public classes but under the `org.codehaus.groovy.util` package so am not sure if that makes them eligible to be removed or if they must be deprecated.  But since there are no references to them in the codebase it would be nice to do the clean-up.
    
    If they are kept, then it would be good to fix the bug in `ManagedDoubleKeyMap#put` (commit 240b915).

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/jwagenleitner/groovy util-cleanup

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/groovy/pull/324.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #324
    
----
commit 240b915639430e57ff846206a84fbba583103002
Author: John Wagenleitner <jw...@apache.org>
Date:   2016-04-29T15:19:47Z

    Fix for ManagedDoubleKeyMap when there are hash collisions and entry array must be expanded
    
    The existing array was having the first element overwritten instead of using the newly allocated array.

commit 8ccf336ba9fe8624bdfd2db6ac23bd66eb9230fc
Author: John Wagenleitner <jw...@apache.org>
Date:   2016-04-29T15:30:24Z

    refactor(core): remove unused utility classes

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] groovy pull request: Remove unused utility classes

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/groovy/pull/324


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---