[GitHub] [incubator-superset] smacker opened a new pull request #7879: Remove unnecessary fields from dashboard exported json

[GitBox <gi...@apache.org>]

smacker opened a new pull request #7879: Remove unnecessary fields from dashboard exported json
URL: https://github.com/apache/incubator-superset/pull/7879
 
 
   ### CATEGORY
   
   Choose one
   
   - [x] Bug Fix
   - [x] Enhancement (new features, refinement)
   - [ ] Refactor
   - [ ] Add tests
   - [ ] Build / Development Environment
   - [ ] Documentation
   
   ### SUMMARY
   
   This PR makes export respect export_fields and doesn't export
   unnecessary relations (like users with passwords hashes) which are
   ignored during the import.
   
   It also allows to import dashboards without position_json.
   In case charts were added from chart-edit page and weren't re-ordered on
   the dashboard, position_json field is empty and import was failing with
   error.
   
   ### BEFORE/AFTER JSON
   
   Exported json for the same dashboard with only 1 chart.
   
   Before 238 lines, contains password hash of the admin user:
   https://gist.github.com/smacker/ab2f3e0ed08fa2f70279a963e14bc48e
   
   After 145 lines, contains only necessary information:
   https://gist.github.com/smacker/856d0231c11ab846ed9a3c8b516cea5f
   
   ### TEST PLAN
   
   Export & import a dashboard using UI or cli command.
   
   ### ADDITIONAL INFORMATION
   <!--- Check any relevant boxes with "x" -->
   <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
   - [ ] Has associated issue:
   - [ ] Changes UI
   - [ ] Requires DB Migration.
   - [ ] Confirm DB Migration upgrade and downgrade tested.
   - [ ] Introduces new feature or API
   - [ ] Removes existing feature or API
   
   ### REVIEWERS
   
   @mistercrunch 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org