You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@nifi.apache.org by GitBox <gi...@apache.org> on 2019/01/03 17:08:46 UTC

[GitHub] pvillard31 commented on issue #3235: Nifi 1893

pvillard31 commented on issue #3235: Nifi 1893
URL: https://github.com/apache/nifi/pull/3235#issuecomment-451209960
 
 
   Hi @avseq1234 - can you rename your PR to start it with NIFI-1893 ?
   
   Few comments:
   - I'm not sure a new bundle makes sense as we already have ValidateCSV, ValidateXML, ValidateRecord in the standard bundle. I think it'd make sense to add this processor in the standard bundle. Not a strong opinion though.
   - I'd rename the processor into ValidateJSON for consistency
   - can you add unit tests that demonstrates what can be achieved with this processor that we can't do with ValidateRecord? can you also add an additionalDetails page with some documentation and examples? (and also links to the underlying library)
   
   Thanks!

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services