[jira] [Commented] (HBASE-27230) RegionServer should be aborted when WAL.sync throws TimeoutIOException

["Hudson (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HBASE-27230?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17824617#comment-17824617 ] 

Hudson commented on HBASE-27230:
--------------------------------

Results for branch branch-2
	[build #1007 on builds.a.o|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2/1007/]: (x) *{color:red}-1 overall{color}*
----
details (if available):

(/) {color:green}+1 general checks{color}
-- For more information [see general report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2/1007/General_20Nightly_20Build_20Report/]


(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2) report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2/1007/JDK8_20Nightly_20Build_20Report_20_28Hadoop2_29/]


(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3) report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2/1007/JDK8_20Nightly_20Build_20Report_20_28Hadoop3_29/]


(/) {color:green}+1 jdk11 hadoop3 checks{color}
-- For more information [see jdk11 report|https://ci-hbase.apache.org/job/HBase%20Nightly/job/branch-2/1007/JDK11_20Nightly_20Build_20Report_20_28Hadoop3_29/]


(/) {color:green}+1 source release artifact{color}
-- See build output for details.


(/) {color:green}+1 client integration test{color}


> RegionServer should be aborted when WAL.sync throws TimeoutIOException
> ----------------------------------------------------------------------
>
>                 Key: HBASE-27230
>                 URL: https://issues.apache.org/jira/browse/HBASE-27230
>             Project: HBase
>          Issue Type: Bug
>          Components: wal
>    Affects Versions: 3.0.0-alpha-4
>            Reporter: chenglei
>            Assignee: chenglei
>            Priority: Major
>              Labels: pull-request-available
>             Fix For: 2.6.0, 3.0.0-alpha-4
>
>
> As HBASE-27223 said, if  {{WAL.sync}} get a timeout exception, we should abort the region server, as the design of WAL sync, is to succeed or die, there is no 'failure'. It is usually not a big deal is because we set a very large default value(5 minutes) for {{AbstractFSWAL.WAL_SYNC_TIMEOUT_MS}}, usually the WAL system will abort the region server if it can not finish the sync within 5 minutes.
> In the PR, only the {{WAL.sync}}  timeout in {{HRegion#doWALAppend}} ,regionServer is always aborted. For {{WALUtil.writeMarker}}, it is just record the internal state and  seems it is no need to always abort the regionServer when {{WAL.sync}} timeout，it is the internal state transition that determines whether regionServer is aborted.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)