You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by tillrohrmann <gi...@git.apache.org> on 2017/08/06 14:30:48 UTC
[GitHub] flink pull request #4483: [FLINK-7372] [JobGraph] Remove ActorGateway from J...
GitHub user tillrohrmann opened a pull request:
https://github.com/apache/flink/pull/4483
[FLINK-7372] [JobGraph] Remove ActorGateway from JobGraph
## What is the purpose of the change
The JobGraph has an unncessary dependency on the ActorGateway via its JobGraph#uploadUserJars method. In order to get rid of this dependency for future Flip-6 changes, this commit retrieves the BlobServer's address beforehand and directly passes it to this method as a `InetSocketAddress` instance.
## Brief change log
- Introduce `JobClient#retrieveBlobServerAddress` method which retrieves from the given `ActorGateway` the `BlobServer` address
- First retrieve `BlobServer` address using the aforementioned method wherever the `ActorGateway` was passed to the `JobGraph`
## Verifying this change
This change is a trivial rework / code cleanup without any test coverage.
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): (no)
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (no)
- The serializers: (no)
- The runtime per-record code paths (performance sensitive): (no)
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (no)
## Documentation
- Does this pull request introduce a new feature? (no)
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/tillrohrmann/flink removeActorGateways
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/4483.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #4483
----
commit 52bf22d5b9b5893e3425c963e5516c1cef5e2938
Author: Till Rohrmann <tr...@apache.org>
Date: 2017-08-04T22:28:15Z
[FLINK-7372] [JobGraph] Remove ActorGateway from JobGraph
The JobGraph has an unncessary dependency on the ActorGateway via its JobGraph#uploadUserJars method. In
order to get rid of this dependency for future Flip-6 changes, this commit retrieves the BlobServer's
address beforehand and directly passes it to this method.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #4483: [FLINK-7372] [JobGraph] Remove ActorGateway from JobGraph
Posted by zentol <gi...@git.apache.org>.
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/4483
+1, feel free to merge.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request #4483: [FLINK-7372] [JobGraph] Remove ActorGateway from J...
Posted by zentol <gi...@git.apache.org>.
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/4483#discussion_r131706778
--- Diff: flink-runtime/src/test/java/org/apache/flink/runtime/client/JobClientActorTest.java ---
@@ -388,7 +391,9 @@ else if (message instanceof RegisterJobClient) {
testFuture.tell(Acknowledge.get(), getSelf());
}
}
- else if (message instanceof RegisterTest) {
--- End diff --
Is the dollar sign intended?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request #4483: [FLINK-7372] [JobGraph] Remove ActorGateway from J...
Posted by zentol <gi...@git.apache.org>.
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/4483#discussion_r131708007
--- Diff: flink-runtime/src/test/java/org/apache/flink/runtime/client/JobClientActorTest.java ---
@@ -388,7 +391,9 @@ else if (message instanceof RegisterJobClient) {
testFuture.tell(Acknowledge.get(), getSelf());
}
}
- else if (message instanceof RegisterTest) {
+ else if (message instanceof RequestBlobManagerPort$) {
--- End diff --
Is the dollar sign intended?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request #4483: [FLINK-7372] [JobGraph] Remove ActorGateway from J...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/flink/pull/4483
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #4483: [FLINK-7372] [JobGraph] Remove ActorGateway from JobGraph
Posted by tillrohrmann <gi...@git.apache.org>.
Github user tillrohrmann commented on the issue:
https://github.com/apache/flink/pull/4483
Thanks for the review @zentol. Merging this PR.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #4483: [FLINK-7372] [JobGraph] Remove ActorGateway from JobGraph
Posted by tillrohrmann <gi...@git.apache.org>.
Github user tillrohrmann commented on the issue:
https://github.com/apache/flink/pull/4483
Rebased this PR onto the latest master.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request #4483: [FLINK-7372] [JobGraph] Remove ActorGateway from J...
Posted by tillrohrmann <gi...@git.apache.org>.
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/4483#discussion_r132140409
--- Diff: flink-runtime/src/test/java/org/apache/flink/runtime/client/JobClientActorTest.java ---
@@ -388,7 +391,9 @@ else if (message instanceof RegisterJobClient) {
testFuture.tell(Acknowledge.get(), getSelf());
}
}
- else if (message instanceof RegisterTest) {
+ else if (message instanceof RequestBlobManagerPort$) {
--- End diff --
Yes because `RequestBlobManagerPort` is a case object.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---