You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/01/02 14:16:46 UTC
[GitHub] [flink] tillrohrmann opened a new pull request #10750:
[FLINK-15459] Drop vendor specific repos from parent pom.xml
tillrohrmann opened a new pull request #10750: [FLINK-15459] Drop vendor specific repos from parent pom.xml
URL: https://github.com/apache/flink/pull/10750
## What is the purpose of the change
We no longer need builds for vendor specific repos as Flink no longer
bundles Hadoop dependencies. Putting the dependencies on the classpath
should be good enough.
cc @zentol
## Verifying this change
This change is a trivial rework / code cleanup without any test coverage.
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): (no)
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (no)
- The serializers: (no)
- The runtime per-record code paths (performance sensitive): (no)
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (no)
- The S3 file system connector: (no)
## Documentation
- Does this pull request introduce a new feature? (no)
- If yes, how is the feature documented? (not applicable)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot commented on issue #10750: [FLINK-15459] Drop
vendor specific repos from parent pom.xml
Posted by GitBox <gi...@apache.org>.
flinkbot commented on issue #10750: [FLINK-15459] Drop vendor specific repos from parent pom.xml
URL: https://github.com/apache/flink/pull/10750#issuecomment-570231383
<!--
Meta data
Hash:a6b6ede896a5bc247067a99905a0dbb06756ec6f Status:UNKNOWN URL:TBD TriggerType:PUSH TriggerID:a6b6ede896a5bc247067a99905a0dbb06756ec6f
-->
## CI report:
* a6b6ede896a5bc247067a99905a0dbb06756ec6f UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] tillrohrmann commented on issue #10750: [FLINK-15459] Drop
vendor specific repos from parent pom.xml
Posted by GitBox <gi...@apache.org>.
tillrohrmann commented on issue #10750: [FLINK-15459] Drop vendor specific repos from parent pom.xml
URL: https://github.com/apache/flink/pull/10750#issuecomment-570567333
Thanks for the review @zentol. Merging this PR now.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10750: [FLINK-15459]
Drop vendor specific repos from parent pom.xml
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10750: [FLINK-15459] Drop vendor specific repos from parent pom.xml
URL: https://github.com/apache/flink/pull/10750#issuecomment-570231383
<!--
Meta data
Hash:a6b6ede896a5bc247067a99905a0dbb06756ec6f Status:PENDING URL:https://travis-ci.com/flink-ci/flink/builds/142881303 TriggerType:PUSH TriggerID:a6b6ede896a5bc247067a99905a0dbb06756ec6f
Hash:a6b6ede896a5bc247067a99905a0dbb06756ec6f Status:PENDING URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4049 TriggerType:PUSH TriggerID:a6b6ede896a5bc247067a99905a0dbb06756ec6f
-->
## CI report:
* a6b6ede896a5bc247067a99905a0dbb06756ec6f Travis: [PENDING](https://travis-ci.com/flink-ci/flink/builds/142881303) Azure: [PENDING](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4049)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot commented on issue #10750: [FLINK-15459] Drop
vendor specific repos from parent pom.xml
Posted by GitBox <gi...@apache.org>.
flinkbot commented on issue #10750: [FLINK-15459] Drop vendor specific repos from parent pom.xml
URL: https://github.com/apache/flink/pull/10750#issuecomment-570220292
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.
## Automated Checks
Last check on commit a6b6ede896a5bc247067a99905a0dbb06756ec6f (Thu Jan 02 14:19:01 UTC 2020)
**Warnings:**
* **1 pom.xml files were touched**: Check for build and licensing issues.
* No documentation files were touched! Remember to keep the Flink docs up to date!
<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress
* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.
Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10750: [FLINK-15459]
Drop vendor specific repos from parent pom.xml
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10750: [FLINK-15459] Drop vendor specific repos from parent pom.xml
URL: https://github.com/apache/flink/pull/10750#issuecomment-570231383
<!--
Meta data
Hash:a6b6ede896a5bc247067a99905a0dbb06756ec6f Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/142881303 TriggerType:PUSH TriggerID:a6b6ede896a5bc247067a99905a0dbb06756ec6f
Hash:a6b6ede896a5bc247067a99905a0dbb06756ec6f Status:PENDING URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4049 TriggerType:PUSH TriggerID:a6b6ede896a5bc247067a99905a0dbb06756ec6f
-->
## CI report:
* a6b6ede896a5bc247067a99905a0dbb06756ec6f Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/142881303) Azure: [PENDING](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4049)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] tillrohrmann closed pull request #10750: [FLINK-15459] Drop
vendor specific repos from parent pom.xml
Posted by GitBox <gi...@apache.org>.
tillrohrmann closed pull request #10750: [FLINK-15459] Drop vendor specific repos from parent pom.xml
URL: https://github.com/apache/flink/pull/10750
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10750: [FLINK-15459]
Drop vendor specific repos from parent pom.xml
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10750: [FLINK-15459] Drop vendor specific repos from parent pom.xml
URL: https://github.com/apache/flink/pull/10750#issuecomment-570231383
<!--
Meta data
Hash:a6b6ede896a5bc247067a99905a0dbb06756ec6f Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/142881303 TriggerType:PUSH TriggerID:a6b6ede896a5bc247067a99905a0dbb06756ec6f
Hash:a6b6ede896a5bc247067a99905a0dbb06756ec6f Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4049 TriggerType:PUSH TriggerID:a6b6ede896a5bc247067a99905a0dbb06756ec6f
-->
## CI report:
* a6b6ede896a5bc247067a99905a0dbb06756ec6f Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/142881303) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4049)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] tillrohrmann commented on issue #10750: [FLINK-15459] Drop
vendor specific repos from parent pom.xml
Posted by GitBox <gi...@apache.org>.
tillrohrmann commented on issue #10750: [FLINK-15459] Drop vendor specific repos from parent pom.xml
URL: https://github.com/apache/flink/pull/10750#issuecomment-570249883
I thought the vendor specific documentation has been removed with f6ce8dd63f79868c102f412edc27811ee6f99978. I assume that the `mapr_setup.html` file is just a left over.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services