You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2021/02/06 09:59:46 UTC

[GitHub] [skywalking] wu-sheng commented on a change in pull request #6334: Support multiple implementations of StorageBuilder in different storage implementations - stage 1.

wu-sheng commented on a change in pull request #6334:
URL: https://github.com/apache/skywalking/pull/6334#discussion_r571398440



##########
File path: CHANGES.md
##########
@@ -17,6 +17,7 @@ Release Notes.
 * Metrics combination API supports abandoning results.
 * Add a new concept "Event" and its implementations to collect events.
 * Add some defensive codes for NPE and bump up Kubernetes client version to expose exception stack trace.
+* Refactor StorageBuilder to remove the dependency of Map.

Review comment:
       I am not sure either. I just want to make this kind of change clear to all developer. Do you want me to remove this?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org