You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by stefanobaghino <gi...@git.apache.org> on 2016/03/16 15:51:50 UTC
[GitHub] flink pull request: [hotfix][examples] Add zookeeper.connect to us...
GitHub user stefanobaghino opened a pull request:
https://github.com/apache/flink/pull/1803
[hotfix][examples] Add zookeeper.connect to usage line
Follow-up to [this thread](http://apache-flink-user-mailing-list-archive.2336050.n4.nabble.com/Unable-to-Read-from-Kafka-zookeeper-connect-error-td5577.html) on the Flink user mailing list.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/radicalbit/flink hotfix-examples-kafka
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/1803.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1803
----
commit 19e8f4dec235a5c696e6c232bfc4b1e260839dd8
Author: Stefano Baghino <st...@radicalbit.io>
Date: 2016-03-16T14:50:08Z
[hotfix][examples] Add zookeeper.connect to usage line
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [hotfix][examples] Add zookeeper.connect to us...
Posted by rmetzger <gi...@git.apache.org>.
Github user rmetzger commented on the pull request:
https://github.com/apache/flink/pull/1803#issuecomment-205232059
Just noticed that we added the zookeeper.connect to the wrong file. This belongs to the consumer not the producer.
Will fix it.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [hotfix][examples] Add zookeeper.connect to us...
Posted by stefanobaghino <gi...@git.apache.org>.
Github user stefanobaghino commented on the pull request:
https://github.com/apache/flink/pull/1803#issuecomment-205236293
Ok, thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [hotfix][examples] Add zookeeper.connect to us...
Posted by rmetzger <gi...@git.apache.org>.
Github user rmetzger commented on a diff in the pull request:
https://github.com/apache/flink/pull/1803#discussion_r56365066
--- Diff: flink-examples/flink-examples-streaming/src/main/java/org/apache/flink/streaming/examples/kafka/WriteIntoKafka.java ---
@@ -38,7 +38,8 @@
public static void main(String[] args) throws Exception {
ParameterTool parameterTool = ParameterTool.fromArgs(args);
if(parameterTool.getNumberOfParameters() < 2) {
--- End diff --
I guess the number of expected parameters is 3 now.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [hotfix][examples] Add zookeeper.connect to us...
Posted by stefanobaghino <gi...@git.apache.org>.
Github user stefanobaghino closed the pull request at:
https://github.com/apache/flink/pull/1803
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [hotfix][examples] Add zookeeper.connect to us...
Posted by stefanobaghino <gi...@git.apache.org>.
Github user stefanobaghino commented on the pull request:
https://github.com/apache/flink/pull/1803#issuecomment-205235613
You're right, sorry. I can fix this right now.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [hotfix][examples] Add zookeeper.connect to us...
Posted by rmetzger <gi...@git.apache.org>.
Github user rmetzger commented on the pull request:
https://github.com/apache/flink/pull/1803#issuecomment-205236018
Its fine, I fixed it already and will push a hotfix.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [hotfix][examples] Add zookeeper.connect to us...
Posted by rmetzger <gi...@git.apache.org>.
Github user rmetzger commented on the pull request:
https://github.com/apache/flink/pull/1803#issuecomment-197410235
Merging ...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [hotfix][examples] Add zookeeper.connect to us...
Posted by rmetzger <gi...@git.apache.org>.
Github user rmetzger commented on the pull request:
https://github.com/apache/flink/pull/1803#issuecomment-197412993
Can you close the issue manually? I forgot to include the close message into the commit
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [hotfix][examples] Add zookeeper.connect to us...
Posted by stefanobaghino <gi...@git.apache.org>.
Github user stefanobaghino commented on a diff in the pull request:
https://github.com/apache/flink/pull/1803#discussion_r56365211
--- Diff: flink-examples/flink-examples-streaming/src/main/java/org/apache/flink/streaming/examples/kafka/WriteIntoKafka.java ---
@@ -38,7 +38,8 @@
public static void main(String[] args) throws Exception {
ParameterTool parameterTool = ParameterTool.fromArgs(args);
if(parameterTool.getNumberOfParameters() < 2) {
--- End diff --
Right, thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---