You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2020/05/06 16:09:53 UTC

[GitHub] [incubator-tvm] mikeseven opened a new issue #5529: [BUG] ConvertLayout pass doesn't handle ops attributes

mikeseven opened a new issue #5529:
URL: https://github.com/apache/incubator-tvm/issues/5529


   While converting layout from TensorFlow, from NHWC to NCHW, I noticed LRN axis was not converted from using axis=3 to axis=1. 
   
   Looking at the code, I don't find where ConvertLayout pass would handle attributes of operators. So, potentially, I wonder if this bug on LRN may be even more widespread to other nodes?
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-tvm] tqchen commented on issue #5529: [BUG] ConvertLayout pass doesn't handle ops attributes

Posted by GitBox <gi...@apache.org>.
tqchen commented on issue #5529:
URL: https://github.com/apache/incubator-tvm/issues/5529#issuecomment-643343553


   cc @yzhliu @anijain2305 can you look into the issue?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-tvm] anijain2305 commented on issue #5529: [BUG] ConvertLayout pass doesn't handle ops attributes

Posted by GitBox <gi...@apache.org>.
anijain2305 commented on issue #5529:
URL: https://github.com/apache/incubator-tvm/issues/5529#issuecomment-643404059


   Yes, we dont have a registry for LRN. Not sure this is a bug. This seems like a missing feature. ConvertLayout will put LayoutTransforms before and after LRN.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-tvm] tqchen commented on issue #5529: [BUG] ConvertLayout pass doesn't handle ops attributes

Posted by GitBox <gi...@apache.org>.
tqchen commented on issue #5529:
URL: https://github.com/apache/incubator-tvm/issues/5529#issuecomment-643408715


   I see, if the result is generated corrected, then it should be missing feature case.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-tvm] yzhliu commented on issue #5529: [BUG] ConvertLayout pass doesn't handle ops attributes

Posted by GitBox <gi...@apache.org>.
yzhliu commented on issue #5529:
URL: https://github.com/apache/incubator-tvm/issues/5529#issuecomment-643392813


   The attributes are handled in registered python code, e.g., https://github.com/apache/incubator-tvm/blob/master/topi/python/topi/x86/conv2d_alter_op.py 
   I don't see such registry for LRN, did I miss anything @anijain2305 ?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-tvm] mikeseven commented on issue #5529: [RELAY][PASS] Handle Op Attribute for LRN in ConvertLayout

Posted by GitBox <gi...@apache.org>.
mikeseven commented on issue #5529:
URL: https://github.com/apache/incubator-tvm/issues/5529#issuecomment-663886124


   thanks @tqchen and @anijain2305 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org