You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@trafficcontrol.apache.org by GitBox <gi...@apache.org> on 2018/02/23 21:07:00 UTC
[GitHub] dewrich commented on a change in pull request #1922: TO golang -- add capability for custom changelog message per object type
dewrich commented on a change in pull request #1922: TO golang -- add capability for custom changelog message per object type
URL: https://github.com/apache/incubator-trafficcontrol/pull/1922#discussion_r170367923
##########
File path: traffic_ops/traffic_ops_golang/api/change_log.go
##########
@@ -37,6 +37,10 @@ type ChangeLog struct {
LastUpdated tc.Time `json:"lastUpdated" db:"last_updated"`
}
+type Logger interface {
+ ChangeLogMessage(action string, db *sqlx.DB) (string, error)
+}
+
Review comment:
since it's the ChangeLog, what about
type ChangeLog Interface{
Message{}
}
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services