[GitHub] [spark] dongjoon-hyun commented on a change in pull request #24996: [SPARK-28199][SS] Remove deprecated ProcessingTime

[GitBox <gi...@apache.org>]

dongjoon-hyun commented on a change in pull request #24996: [SPARK-28199][SS] Remove deprecated ProcessingTime
URL: https://github.com/apache/spark/pull/24996#discussion_r300160455
 
 

 ##########
 File path: sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/TriggerExecutor.scala
 ##########
 @@ -43,7 +42,9 @@ case class OneTimeExecutor() extends TriggerExecutor {
 /**
  * A trigger executor that runs a batch every `intervalMs` milliseconds.
  */
-case class ProcessingTimeExecutor(processingTime: ProcessingTime, clock: Clock = new SystemClock())
+case class ProcessingTimeExecutor(
+    processingTime: ProcessingTimeTrigger,
 
 Review comment:
   Please rename the variable together.
   - `processingTime` -> `processingTimeTrigger`.
   - `private val intervalMs = processingTime.intervalMs` -> `private val intervalMs = processingTimeTrigger.intervalMs`

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org