You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2020/09/10 04:41:33 UTC
[GitHub] [apisix-dashboard] nic-chen opened a new pull request #462: chore: remove unnecessary license file
nic-chen opened a new pull request #462:
URL: https://github.com/apache/apisix-dashboard/pull/462
Please answer these questions before submitting a pull request
- Why submit this pull request?
remove unnecessary license file for lib `dag-to-lua` which just is a dependency not in this repo.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] juzhiyuan merged pull request #462: chore: remove unnecessary license file
Posted by GitBox <gi...@apache.org>.
juzhiyuan merged pull request #462:
URL: https://github.com/apache/apisix-dashboard/pull/462
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] nic-chen commented on a change in pull request #462: chore: remove unnecessary license file
Posted by GitBox <gi...@apache.org>.
nic-chen commented on a change in pull request #462:
URL: https://github.com/apache/apisix-dashboard/pull/462#discussion_r486080122
##########
File path: LICENSE
##########
@@ -224,5 +224,5 @@ Apache 2.0 licenses
The following components are provided under the Apache 2.0 License. See project link for details.
The text of each license is also included at licenses/LICENSE-[project].txt.
- files from dag-to-lua: https://github.com/api7/dag-to-lua Apache 2.0
- files from api7-dashboard: https://github.com/api7/dashboard-components Apache 2.0
\ No newline at end of file
+ files from api7-dashboard: https://github.com/api7/dashboard-components Apache 2.0
Review comment:
removed too
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] moonming commented on a change in pull request #462: chore: remove unnecessary license file
Posted by GitBox <gi...@apache.org>.
moonming commented on a change in pull request #462:
URL: https://github.com/apache/apisix-dashboard/pull/462#discussion_r486059913
##########
File path: LICENSE
##########
@@ -224,5 +224,5 @@ Apache 2.0 licenses
The following components are provided under the Apache 2.0 License. See project link for details.
The text of each license is also included at licenses/LICENSE-[project].txt.
- files from dag-to-lua: https://github.com/api7/dag-to-lua Apache 2.0
- files from api7-dashboard: https://github.com/api7/dashboard-components Apache 2.0
\ No newline at end of file
+ files from api7-dashboard: https://github.com/api7/dashboard-components Apache 2.0
Review comment:
are these code files in dashboard repo?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org