[GitHub] [openwhisk] markusthoemmes commented on a change in pull request #4754: Mcdan/truncate keep running

[GitBox <gi...@apache.org>]

markusthoemmes commented on a change in pull request #4754: Mcdan/truncate keep running
URL: https://github.com/apache/openwhisk/pull/4754#discussion_r350851480
 
 

 ##########
 File path: common/scala/src/main/scala/org/apache/openwhisk/core/entity/ActivationResult.scala
 ##########
 @@ -62,40 +63,47 @@ protected[core] object ActivationResponse extends DefaultJsonProtocol {
   val ApplicationError = 1 // action ran but there was an error and it was handled
   val DeveloperError = 2 // action ran but failed to handle an error, or action did not run and failed to initialize
   val WhiskError = 3 // internal system error
+  val Truncated = 4 // action ran correctly, but returned a response that was too large
 
 Review comment:
   imo it's not necessary for other parts of the code to know, at least not in step 1. Feels like we should make this an application error first and maybe discuss on the dev list if people feel that there's a need to carry it being a TruncationError further into the codebase. That could then quite simply be a second PR?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services