You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mahout.apache.org by "Julien Aymé (JIRA)" <ji...@apache.org> on 2012/10/12 11:31:03 UTC

[jira] [Created] (MAHOUT-1101) [PATCH] RecommenderServlet: Wrong output when using JSON format

Julien Aymé created MAHOUT-1101:
-----------------------------------

             Summary: [PATCH] RecommenderServlet: Wrong output when using JSON format 
                 Key: MAHOUT-1101
                 URL: https://issues.apache.org/jira/browse/MAHOUT-1101
             Project: Mahout
          Issue Type: Bug
          Components: Collaborative Filtering, Integration
    Affects Versions: 0.7, 0.8
            Reporter: Julien Aymé
            Assignee: Sean Owen
            Priority: Trivial
         Attachments: RecommenderServlet.java.patch

When using "json" as format for the RecommenderServlet, the JSON returned is not valid: there is a comma ',' just before the closing bracket of the "item" array.

The fix is trivial: do not add a ',' if the item is the last one.
Patch is attached.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (MAHOUT-1101) [PATCH] RecommenderServlet: Wrong output when using JSON format

Posted by "Julien Aymé (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/MAHOUT-1101?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Julien Aymé updated MAHOUT-1101:
--------------------------------

    Attachment: RecommenderServlet.java.patch

The proposed patch
                
> [PATCH] RecommenderServlet: Wrong output when using JSON format 
> ----------------------------------------------------------------
>
>                 Key: MAHOUT-1101
>                 URL: https://issues.apache.org/jira/browse/MAHOUT-1101
>             Project: Mahout
>          Issue Type: Bug
>          Components: Collaborative Filtering, Integration
>    Affects Versions: 0.7, 0.8
>            Reporter: Julien Aymé
>            Assignee: Sean Owen
>            Priority: Trivial
>              Labels: patch
>         Attachments: RecommenderServlet.java.patch
>
>   Original Estimate: 1h
>  Remaining Estimate: 1h
>
> When using "json" as format for the RecommenderServlet, the JSON returned is not valid: there is a comma ',' just before the closing bracket of the "item" array.
> The fix is trivial: do not add a ',' if the item is the last one.
> Patch is attached.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Resolved] (MAHOUT-1101) [PATCH] RecommenderServlet: Wrong output when using JSON format

Posted by "Sean Owen (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/MAHOUT-1101?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Sean Owen resolved MAHOUT-1101.
-------------------------------

       Resolution: Fixed
    Fix Version/s: 0.8

Also a good one, fixed.
                
> [PATCH] RecommenderServlet: Wrong output when using JSON format 
> ----------------------------------------------------------------
>
>                 Key: MAHOUT-1101
>                 URL: https://issues.apache.org/jira/browse/MAHOUT-1101
>             Project: Mahout
>          Issue Type: Bug
>          Components: Collaborative Filtering, Integration
>    Affects Versions: 0.7, 0.8
>            Reporter: Julien Aymé
>            Assignee: Sean Owen
>            Priority: Trivial
>              Labels: patch
>             Fix For: 0.8
>
>         Attachments: RecommenderServlet.java.patch
>
>   Original Estimate: 1h
>  Remaining Estimate: 1h
>
> When using "json" as format for the RecommenderServlet, the JSON returned is not valid: there is a comma ',' just before the closing bracket of the "item" array.
> The fix is trivial: do not add a ',' if the item is the last one.
> Patch is attached.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (MAHOUT-1101) [PATCH] RecommenderServlet: Wrong output when using JSON format

Posted by "Hudson (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/MAHOUT-1101?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13474939#comment-13474939 ] 

Hudson commented on MAHOUT-1101:
--------------------------------

Integrated in Mahout-Quality #1702 (See [https://builds.apache.org/job/Mahout-Quality/1702/])
    MAHOUT-1101 remove trailing comma from JSON array in output (Revision 1397500)

     Result = SUCCESS
srowen : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1397500
Files : 
* /mahout/trunk/integration/src/main/java/org/apache/mahout/cf/taste/web/RecommenderServlet.java

                
> [PATCH] RecommenderServlet: Wrong output when using JSON format 
> ----------------------------------------------------------------
>
>                 Key: MAHOUT-1101
>                 URL: https://issues.apache.org/jira/browse/MAHOUT-1101
>             Project: Mahout
>          Issue Type: Bug
>          Components: Collaborative Filtering, Integration
>    Affects Versions: 0.7, 0.8
>            Reporter: Julien Aymé
>            Assignee: Sean Owen
>            Priority: Trivial
>              Labels: patch
>             Fix For: 0.8
>
>         Attachments: RecommenderServlet.java.patch
>
>   Original Estimate: 1h
>  Remaining Estimate: 1h
>
> When using "json" as format for the RecommenderServlet, the JSON returned is not valid: there is a comma ',' just before the closing bracket of the "item" array.
> The fix is trivial: do not add a ',' if the item is the last one.
> Patch is attached.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (MAHOUT-1101) [PATCH] RecommenderServlet: Wrong output when using JSON format

Posted by "Julien Aymé (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/MAHOUT-1101?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Julien Aymé updated MAHOUT-1101:
--------------------------------

    Labels: patch  (was: patch test)
    
> [PATCH] RecommenderServlet: Wrong output when using JSON format 
> ----------------------------------------------------------------
>
>                 Key: MAHOUT-1101
>                 URL: https://issues.apache.org/jira/browse/MAHOUT-1101
>             Project: Mahout
>          Issue Type: Bug
>          Components: Collaborative Filtering, Integration
>    Affects Versions: 0.7, 0.8
>            Reporter: Julien Aymé
>            Assignee: Sean Owen
>            Priority: Trivial
>              Labels: patch
>         Attachments: RecommenderServlet.java.patch
>
>   Original Estimate: 1h
>  Remaining Estimate: 1h
>
> When using "json" as format for the RecommenderServlet, the JSON returned is not valid: there is a comma ',' just before the closing bracket of the "item" array.
> The fix is trivial: do not add a ',' if the item is the last one.
> Patch is attached.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira