You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by viirya <gi...@git.apache.org> on 2018/04/05 14:53:08 UTC

[GitHub] spark pull request #20985: [SPARK-23593][SQL] Add interpreted execution for ...

GitHub user viirya opened a pull request:

    https://github.com/apache/spark/pull/20985

    [SPARK-23593][SQL] Add interpreted execution for InitializeJavaBean expression

    ## What changes were proposed in this pull request?
    
    Add interpreted execution for `InitializeJavaBean` expression.
    
    ## How was this patch tested?
    
    Added unit test.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/viirya/spark-1 SPARK-23593-2

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/spark/pull/20985.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #20985
    
----
commit 978080bd8f5a1b095fd0d58ff529e16dd9cbadba
Author: Liang-Chi Hsieh <vi...@...>
Date:   2018-03-07T02:56:53Z

    Add interpreted execution for InitializeJavaBean expression.

commit 0c48a9ba2551435e3794b4e98002423b9a8d527b
Author: Liang-Chi Hsieh <vi...@...>
Date:   2018-03-07T03:16:57Z

    Merge remote-tracking branch 'upstream/master' into SPARK-23593

commit b8f171e5492f3156767589ad4c6ed458cb24615c
Author: Liang-Chi Hsieh <vi...@...>
Date:   2018-03-07T03:24:48Z

    Test error message of interpreted execution.

commit b51303a49c66a178e9cdd717605e3ef0d41e6a3a
Author: Liang-Chi Hsieh <vi...@...>
Date:   2018-03-07T13:03:07Z

    Resolving setters outside eval.

commit 6372f040532730800dc48900b670c914e375e1aa
Author: Liang-Chi Hsieh <vi...@...>
Date:   2018-03-08T04:32:51Z

    Merge remote-tracking branch 'upstream/master' into SPARK-23593

commit 970ed6c6497c148d6eba10fe65f947c05b58d642
Author: Liang-Chi Hsieh <vi...@...>
Date:   2018-03-08T04:40:10Z

    Simplifying it.

commit e20c207801613b45fea34520c05f59e9cb453351
Author: Liang-Chi Hsieh <vi...@...>
Date:   2018-03-08T08:45:47Z

    Address comment.

commit f3fdf575c599a5d0d8fdaacebcd67bfbc89d39fd
Author: Liang-Chi Hsieh <vi...@...>
Date:   2018-03-08T13:43:20Z

    Change error message a bit.

commit 1a783346a14e93e5dd755185071ca2e93360f387
Author: Liang-Chi Hsieh <vi...@...>
Date:   2018-03-09T04:37:38Z

    Use AnyRef.

commit e7640e14ac8eea8ba5521d80f640664e5753bb9f
Author: Liang-Chi Hsieh <vi...@...>
Date:   2018-03-27T03:57:20Z

    Add a test.

commit 0d6b3d355276210ad6a0967646f30d95744ddfcb
Author: Liang-Chi Hsieh <vi...@...>
Date:   2018-04-05T06:03:47Z

    Prevent null input to setters.

commit 2954e8dab80cc91bb8bb821d1154fb11d5ff6fab
Author: Liang-Chi Hsieh <vi...@...>
Date:   2018-04-05T06:04:06Z

    Merge remote-tracking branch 'upstream/master' into SPARK-23593

commit 96a8fe6102d8d175003392a14d67cd74c0b86319
Author: Liang-Chi Hsieh <vi...@...>
Date:   2018-04-05T06:30:17Z

    Prevent null input to setters.

commit 573db595ee84e894b7d7093884d7fdef2c040150
Author: Liang-Chi Hsieh <vi...@...>
Date:   2018-04-05T06:33:27Z

    Fix out-of-date comment.

commit 7f1aeb064d7efa26a2e4ec8d0d1abcb6b9b7c7c9
Author: Liang-Chi Hsieh <vi...@...>
Date:   2018-04-05T14:49:55Z

    Don't call setters if input is null.

----


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark issue #20985: [SPARK-23593][SQL] Add interpreted execution for Initial...

Posted by hvanhovell <gi...@git.apache.org>.
Github user hvanhovell commented on the issue:

    https://github.com/apache/spark/pull/20985
  
    Merging to master. Thanks!


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark issue #20985: [SPARK-23593][SQL] Add interpreted execution for Initial...

Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:

    https://github.com/apache/spark/pull/20985
  
    Merged build finished. Test PASSed.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark issue #20985: [SPARK-23593][SQL] Add interpreted execution for Initial...

Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:

    https://github.com/apache/spark/pull/20985
  
    Test PASSed.
    Refer to this link for build results (access rights to CI server needed): 
    https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/2007/
    Test PASSed.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark issue #20985: [SPARK-23593][SQL] Add interpreted execution for Initial...

Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:

    https://github.com/apache/spark/pull/20985
  
    Merged build finished. Test PASSed.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark issue #20985: [SPARK-23593][SQL] Add interpreted execution for Initial...

Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:

    https://github.com/apache/spark/pull/20985
  
    **[Test build #88944 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/88944/testReport)** for PR 20985 at commit [`7f1aeb0`](https://github.com/apache/spark/commit/7f1aeb064d7efa26a2e4ec8d0d1abcb6b9b7c7c9).


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark pull request #20985: [SPARK-23593][SQL] Add interpreted execution for ...

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/spark/pull/20985


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark issue #20985: [SPARK-23593][SQL] Add interpreted execution for Initial...

Posted by viirya <gi...@git.apache.org>.
Github user viirya commented on the issue:

    https://github.com/apache/spark/pull/20985
  
    cc @hvanhovell 


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark issue #20985: [SPARK-23593][SQL] Add interpreted execution for Initial...

Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:

    https://github.com/apache/spark/pull/20985
  
    Test PASSed.
    Refer to this link for build results (access rights to CI server needed): 
    https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/88944/
    Test PASSed.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark issue #20985: [SPARK-23593][SQL] Add interpreted execution for Initial...

Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:

    https://github.com/apache/spark/pull/20985
  
    **[Test build #88944 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/88944/testReport)** for PR 20985 at commit [`7f1aeb0`](https://github.com/apache/spark/commit/7f1aeb064d7efa26a2e4ec8d0d1abcb6b9b7c7c9).
     * This patch passes all tests.
     * This patch merges cleanly.
     * This patch adds no public classes.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org