You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@ambari.apache.org by venkat sairam <ve...@gmail.com> on 2017/02/23 06:44:14 UTC
Review Request 56972: Improper action node name after importing the
asset
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56972/
-----------------------------------------------------------
Review request for Ambari, belliraj hb, Gaurav Nagar, Nitiraj Rathore, and Pallav Kulshreshtha.
Bugs: AMBARI-20134
https://issues.apache.org/jira/browse/AMBARI-20134
Repository: ambari
Description
-------
Action node name is not proper after importing asset. Once user imports the asset, the node name is displayed as <nodename>_undefined.
Instead of this, if there are no other action nodes of this type, then just show the actual node name.
And if there are already existing nodes of this type, then show <nodename>_<nodecount>.
Diffs
-----
contrib/views/wfmanager/src/main/resources/ui/app/components/flow-designer.js b2b9c68
contrib/views/wfmanager/src/main/resources/ui/app/domain/workflow.js 0fc5d6c
Diff: https://reviews.apache.org/r/56972/diff/
Testing
-------
Manual testing done
Thanks,
venkat sairam
Re: Review Request 56972: Improper action node name after importing
the asset
Posted by Gaurav Nagar <gn...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56972/#review166486
-----------------------------------------------------------
Ship it!
Ship It!
- Gaurav Nagar
On Feb. 23, 2017, 6:44 a.m., venkat sairam wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56972/
> -----------------------------------------------------------
>
> (Updated Feb. 23, 2017, 6:44 a.m.)
>
>
> Review request for Ambari, belliraj hb, Gaurav Nagar, Nitiraj Rathore, and Pallav Kulshreshtha.
>
>
> Bugs: AMBARI-20134
> https://issues.apache.org/jira/browse/AMBARI-20134
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Action node name is not proper after importing asset. Once user imports the asset, the node name is displayed as <nodename>_undefined.
> Instead of this, if there are no other action nodes of this type, then just show the actual node name.
> And if there are already existing nodes of this type, then show <nodename>_<nodecount>.
>
>
> Diffs
> -----
>
> contrib/views/wfmanager/src/main/resources/ui/app/components/flow-designer.js b2b9c68
> contrib/views/wfmanager/src/main/resources/ui/app/domain/workflow.js 0fc5d6c
>
> Diff: https://reviews.apache.org/r/56972/diff/
>
>
> Testing
> -------
>
> Manual testing done
>
>
> Thanks,
>
> venkat sairam
>
>
Re: Review Request 56972: Improper action node name after importing
the asset
Posted by Pallav Kulshreshtha <pa...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56972/#review166488
-----------------------------------------------------------
Ship it!
Ship It!
- Pallav Kulshreshtha
On Feb. 23, 2017, 6:44 a.m., venkat sairam wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56972/
> -----------------------------------------------------------
>
> (Updated Feb. 23, 2017, 6:44 a.m.)
>
>
> Review request for Ambari, belliraj hb, Gaurav Nagar, Nitiraj Rathore, and Pallav Kulshreshtha.
>
>
> Bugs: AMBARI-20134
> https://issues.apache.org/jira/browse/AMBARI-20134
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Action node name is not proper after importing asset. Once user imports the asset, the node name is displayed as <nodename>_undefined.
> Instead of this, if there are no other action nodes of this type, then just show the actual node name.
> And if there are already existing nodes of this type, then show <nodename>_<nodecount>.
>
>
> Diffs
> -----
>
> contrib/views/wfmanager/src/main/resources/ui/app/components/flow-designer.js b2b9c68
> contrib/views/wfmanager/src/main/resources/ui/app/domain/workflow.js 0fc5d6c
>
> Diff: https://reviews.apache.org/r/56972/diff/
>
>
> Testing
> -------
>
> Manual testing done
>
>
> Thanks,
>
> venkat sairam
>
>
Re: Review Request 56972: Improper action node name after importing
the asset
Posted by belliraj hb <be...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56972/#review166484
-----------------------------------------------------------
Ship it!
Ship It!
- belliraj hb
On Feb. 23, 2017, 6:44 a.m., venkat sairam wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56972/
> -----------------------------------------------------------
>
> (Updated Feb. 23, 2017, 6:44 a.m.)
>
>
> Review request for Ambari, belliraj hb, Gaurav Nagar, Nitiraj Rathore, and Pallav Kulshreshtha.
>
>
> Bugs: AMBARI-20134
> https://issues.apache.org/jira/browse/AMBARI-20134
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Action node name is not proper after importing asset. Once user imports the asset, the node name is displayed as <nodename>_undefined.
> Instead of this, if there are no other action nodes of this type, then just show the actual node name.
> And if there are already existing nodes of this type, then show <nodename>_<nodecount>.
>
>
> Diffs
> -----
>
> contrib/views/wfmanager/src/main/resources/ui/app/components/flow-designer.js b2b9c68
> contrib/views/wfmanager/src/main/resources/ui/app/domain/workflow.js 0fc5d6c
>
> Diff: https://reviews.apache.org/r/56972/diff/
>
>
> Testing
> -------
>
> Manual testing done
>
>
> Thanks,
>
> venkat sairam
>
>