You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cordova.apache.org by Joe Bowser <bo...@gmail.com> on 2013/05/27 01:55:39 UTC
Changes in Mobile-Spec are breaking Cordova on Android 4.0.3 ICS
Hey
While I was setting up my environment on the Chromebook for JSConf, I
noticed that I ran into the Android 4.0.3 bug again. It seems that
when I was testing 4.0.3 last, I was using an old mobile-spec. After
going through the project, it seems that the changes that were made to
mobile-spec breaks rendering on Android. I have no idea why this
would be, but this browser bug has nothing to do with the Android
changes, and is most likely something to do with the Android ICS
browser being a piece of crap.
At any rate, can we get this fixed so that we can actually test this
release? What did we do to break mobile-spec on Ice Cream Sandwich?
Anyone have any ideas?
Joe
Re: Changes in Mobile-Spec are breaking Cordova on Android 4.0.3 ICS
Posted by Michal Mocny <mm...@chromium.org>.
Well I just suck. Please ignore me and dont sidetrack the original
question!
On Sun, May 26, 2013 at 10:06 PM, Michal Mocny <mm...@chromium.org> wrote:
> [private reply]
>
> Didn't want to sidetrack the discussion, but im curious about your
> chromebook workflow.. are you doing full local dev using crouton, using a
> remote connection, or something like phonegap build using local environment
> just for text editing?
>
> And which machine are you using?
>
> Thanks.
> -Michal
>
>
> On Sun, May 26, 2013 at 7:55 PM, Joe Bowser <bo...@gmail.com> wrote:
>
>> Hey
>>
>> While I was setting up my environment on the Chromebook for JSConf, I
>> noticed that I ran into the Android 4.0.3 bug again. It seems that
>> when I was testing 4.0.3 last, I was using an old mobile-spec. After
>> going through the project, it seems that the changes that were made to
>> mobile-spec breaks rendering on Android. I have no idea why this
>> would be, but this browser bug has nothing to do with the Android
>> changes, and is most likely something to do with the Android ICS
>> browser being a piece of crap.
>>
>> At any rate, can we get this fixed so that we can actually test this
>> release? What did we do to break mobile-spec on Ice Cream Sandwich?
>> Anyone have any ideas?
>>
>> Joe
>>
>
>
Re: Changes in Mobile-Spec are breaking Cordova on Android 4.0.3 ICS
Posted by Michal Mocny <mm...@chromium.org>.
[private reply]
Didn't want to sidetrack the discussion, but im curious about your
chromebook workflow.. are you doing full local dev using crouton, using a
remote connection, or something like phonegap build using local environment
just for text editing?
And which machine are you using?
Thanks.
-Michal
On Sun, May 26, 2013 at 7:55 PM, Joe Bowser <bo...@gmail.com> wrote:
> Hey
>
> While I was setting up my environment on the Chromebook for JSConf, I
> noticed that I ran into the Android 4.0.3 bug again. It seems that
> when I was testing 4.0.3 last, I was using an old mobile-spec. After
> going through the project, it seems that the changes that were made to
> mobile-spec breaks rendering on Android. I have no idea why this
> would be, but this browser bug has nothing to do with the Android
> changes, and is most likely something to do with the Android ICS
> browser being a piece of crap.
>
> At any rate, can we get this fixed so that we can actually test this
> release? What did we do to break mobile-spec on Ice Cream Sandwich?
> Anyone have any ideas?
>
> Joe
>
Re: Changes in Mobile-Spec are breaking Cordova on Android 4.0.3 ICS
Posted by Max Woghiren <ma...@chromium.org>.
Okay—I'll commit the reversion. Jesse will investigate another approach to
eliminating document.write; Jesse, let me know if you have something else
to try and I'll run it on the offending device.
On Mon, May 27, 2013 at 3:25 PM, Jesse <pu...@gmail.com> wrote:
> Yes, there is a restriction against writing scripts with document.write in
> Windows8 for Windows Store Apps.
> + I think that the proper way via createElement.
> If you think it is better to just revert my change, that is fine, but I
> think it points to another latent bug that is requiring a specific load
> order, and we had/have an unknown race condition issue.
> I will also look at alternatives.
>
> Max, did reverting it fix it?
>
>
> @purplecabbage
> risingj.com
>
>
> On Mon, May 27, 2013 at 11:04 AM, Max Woghiren <ma...@chromium.org> wrote:
>
>> I'll take a look at whether reverting this change fixes the issue. If
>> so, I'll also wait for Jesse to chime in before doing anything else with it.
>>
>>
>> On Mon, May 27, 2013 at 1:52 PM, Joe Bowser <bo...@gmail.com> wrote:
>>
>>> I think it was made because document.write is ugly. That being said,
>>> does this break something for WP? Seriously, adding a script tag
>>> shouldn't cause the browser to not redraw, but I've seen stranger.
>>>
>>> On Mon, May 27, 2013 at 10:49 AM, Andrew Grieve <ag...@chromium.org>
>>> wrote:
>>> > Might have been this change:
>>> >
>>> https://git-wip-us.apache.org/repos/asf?p=cordova-mobile-spec.git;a=blobdiff;f=cordova-incl.js;h=458e10a7155d812d084720f7082c4aa1c63f44c8;hp=c624996236eb2c7501714b48206c0b085460317a;hb=8b1fd7d49c278d43b34b4c041f1575a1a39a664d;hpb=ae18f3ea59d0b53880644ef8f8dcc3d0ade6f76d
>>> >
>>> > Maybe let's just revert it? Not sure why it was made in the first
>>> place?
>>> >
>>> >
>>> > On Sun, May 26, 2013 at 7:55 PM, Joe Bowser <bo...@gmail.com> wrote:
>>> >
>>> >> Hey
>>> >>
>>> >> While I was setting up my environment on the Chromebook for JSConf, I
>>> >> noticed that I ran into the Android 4.0.3 bug again. It seems that
>>> >> when I was testing 4.0.3 last, I was using an old mobile-spec. After
>>> >> going through the project, it seems that the changes that were made to
>>> >> mobile-spec breaks rendering on Android. I have no idea why this
>>> >> would be, but this browser bug has nothing to do with the Android
>>> >> changes, and is most likely something to do with the Android ICS
>>> >> browser being a piece of crap.
>>> >>
>>> >> At any rate, can we get this fixed so that we can actually test this
>>> >> release? What did we do to break mobile-spec on Ice Cream Sandwich?
>>> >> Anyone have any ideas?
>>> >>
>>> >> Joe
>>> >>
>>>
>>
>>
>
Re: Changes in Mobile-Spec are breaking Cordova on Android 4.0.3 ICS
Posted by Max Woghiren <ma...@chromium.org>.
Yes, reverting 8b1fd7d49c278d43b34b4c041f1575a1a39a664d fixes the issue.
On Mon, May 27, 2013 at 3:25 PM, Jesse <pu...@gmail.com> wrote:
> Yes, there is a restriction against writing scripts with document.write in
> Windows8 for Windows Store Apps.
> + I think that the proper way via createElement.
> If you think it is better to just revert my change, that is fine, but I
> think it points to another latent bug that is requiring a specific load
> order, and we had/have an unknown race condition issue.
> I will also look at alternatives.
>
> Max, did reverting it fix it?
>
>
> @purplecabbage
> risingj.com
>
>
> On Mon, May 27, 2013 at 11:04 AM, Max Woghiren <ma...@chromium.org> wrote:
>
>> I'll take a look at whether reverting this change fixes the issue. If
>> so, I'll also wait for Jesse to chime in before doing anything else with it.
>>
>>
>> On Mon, May 27, 2013 at 1:52 PM, Joe Bowser <bo...@gmail.com> wrote:
>>
>>> I think it was made because document.write is ugly. That being said,
>>> does this break something for WP? Seriously, adding a script tag
>>> shouldn't cause the browser to not redraw, but I've seen stranger.
>>>
>>> On Mon, May 27, 2013 at 10:49 AM, Andrew Grieve <ag...@chromium.org>
>>> wrote:
>>> > Might have been this change:
>>> >
>>> https://git-wip-us.apache.org/repos/asf?p=cordova-mobile-spec.git;a=blobdiff;f=cordova-incl.js;h=458e10a7155d812d084720f7082c4aa1c63f44c8;hp=c624996236eb2c7501714b48206c0b085460317a;hb=8b1fd7d49c278d43b34b4c041f1575a1a39a664d;hpb=ae18f3ea59d0b53880644ef8f8dcc3d0ade6f76d
>>> >
>>> > Maybe let's just revert it? Not sure why it was made in the first
>>> place?
>>> >
>>> >
>>> > On Sun, May 26, 2013 at 7:55 PM, Joe Bowser <bo...@gmail.com> wrote:
>>> >
>>> >> Hey
>>> >>
>>> >> While I was setting up my environment on the Chromebook for JSConf, I
>>> >> noticed that I ran into the Android 4.0.3 bug again. It seems that
>>> >> when I was testing 4.0.3 last, I was using an old mobile-spec. After
>>> >> going through the project, it seems that the changes that were made to
>>> >> mobile-spec breaks rendering on Android. I have no idea why this
>>> >> would be, but this browser bug has nothing to do with the Android
>>> >> changes, and is most likely something to do with the Android ICS
>>> >> browser being a piece of crap.
>>> >>
>>> >> At any rate, can we get this fixed so that we can actually test this
>>> >> release? What did we do to break mobile-spec on Ice Cream Sandwich?
>>> >> Anyone have any ideas?
>>> >>
>>> >> Joe
>>> >>
>>>
>>
>>
>
Re: Changes in Mobile-Spec are breaking Cordova on Android 4.0.3 ICS
Posted by Jesse <pu...@gmail.com>.
Yes, there is a restriction against writing scripts with document.write in
Windows8 for Windows Store Apps.
+ I think that the proper way via createElement.
If you think it is better to just revert my change, that is fine, but I
think it points to another latent bug that is requiring a specific load
order, and we had/have an unknown race condition issue.
I will also look at alternatives.
Max, did reverting it fix it?
@purplecabbage
risingj.com
On Mon, May 27, 2013 at 11:04 AM, Max Woghiren <ma...@chromium.org> wrote:
> I'll take a look at whether reverting this change fixes the issue. If so,
> I'll also wait for Jesse to chime in before doing anything else with it.
>
>
> On Mon, May 27, 2013 at 1:52 PM, Joe Bowser <bo...@gmail.com> wrote:
>
>> I think it was made because document.write is ugly. That being said,
>> does this break something for WP? Seriously, adding a script tag
>> shouldn't cause the browser to not redraw, but I've seen stranger.
>>
>> On Mon, May 27, 2013 at 10:49 AM, Andrew Grieve <ag...@chromium.org>
>> wrote:
>> > Might have been this change:
>> >
>> https://git-wip-us.apache.org/repos/asf?p=cordova-mobile-spec.git;a=blobdiff;f=cordova-incl.js;h=458e10a7155d812d084720f7082c4aa1c63f44c8;hp=c624996236eb2c7501714b48206c0b085460317a;hb=8b1fd7d49c278d43b34b4c041f1575a1a39a664d;hpb=ae18f3ea59d0b53880644ef8f8dcc3d0ade6f76d
>> >
>> > Maybe let's just revert it? Not sure why it was made in the first place?
>> >
>> >
>> > On Sun, May 26, 2013 at 7:55 PM, Joe Bowser <bo...@gmail.com> wrote:
>> >
>> >> Hey
>> >>
>> >> While I was setting up my environment on the Chromebook for JSConf, I
>> >> noticed that I ran into the Android 4.0.3 bug again. It seems that
>> >> when I was testing 4.0.3 last, I was using an old mobile-spec. After
>> >> going through the project, it seems that the changes that were made to
>> >> mobile-spec breaks rendering on Android. I have no idea why this
>> >> would be, but this browser bug has nothing to do with the Android
>> >> changes, and is most likely something to do with the Android ICS
>> >> browser being a piece of crap.
>> >>
>> >> At any rate, can we get this fixed so that we can actually test this
>> >> release? What did we do to break mobile-spec on Ice Cream Sandwich?
>> >> Anyone have any ideas?
>> >>
>> >> Joe
>> >>
>>
>
>
Re: Changes in Mobile-Spec are breaking Cordova on Android 4.0.3 ICS
Posted by Max Woghiren <ma...@chromium.org>.
I'll take a look at whether reverting this change fixes the issue. If so,
I'll also wait for Jesse to chime in before doing anything else with it.
On Mon, May 27, 2013 at 1:52 PM, Joe Bowser <bo...@gmail.com> wrote:
> I think it was made because document.write is ugly. That being said,
> does this break something for WP? Seriously, adding a script tag
> shouldn't cause the browser to not redraw, but I've seen stranger.
>
> On Mon, May 27, 2013 at 10:49 AM, Andrew Grieve <ag...@chromium.org>
> wrote:
> > Might have been this change:
> >
> https://git-wip-us.apache.org/repos/asf?p=cordova-mobile-spec.git;a=blobdiff;f=cordova-incl.js;h=458e10a7155d812d084720f7082c4aa1c63f44c8;hp=c624996236eb2c7501714b48206c0b085460317a;hb=8b1fd7d49c278d43b34b4c041f1575a1a39a664d;hpb=ae18f3ea59d0b53880644ef8f8dcc3d0ade6f76d
> >
> > Maybe let's just revert it? Not sure why it was made in the first place?
> >
> >
> > On Sun, May 26, 2013 at 7:55 PM, Joe Bowser <bo...@gmail.com> wrote:
> >
> >> Hey
> >>
> >> While I was setting up my environment on the Chromebook for JSConf, I
> >> noticed that I ran into the Android 4.0.3 bug again. It seems that
> >> when I was testing 4.0.3 last, I was using an old mobile-spec. After
> >> going through the project, it seems that the changes that were made to
> >> mobile-spec breaks rendering on Android. I have no idea why this
> >> would be, but this browser bug has nothing to do with the Android
> >> changes, and is most likely something to do with the Android ICS
> >> browser being a piece of crap.
> >>
> >> At any rate, can we get this fixed so that we can actually test this
> >> release? What did we do to break mobile-spec on Ice Cream Sandwich?
> >> Anyone have any ideas?
> >>
> >> Joe
> >>
>
Re: Changes in Mobile-Spec are breaking Cordova on Android 4.0.3 ICS
Posted by Andrew Grieve <ag...@chromium.org>.
It may be ugly, but the change certainly changes the semantics of the code.
With document.write, the script is guaranteed to be loaded before the next
script tag is evaluated. There's no guarantee with dynamic injection.
I saw similar not-redrawing bugs when I was playing with the bridge modes.
Specifically - happens sometimes with the PRIVATE_API bridge mode. Not sure
what the cause might be in this case though.
On Mon, May 27, 2013 at 1:52 PM, Joe Bowser <bo...@gmail.com> wrote:
> I think it was made because document.write is ugly. That being said,
> does this break something for WP? Seriously, adding a script tag
> shouldn't cause the browser to not redraw, but I've seen stranger.
>
> On Mon, May 27, 2013 at 10:49 AM, Andrew Grieve <ag...@chromium.org>
> wrote:
> > Might have been this change:
> >
> https://git-wip-us.apache.org/repos/asf?p=cordova-mobile-spec.git;a=blobdiff;f=cordova-incl.js;h=458e10a7155d812d084720f7082c4aa1c63f44c8;hp=c624996236eb2c7501714b48206c0b085460317a;hb=8b1fd7d49c278d43b34b4c041f1575a1a39a664d;hpb=ae18f3ea59d0b53880644ef8f8dcc3d0ade6f76d
> >
> > Maybe let's just revert it? Not sure why it was made in the first place?
> >
> >
> > On Sun, May 26, 2013 at 7:55 PM, Joe Bowser <bo...@gmail.com> wrote:
> >
> >> Hey
> >>
> >> While I was setting up my environment on the Chromebook for JSConf, I
> >> noticed that I ran into the Android 4.0.3 bug again. It seems that
> >> when I was testing 4.0.3 last, I was using an old mobile-spec. After
> >> going through the project, it seems that the changes that were made to
> >> mobile-spec breaks rendering on Android. I have no idea why this
> >> would be, but this browser bug has nothing to do with the Android
> >> changes, and is most likely something to do with the Android ICS
> >> browser being a piece of crap.
> >>
> >> At any rate, can we get this fixed so that we can actually test this
> >> release? What did we do to break mobile-spec on Ice Cream Sandwich?
> >> Anyone have any ideas?
> >>
> >> Joe
> >>
>
Re: Changes in Mobile-Spec are breaking Cordova on Android 4.0.3 ICS
Posted by Joe Bowser <bo...@gmail.com>.
I think it was made because document.write is ugly. That being said,
does this break something for WP? Seriously, adding a script tag
shouldn't cause the browser to not redraw, but I've seen stranger.
On Mon, May 27, 2013 at 10:49 AM, Andrew Grieve <ag...@chromium.org> wrote:
> Might have been this change:
> https://git-wip-us.apache.org/repos/asf?p=cordova-mobile-spec.git;a=blobdiff;f=cordova-incl.js;h=458e10a7155d812d084720f7082c4aa1c63f44c8;hp=c624996236eb2c7501714b48206c0b085460317a;hb=8b1fd7d49c278d43b34b4c041f1575a1a39a664d;hpb=ae18f3ea59d0b53880644ef8f8dcc3d0ade6f76d
>
> Maybe let's just revert it? Not sure why it was made in the first place?
>
>
> On Sun, May 26, 2013 at 7:55 PM, Joe Bowser <bo...@gmail.com> wrote:
>
>> Hey
>>
>> While I was setting up my environment on the Chromebook for JSConf, I
>> noticed that I ran into the Android 4.0.3 bug again. It seems that
>> when I was testing 4.0.3 last, I was using an old mobile-spec. After
>> going through the project, it seems that the changes that were made to
>> mobile-spec breaks rendering on Android. I have no idea why this
>> would be, but this browser bug has nothing to do with the Android
>> changes, and is most likely something to do with the Android ICS
>> browser being a piece of crap.
>>
>> At any rate, can we get this fixed so that we can actually test this
>> release? What did we do to break mobile-spec on Ice Cream Sandwich?
>> Anyone have any ideas?
>>
>> Joe
>>
Re: Changes in Mobile-Spec are breaking Cordova on Android 4.0.3 ICS
Posted by Andrew Grieve <ag...@chromium.org>.
Might have been this change:
https://git-wip-us.apache.org/repos/asf?p=cordova-mobile-spec.git;a=blobdiff;f=cordova-incl.js;h=458e10a7155d812d084720f7082c4aa1c63f44c8;hp=c624996236eb2c7501714b48206c0b085460317a;hb=8b1fd7d49c278d43b34b4c041f1575a1a39a664d;hpb=ae18f3ea59d0b53880644ef8f8dcc3d0ade6f76d
Maybe let's just revert it? Not sure why it was made in the first place?
On Sun, May 26, 2013 at 7:55 PM, Joe Bowser <bo...@gmail.com> wrote:
> Hey
>
> While I was setting up my environment on the Chromebook for JSConf, I
> noticed that I ran into the Android 4.0.3 bug again. It seems that
> when I was testing 4.0.3 last, I was using an old mobile-spec. After
> going through the project, it seems that the changes that were made to
> mobile-spec breaks rendering on Android. I have no idea why this
> would be, but this browser bug has nothing to do with the Android
> changes, and is most likely something to do with the Android ICS
> browser being a piece of crap.
>
> At any rate, can we get this fixed so that we can actually test this
> release? What did we do to break mobile-spec on Ice Cream Sandwich?
> Anyone have any ideas?
>
> Joe
>