You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@flink.apache.org by GitBox <gi...@apache.org> on 2022/03/28 13:21:09 UTC
[GitHub] [flink-kubernetes-operator] mbalassi opened a new pull request #123: [FLINK-26214] Helm chart uses GitHub packages for docker image
mbalassi opened a new pull request #123:
URL: https://github.com/apache/flink-kubernetes-operator/pull/123
Adds the new package to the helm chart and removes the now unnecessary steps from the quickstart.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink-kubernetes-operator] mbalassi closed pull request #123: [FLINK-26214] Helm chart uses GitHub packages for docker image
Posted by GitBox <gi...@apache.org>.
mbalassi closed pull request #123:
URL: https://github.com/apache/flink-kubernetes-operator/pull/123
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink-kubernetes-operator] mbalassi edited a comment on pull request #123: [FLINK-26214] Helm chart uses GitHub packages for docker image
Posted by GitBox <gi...@apache.org>.
mbalassi edited a comment on pull request #123:
URL: https://github.com/apache/flink-kubernetes-operator/pull/123#issuecomment-1081537981
Thanks for the feedback, team. I am closing this as per #126 we are probably taking a better approach to this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink-kubernetes-operator] mbalassi commented on pull request #123: [FLINK-26214] Helm chart uses GitHub packages for docker image
Posted by GitBox <gi...@apache.org>.
mbalassi commented on pull request #123:
URL: https://github.com/apache/flink-kubernetes-operator/pull/123#issuecomment-1081537981
Thanks or the feedback, team. I am closing this as per #126 we are probably taking a better approach to this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink-kubernetes-operator] wangyang0918 commented on a change in pull request #123: [FLINK-26214] Helm chart uses GitHub packages for docker image
Posted by GitBox <gi...@apache.org>.
wangyang0918 commented on a change in pull request #123:
URL: https://github.com/apache/flink-kubernetes-operator/pull/123#discussion_r836998263
##########
File path: helm/flink-operator/values.yaml
##########
@@ -23,9 +23,9 @@
# watchNamespaces: ["flink"]
image:
- repository: flink-operator
+ repository: ghcr.io/apache/flink-operator
pullPolicy: IfNotPresent
- tag: latest
+ tag: main
Review comment:
Given that this is the snapshot docker image of latest main branch, I also think `latest` tag might be better here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink-kubernetes-operator] bgeng777 commented on a change in pull request #123: [FLINK-26214] Helm chart uses GitHub packages for docker image
Posted by GitBox <gi...@apache.org>.
bgeng777 commented on a change in pull request #123:
URL: https://github.com/apache/flink-kubernetes-operator/pull/123#discussion_r836491323
##########
File path: docs/content/docs/try-flink-kubernetes-operator/quick-start.md
##########
@@ -63,22 +63,15 @@ minikube start --kubernetes-version=v1.21.5
We also recommend [k9s](https://k9scli.io/) as GUI for kubernetes, but it is optional for this quickstart guide.
-## Building the operator image from source
+## Get the source code
Review comment:
Should we use `## Getting the source code` to follow our naming pattern of each section?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink-kubernetes-operator] gyfora commented on a change in pull request #123: [FLINK-26214] Helm chart uses GitHub packages for docker image
Posted by GitBox <gi...@apache.org>.
gyfora commented on a change in pull request #123:
URL: https://github.com/apache/flink-kubernetes-operator/pull/123#discussion_r836718957
##########
File path: docs/content/docs/try-flink-kubernetes-operator/quick-start.md
##########
@@ -63,22 +63,15 @@ minikube start --kubernetes-version=v1.21.5
We also recommend [k9s](https://k9scli.io/) as GUI for kubernetes, but it is optional for this quickstart guide.
-## Building the operator image from source
+## Get the source code
+
+You can get the operator source code from GitHub:
```shell
git clone https://github.com/apache/flink-kubernetes-operator.git
cd flink-kubernetes-operator
```
-You can build the docker image of the operator via the following command from the project root folder:
Review comment:
Why would you want to get the source code if you are not going to build the operator?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink-kubernetes-operator] tisonkun commented on a change in pull request #123: [FLINK-26214] Helm chart uses GitHub packages for docker image
Posted by GitBox <gi...@apache.org>.
tisonkun commented on a change in pull request #123:
URL: https://github.com/apache/flink-kubernetes-operator/pull/123#discussion_r836441185
##########
File path: helm/flink-operator/values.yaml
##########
@@ -23,9 +23,9 @@
# watchNamespaces: ["flink"]
image:
- repository: flink-operator
+ repository: ghcr.io/apache/flink-operator
pullPolicy: IfNotPresent
- tag: latest
+ tag: main
Review comment:
I may prefer use latest in the CD workflow which is the default manner in the Docker world. Could you explain a bit why do we use `main` instead of `latest` in the CD workflow? IIRC `docker pull <image>` is default to `latest`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink-kubernetes-operator] wangyang0918 commented on pull request #123: [FLINK-26214] Helm chart uses GitHub packages for docker image
Posted by GitBox <gi...@apache.org>.
wangyang0918 commented on pull request #123:
URL: https://github.com/apache/flink-kubernetes-operator/pull/123#issuecomment-1081357274
Out the scope of this PR, I am thinking how we could install the flink-kubernetes-operator like airflow. Then we do not force the users to download the source code.
```
helm repo add apache-airflow https://airflow.apache.org
helm upgrade --install airflow apache-airflow/airflow --namespace airflow --create-namespace
```
https://airflow.apache.org/docs/helm-chart/stable/index.html
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org