You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Evelina Dumitrescu <ev...@gmail.com> on 2014/12/01 05:29:03 UTC
Review Request 28543: stout: Replaced obsolete functions
gethostbyname2_r
and gethostbyname2 with getaddrinfo and introduced getIP
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28543/
-----------------------------------------------------------
Review request for mesos, Dominic Hamon and Joris Van Remoortere.
Repository: mesos-git
Description
-------
gethostbyname2_r and gethostbyname2 are obsolete functions and should be replaced.
geIP retrieves a IP address from a given hostname.
Diffs
-----
3rdparty/libprocess/3rdparty/stout/include/stout/net.hpp a992bd9f7caf3abcc2c5e14519ca7e3ac045bb4b
3rdparty/libprocess/3rdparty/stout/include/stout/os.hpp ec259cdee876c64f3e562aa77d4d52e964a173ab
Diff: https://reviews.apache.org/r/28543/diff/
Testing
-------
make check
Thanks,
Evelina Dumitrescu
Re: Review Request 28543: stout: Replaced obsolete functions
gethostbyname2_r and gethostbyname2 with getaddrinfo and introduced getIP
Posted by Evelina Dumitrescu <ev...@gmail.com>.
> On Dec. 1, 2014, 5:44 p.m., Dominic Hamon wrote:
> > 3rdparty/libprocess/3rdparty/stout/include/stout/net.hpp, line 138
> > <https://reviews.apache.org/r/28543/diff/1/?file=778739#file778739line138>
> >
> > const std::string&
done
- Evelina
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28543/#review63385
-----------------------------------------------------------
On Dec. 2, 2014, 2:07 a.m., Evelina Dumitrescu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28543/
> -----------------------------------------------------------
>
> (Updated Dec. 2, 2014, 2:07 a.m.)
>
>
> Review request for mesos, Dominic Hamon and Joris Van Remoortere.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> gethostbyname2_r and gethostbyname2 are obsolete functions and should be replaced.
> geIP retrieves a IP address from a given hostname.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/3rdparty/stout/include/stout/net.hpp a992bd9f7caf3abcc2c5e14519ca7e3ac045bb4b
> 3rdparty/libprocess/3rdparty/stout/include/stout/os.hpp ec259cdee876c64f3e562aa77d4d52e964a173ab
>
> Diff: https://reviews.apache.org/r/28543/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Evelina Dumitrescu
>
>
Re: Review Request 28543: stout: Replaced obsolete functions
gethostbyname2_r and gethostbyname2 with getaddrinfo and introduced getIP
Posted by Evelina Dumitrescu <ev...@gmail.com>.
> On Dec. 1, 2014, 5:44 p.m., Dominic Hamon wrote:
> > 3rdparty/libprocess/3rdparty/stout/include/stout/os.hpp, line 884
> > <https://reviews.apache.org/r/28543/diff/1/?file=778740#file778740line884>
> >
> > this could be a wrapper in net?
Do you mean a wrapper for initializing a struct addrinfo?
- Evelina
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28543/#review63385
-----------------------------------------------------------
On Dec. 1, 2014, 5:23 a.m., Evelina Dumitrescu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28543/
> -----------------------------------------------------------
>
> (Updated Dec. 1, 2014, 5:23 a.m.)
>
>
> Review request for mesos, Dominic Hamon and Joris Van Remoortere.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> gethostbyname2_r and gethostbyname2 are obsolete functions and should be replaced.
> geIP retrieves a IP address from a given hostname.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/3rdparty/stout/include/stout/net.hpp a992bd9f7caf3abcc2c5e14519ca7e3ac045bb4b
> 3rdparty/libprocess/3rdparty/stout/include/stout/os.hpp ec259cdee876c64f3e562aa77d4d52e964a173ab
>
> Diff: https://reviews.apache.org/r/28543/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Evelina Dumitrescu
>
>
Re: Review Request 28543: stout: Replaced obsolete functions
gethostbyname2_r and gethostbyname2 with getaddrinfo and introduced getIP
Posted by Evelina Dumitrescu <ev...@gmail.com>.
> On Dec. 1, 2014, 5:44 p.m., Dominic Hamon wrote:
> > 3rdparty/libprocess/3rdparty/stout/include/stout/net.hpp, line 141
> > <https://reviews.apache.org/r/28543/diff/1/?file=778739#file778739line141>
> >
> > i assume you have a plan for extending this to ipv6?
I'll add a parameter for the family type.
- Evelina
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28543/#review63385
-----------------------------------------------------------
On Dec. 1, 2014, 5:23 a.m., Evelina Dumitrescu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28543/
> -----------------------------------------------------------
>
> (Updated Dec. 1, 2014, 5:23 a.m.)
>
>
> Review request for mesos, Dominic Hamon and Joris Van Remoortere.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> gethostbyname2_r and gethostbyname2 are obsolete functions and should be replaced.
> geIP retrieves a IP address from a given hostname.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/3rdparty/stout/include/stout/net.hpp a992bd9f7caf3abcc2c5e14519ca7e3ac045bb4b
> 3rdparty/libprocess/3rdparty/stout/include/stout/os.hpp ec259cdee876c64f3e562aa77d4d52e964a173ab
>
> Diff: https://reviews.apache.org/r/28543/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Evelina Dumitrescu
>
>
Re: Review Request 28543: stout: Replaced obsolete functions
gethostbyname2_r and gethostbyname2 with getaddrinfo and introduced getIP
Posted by Dominic Hamon <dh...@twopensource.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28543/#review63385
-----------------------------------------------------------
3rdparty/libprocess/3rdparty/stout/include/stout/net.hpp
<https://reviews.apache.org/r/28543/#comment105637>
const std::string&
3rdparty/libprocess/3rdparty/stout/include/stout/net.hpp
<https://reviews.apache.org/r/28543/#comment105638>
i assume you have a plan for extending this to ipv6?
3rdparty/libprocess/3rdparty/stout/include/stout/os.hpp
<https://reviews.apache.org/r/28543/#comment105639>
this could be a wrapper in net?
- Dominic Hamon
On Nov. 30, 2014, 9:23 p.m., Evelina Dumitrescu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28543/
> -----------------------------------------------------------
>
> (Updated Nov. 30, 2014, 9:23 p.m.)
>
>
> Review request for mesos, Dominic Hamon and Joris Van Remoortere.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> gethostbyname2_r and gethostbyname2 are obsolete functions and should be replaced.
> geIP retrieves a IP address from a given hostname.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/3rdparty/stout/include/stout/net.hpp a992bd9f7caf3abcc2c5e14519ca7e3ac045bb4b
> 3rdparty/libprocess/3rdparty/stout/include/stout/os.hpp ec259cdee876c64f3e562aa77d4d52e964a173ab
>
> Diff: https://reviews.apache.org/r/28543/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Evelina Dumitrescu
>
>
Re: Review Request 28543: stout: Replaced obsolete functions
gethostbyname2_r and gethostbyname2 with getaddrinfo and introduced getIP
Posted by Evelina Dumitrescu <ev...@gmail.com>.
> On Dec. 2, 2014, 6 p.m., Dominic Hamon wrote:
> > 3rdparty/libprocess/3rdparty/stout/include/stout/os.hpp, line 868
> > <https://reviews.apache.org/r/28543/diff/2/?file=779878#file779878line868>
> >
> > why isn't this calling getIP() ?
Here it returns the ai_cannonname, not the ai_addr field.
- Evelina
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28543/#review63553
-----------------------------------------------------------
On Dec. 2, 2014, 2:07 a.m., Evelina Dumitrescu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28543/
> -----------------------------------------------------------
>
> (Updated Dec. 2, 2014, 2:07 a.m.)
>
>
> Review request for mesos, Dominic Hamon and Joris Van Remoortere.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> gethostbyname2_r and gethostbyname2 are obsolete functions and should be replaced.
> geIP retrieves a IP address from a given hostname.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/3rdparty/stout/include/stout/net.hpp a992bd9f7caf3abcc2c5e14519ca7e3ac045bb4b
> 3rdparty/libprocess/3rdparty/stout/include/stout/os.hpp ec259cdee876c64f3e562aa77d4d52e964a173ab
>
> Diff: https://reviews.apache.org/r/28543/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Evelina Dumitrescu
>
>
Re: Review Request 28543: stout: Replaced obsolete functions
gethostbyname2_r and gethostbyname2 with getaddrinfo and introduced getIP
Posted by Dominic Hamon <dh...@twopensource.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28543/#review63553
-----------------------------------------------------------
3rdparty/libprocess/3rdparty/stout/include/stout/os.hpp
<https://reviews.apache.org/r/28543/#comment105818>
why isn't this calling getIP() ?
- Dominic Hamon
On Dec. 1, 2014, 6:07 p.m., Evelina Dumitrescu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28543/
> -----------------------------------------------------------
>
> (Updated Dec. 1, 2014, 6:07 p.m.)
>
>
> Review request for mesos, Dominic Hamon and Joris Van Remoortere.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> gethostbyname2_r and gethostbyname2 are obsolete functions and should be replaced.
> geIP retrieves a IP address from a given hostname.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/3rdparty/stout/include/stout/net.hpp a992bd9f7caf3abcc2c5e14519ca7e3ac045bb4b
> 3rdparty/libprocess/3rdparty/stout/include/stout/os.hpp ec259cdee876c64f3e562aa77d4d52e964a173ab
>
> Diff: https://reviews.apache.org/r/28543/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Evelina Dumitrescu
>
>
Re: Review Request 28543: stout: Replaced obsolete functions
gethostbyname2_r and gethostbyname2 with getaddrinfo and introduced getIP
Posted by Evelina Dumitrescu <ev...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28543/
-----------------------------------------------------------
(Updated Dec. 2, 2014, 2:07 a.m.)
Review request for mesos, Dominic Hamon and Joris Van Remoortere.
Repository: mesos-git
Description
-------
gethostbyname2_r and gethostbyname2 are obsolete functions and should be replaced.
geIP retrieves a IP address from a given hostname.
Diffs (updated)
-----
3rdparty/libprocess/3rdparty/stout/include/stout/net.hpp a992bd9f7caf3abcc2c5e14519ca7e3ac045bb4b
3rdparty/libprocess/3rdparty/stout/include/stout/os.hpp ec259cdee876c64f3e562aa77d4d52e964a173ab
Diff: https://reviews.apache.org/r/28543/diff/
Testing
-------
make check
Thanks,
Evelina Dumitrescu
Re: Review Request 28543: stout: Replaced obsolete functions
gethostbyname2_r and gethostbyname2 with getaddrinfo and introduced getIP
Posted by Evelina Dumitrescu <ev...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28543/
-----------------------------------------------------------
(Updated Dec. 1, 2014, 5:23 a.m.)
Review request for mesos, Dominic Hamon and Joris Van Remoortere.
Repository: mesos-git
Description
-------
gethostbyname2_r and gethostbyname2 are obsolete functions and should be replaced.
geIP retrieves a IP address from a given hostname.
Diffs
-----
3rdparty/libprocess/3rdparty/stout/include/stout/net.hpp a992bd9f7caf3abcc2c5e14519ca7e3ac045bb4b
3rdparty/libprocess/3rdparty/stout/include/stout/os.hpp ec259cdee876c64f3e562aa77d4d52e964a173ab
Diff: https://reviews.apache.org/r/28543/diff/
Testing
-------
make check
Thanks,
Evelina Dumitrescu