You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2020/11/10 12:52:08 UTC
[GitHub] [spark] cloud-fan opened a new pull request #30318: [SPARK-33412][SQL] update OverwriteByExpression.deleteExpr after resolving v2 write commands
cloud-fan opened a new pull request #30318:
URL: https://github.com/apache/spark/pull/30318
<!--
Thanks for sending a pull request! Here are some tips for you:
1. If this is your first time, please read our contributor guidelines: https://spark.apache.org/contributing.html
2. Ensure you have added or run the appropriate tests for your PR: https://spark.apache.org/developer-tools.html
3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP][SPARK-XXXX] Your PR title ...'.
4. Be sure to keep the PR description updated to reflect all changes.
5. Please write your PR title to summarize what this PR proposes.
6. If possible, provide a concise example to reproduce the issue for a faster review.
7. If you want to add a new configuration, please read the guideline first for naming configurations in
'core/src/main/scala/org/apache/spark/internal/config/ConfigEntry.scala'.
-->
### What changes were proposed in this pull request?
<!--
Please clarify what changes you are proposing. The purpose of this section is to outline the changes and how this PR fixes the issue.
If possible, please consider writing useful notes for better and faster reviews in your PR. See the examples below.
1. If you refactor some codes with changing classes, showing the class hierarchy will help reviewers.
2. If you fix some SQL features, you can provide some references of other DBMSes.
3. If there is design documentation, please add the link.
4. If there is a discussion in the mailing list, please add the link.
-->
In the rule `ResolveOutputRelation`, update the attributes in v2 command's expressions, in case we add cast and change the expr id of input query's output.
### Why are the changes needed?
<!--
Please clarify why the changes are needed. For instance,
1. If you propose a new API, clarify the use case for a new API.
2. If you fix a bug, you can clarify why it is a bug.
-->
Previously we have a hack in the rule `ResolveReferences`, to skip resolving the delete condition of `OverwriteByExpression` until its `outputResolved` returns true. This is because, we may add cast to the input query and change its output expr ID, so we want to delay the resolving of the delete condition expression.
However, this doesn't always work, as users can use `DataFrameWriterV2` API to put a resolved attribute in the delete condition. So a more robust solution is to update the attribute in delete condition expression after we change input query's output expr ID.
### Does this PR introduce _any_ user-facing change?
<!--
Note that it means *any* user-facing change including all aspects such as the documentation fix.
If yes, please clarify the previous behavior and the change this PR proposes - provide the console output, description and/or an example to show the behavior difference if possible.
If possible, please also clarify if this is a user-facing change compared to the released Spark versions or within the unreleased branches such as master.
If no, write 'No'.
-->
Yes, fix a corner case.
### How was this patch tested?
<!--
If tests were added, say they were added here. Please make sure to add some test cases that check the changes thoroughly including negative and positive cases if possible.
If it was tested in a way different from regular unit tests, please clarify how you tested step by step, ideally copy and paste-able, so that other reviewers can test and check, and descendants can verify in the future.
If tests were not added, please describe why they were not added and/or why it was difficult to add.
-->
a new test case
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #30318: [SPARK-33412][SQL] update OverwriteByExpression.deleteExpr after resolving v2 write commands
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30318:
URL: https://github.com/apache/spark/pull/30318#issuecomment-724684268
**[Test build #130869 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/130869/testReport)** for PR 30318 at commit [`1ca8062`](https://github.com/apache/spark/commit/1ca8062b62eb6ea642f70053ee7954ed1ad3dd93).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon closed pull request #30318: [SPARK-33412][SQL] OverwriteByExpression should resolve its delete condition based on the table relation not the input query
Posted by GitBox <gi...@apache.org>.
HyukjinKwon closed pull request #30318:
URL: https://github.com/apache/spark/pull/30318
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on pull request #30318: [SPARK-33412][SQL] OverwriteByExpression should resolve its delete condition based on the table relation not the input query
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on pull request #30318:
URL: https://github.com/apache/spark/pull/30318#issuecomment-725273503
PR for 3.0: https://github.com/apache/spark/pull/30328
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #30318: [SPARK-33412][SQL] update OverwriteByExpression.deleteExpr after resolving v2 write commands
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30318:
URL: https://github.com/apache/spark/pull/30318#issuecomment-724728442
Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/35476/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #30318: [SPARK-33412][SQL] OverwriteByExpression should resolve its delete condition based on the table relation not the input query
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30318:
URL: https://github.com/apache/spark/pull/30318#issuecomment-725202187
**[Test build #130904 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/130904/testReport)** for PR 30318 at commit [`f092c58`](https://github.com/apache/spark/commit/f092c5889e38be4b707b9ecf5a135bcf4f333be6).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #30318: [SPARK-33412][SQL] OverwriteByExpression should resolve its delete condition based on the table relation not the input query
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #30318:
URL: https://github.com/apache/spark/pull/30318#issuecomment-725271680
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #30318: [SPARK-33412][SQL] OverwriteByExpression should resolve its delete condition based on the table relation not the input query
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30318:
URL: https://github.com/apache/spark/pull/30318#issuecomment-724879558
Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/35490/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #30318: [SPARK-33412][SQL] OverwriteByExpression should resolve its delete condition based on the table relation not the input query
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #30318:
URL: https://github.com/apache/spark/pull/30318#issuecomment-724979845
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #30318: [SPARK-33412][SQL] update OverwriteByExpression.deleteExpr after resolving v2 write commands
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #30318:
URL: https://github.com/apache/spark/pull/30318#issuecomment-724728476
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #30318: [SPARK-33412][SQL] OverwriteByExpression should resolve its delete condition based on the table relation not the input query
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #30318:
URL: https://github.com/apache/spark/pull/30318#issuecomment-724879580
Merged build finished. Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #30318: [SPARK-33412][SQL] OverwriteByExpression should resolve its delete condition based on the table relation not the input query
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30318:
URL: https://github.com/apache/spark/pull/30318#issuecomment-724838323
**[Test build #130885 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/130885/testReport)** for PR 30318 at commit [`b174196`](https://github.com/apache/spark/commit/b174196138d039a4c7b47c595d147f9e6774ace0).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #30318: [SPARK-33412][SQL] OverwriteByExpression should resolve its delete condition based on the table relation not the input query
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30318:
URL: https://github.com/apache/spark/pull/30318#issuecomment-725218357
Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/35510/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #30318: [SPARK-33412][SQL] OverwriteByExpression should resolve its delete condition based on the table relation not the input query
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30318:
URL: https://github.com/apache/spark/pull/30318#issuecomment-725226468
Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/35510/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan edited a comment on pull request #30318: [SPARK-33412][SQL] OverwriteByExpression should resolve its delete condition based on the table relation not the input query
Posted by GitBox <gi...@apache.org>.
cloud-fan edited a comment on pull request #30318:
URL: https://github.com/apache/spark/pull/30318#issuecomment-724684600
cc @brkyvz @LantaoJin @rdblue @dongjoon-hyun @imback82 @HeartSaVioR
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #30318: [SPARK-33412][SQL] OverwriteByExpression should resolve its delete condition based on the table relation not the input query
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #30318:
URL: https://github.com/apache/spark/pull/30318#issuecomment-724879580
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #30318: [SPARK-33412][SQL] OverwriteByExpression should resolve its delete condition based on the table relation not the input query
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #30318:
URL: https://github.com/apache/spark/pull/30318#issuecomment-725271680
Merged build finished. Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #30318: [SPARK-33412][SQL] update OverwriteByExpression.deleteExpr after resolving v2 write commands
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #30318:
URL: https://github.com/apache/spark/pull/30318#issuecomment-724810334
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #30318: [SPARK-33412][SQL] OverwriteByExpression should resolve its delete condition based on the table relation not the input query
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #30318:
URL: https://github.com/apache/spark/pull/30318#issuecomment-725226485
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on pull request #30318: [SPARK-33412][SQL] OverwriteByExpression should resolve its delete condition based on the table relation not the input query
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on pull request #30318:
URL: https://github.com/apache/spark/pull/30318#issuecomment-725250995
Merged to master. It has conflict with branch-3.0. @cloud-fan mind opening a PR for branch-3.0?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #30318: [SPARK-33412][SQL] update OverwriteByExpression.deleteExpr after resolving v2 write commands
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #30318:
URL: https://github.com/apache/spark/pull/30318#issuecomment-724684268
**[Test build #130869 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/130869/testReport)** for PR 30318 at commit [`1ca8062`](https://github.com/apache/spark/commit/1ca8062b62eb6ea642f70053ee7954ed1ad3dd93).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #30318: [SPARK-33412][SQL] OverwriteByExpression should resolve its delete condition based on the table relation not the input query
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #30318:
URL: https://github.com/apache/spark/pull/30318#issuecomment-724879598
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/35490/
Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #30318: [SPARK-33412][SQL] OverwriteByExpression should resolve its delete condition based on the table relation not the input query
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #30318:
URL: https://github.com/apache/spark/pull/30318#issuecomment-725202187
**[Test build #130904 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/130904/testReport)** for PR 30318 at commit [`f092c58`](https://github.com/apache/spark/commit/f092c5889e38be4b707b9ecf5a135bcf4f333be6).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #30318: [SPARK-33412][SQL] update OverwriteByExpression.deleteExpr after resolving v2 write commands
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #30318:
URL: https://github.com/apache/spark/pull/30318#issuecomment-724728476
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #30318: [SPARK-33412][SQL] update OverwriteByExpression.deleteExpr after resolving v2 write commands
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30318:
URL: https://github.com/apache/spark/pull/30318#issuecomment-724710348
Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/35476/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #30318: [SPARK-33412][SQL] OverwriteByExpression should resolve its delete condition based on the table relation not the input query
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #30318:
URL: https://github.com/apache/spark/pull/30318#issuecomment-725271687
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/130904/
Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #30318: [SPARK-33412][SQL] OverwriteByExpression should resolve its delete condition based on the table relation not the input query
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #30318:
URL: https://github.com/apache/spark/pull/30318#issuecomment-725226485
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on pull request #30318: [SPARK-33412][SQL] update OverwriteByExpression.deleteExpr after resolving v2 write commands
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on pull request #30318:
URL: https://github.com/apache/spark/pull/30318#issuecomment-724684600
cc @rdblue @dongjoon-hyun @imback82 @HeartSaVioR
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #30318: [SPARK-33412][SQL] OverwriteByExpression should resolve its delete condition based on the table relation not the input query
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30318:
URL: https://github.com/apache/spark/pull/30318#issuecomment-724867104
Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/35490/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #30318: [SPARK-33412][SQL] OverwriteByExpression should resolve its delete condition based on the table relation not the input query
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #30318:
URL: https://github.com/apache/spark/pull/30318#issuecomment-724979845
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #30318: [SPARK-33412][SQL] update OverwriteByExpression.deleteExpr after resolving v2 write commands
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30318:
URL: https://github.com/apache/spark/pull/30318#issuecomment-724809789
**[Test build #130869 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/130869/testReport)** for PR 30318 at commit [`1ca8062`](https://github.com/apache/spark/commit/1ca8062b62eb6ea642f70053ee7954ed1ad3dd93).
* This patch **fails Spark unit tests**.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #30318: [SPARK-33412][SQL] OverwriteByExpression should resolve its delete condition based on the table relation not the input query
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30318:
URL: https://github.com/apache/spark/pull/30318#issuecomment-724978804
**[Test build #130885 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/130885/testReport)** for PR 30318 at commit [`b174196`](https://github.com/apache/spark/commit/b174196138d039a4c7b47c595d147f9e6774ace0).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #30318: [SPARK-33412][SQL] OverwriteByExpression should resolve its delete condition based on the table relation not the input query
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #30318:
URL: https://github.com/apache/spark/pull/30318#issuecomment-724838323
**[Test build #130885 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/130885/testReport)** for PR 30318 at commit [`b174196`](https://github.com/apache/spark/commit/b174196138d039a4c7b47c595d147f9e6774ace0).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #30318: [SPARK-33412][SQL] OverwriteByExpression should resolve its delete condition based on the table relation not the input query
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30318:
URL: https://github.com/apache/spark/pull/30318#issuecomment-725271309
**[Test build #130904 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/130904/testReport)** for PR 30318 at commit [`f092c58`](https://github.com/apache/spark/commit/f092c5889e38be4b707b9ecf5a135bcf4f333be6).
* This patch **fails due to an unknown error code, -9**.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #30318: [SPARK-33412][SQL] update OverwriteByExpression.deleteExpr after resolving v2 write commands
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #30318:
URL: https://github.com/apache/spark/pull/30318#issuecomment-724810342
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/130869/
Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #30318: [SPARK-33412][SQL] update OverwriteByExpression.deleteExpr after resolving v2 write commands
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #30318:
URL: https://github.com/apache/spark/pull/30318#issuecomment-724810334
Merged build finished. Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan edited a comment on pull request #30318: [SPARK-33412][SQL] OverwriteByExpression should resolve its delete condition based on the table relation not the input query
Posted by GitBox <gi...@apache.org>.
cloud-fan edited a comment on pull request #30318:
URL: https://github.com/apache/spark/pull/30318#issuecomment-724684600
cc @brkyvz @LantaoJin @rdblue @dongjoon-hyun
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org