You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@dubbo.apache.org by "Jeff-Lv (GitHub)" <gi...@apache.org> on 2018/12/14 11:36:20 UTC
[GitHub] [incubator-dubbo] Jeff-Lv opened pull request #2966: Add a
Constants value and util method to getIDByName
## What is the purpose of the change
Support the feature of alibaba inside's HSF which remoting protocol will be opensources to Dubbo.
## Brief changelog
add a constants value
a new method for CodeSupporet
[ Full content available at: https://github.com/apache/incubator-dubbo/pull/2966 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org
[GitHub] [incubator-dubbo] codecov-io commented on issue #2966: Add a
Constants value and util method to getIDByName
Posted by "codecov-io (GitHub)" <gi...@apache.org>.
# [Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/2966?src=pr&el=h1) Report
> Merging [#2966](https://codecov.io/gh/apache/incubator-dubbo/pull/2966?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-dubbo/commit/f5be817c0077c85c0d9ecc0026d0fd396684a03a?src=pr&el=desc) will **decrease** coverage by `0.1%`.
> The diff coverage is `66.66%`.
[](https://codecov.io/gh/apache/incubator-dubbo/pull/2966?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #2966 +/- ##
============================================
- Coverage 63.99% 63.89% -0.11%
- Complexity 0 75 +75
============================================
Files 584 653 +69
Lines 26045 28226 +2181
Branches 4561 4779 +218
============================================
+ Hits 16667 18034 +1367
- Misses 7202 8001 +799
- Partials 2176 2191 +15
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-dubbo/pull/2966?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...c/main/java/org/apache/dubbo/common/Constants.java](https://codecov.io/gh/apache/incubator-dubbo/pull/2966/diff?src=pr&el=tree#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb21tb24vQ29uc3RhbnRzLmphdmE=) | `92.85% <ø> (+3.96%)` | `0 <0> (ø)` | :arrow_down: |
| [.../apache/dubbo/remoting/transport/CodecSupport.java](https://codecov.io/gh/apache/incubator-dubbo/pull/2966/diff?src=pr&el=tree#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctYXBpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9yZW1vdGluZy90cmFuc3BvcnQvQ29kZWNTdXBwb3J0LmphdmE=) | `79.31% <66.66%> (-1.46%)` | `0 <0> (ø)` | |
| [...apache/dubbo/rpc/cluster/router/tag/TagRouter.java](https://codecov.io/gh/apache/incubator-dubbo/pull/2966/diff?src=pr&el=tree#diff-ZHViYm8tY2x1c3Rlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vcnBjL2NsdXN0ZXIvcm91dGVyL3RhZy9UYWdSb3V0ZXIuamF2YQ==) | `34.72% <0%> (-33.14%)` | `0% <0%> (ø)` | |
| [...org/apache/dubbo/rpc/service/GenericException.java](https://codecov.io/gh/apache/incubator-dubbo/pull/2966/diff?src=pr&el=tree#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9zZXJ2aWNlL0dlbmVyaWNFeGNlcHRpb24uamF2YQ==) | `50% <0%> (-25%)` | `0% <0%> (ø)` | |
| [...bo/rpc/cluster/support/FailbackClusterInvoker.java](https://codecov.io/gh/apache/incubator-dubbo/pull/2966/diff?src=pr&el=tree#diff-ZHViYm8tY2x1c3Rlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vcnBjL2NsdXN0ZXIvc3VwcG9ydC9GYWlsYmFja0NsdXN0ZXJJbnZva2VyLmphdmE=) | `67.21% <0%> (-19.28%)` | `0% <0%> (ø)` | |
| [...dubbo/registry/support/ProviderInvokerWrapper.java](https://codecov.io/gh/apache/incubator-dubbo/pull/2966/diff?src=pr&el=tree#diff-ZHViYm8tcmVnaXN0cnkvZHViYm8tcmVnaXN0cnktYXBpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9yZWdpc3RyeS9zdXBwb3J0L1Byb3ZpZGVySW52b2tlcldyYXBwZXIuamF2YQ==) | `47.82% <0%> (-15.34%)` | `0% <0%> (ø)` | |
| [...o/rpc/protocol/dubbo/telnet/ListTelnetHandler.java](https://codecov.io/gh/apache/incubator-dubbo/pull/2966/diff?src=pr&el=tree#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy1kdWJiby9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vcnBjL3Byb3RvY29sL2R1YmJvL3RlbG5ldC9MaXN0VGVsbmV0SGFuZGxlci5qYXZh) | `65.78% <0%> (-13.76%)` | `0% <0%> (ø)` | |
| [...ache/dubbo/remoting/transport/AbstractChannel.java](https://codecov.io/gh/apache/incubator-dubbo/pull/2966/diff?src=pr&el=tree#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctYXBpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9yZW1vdGluZy90cmFuc3BvcnQvQWJzdHJhY3RDaGFubmVsLmphdmE=) | `75% <0%> (-12.5%)` | `0% <0%> (ø)` | |
| [...ava/org/apache/dubbo/common/utils/ClassHelper.java](https://codecov.io/gh/apache/incubator-dubbo/pull/2966/diff?src=pr&el=tree#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb21tb24vdXRpbHMvQ2xhc3NIZWxwZXIuamF2YQ==) | `63.8% <0%> (-12.25%)` | `0% <0%> (ø)` | |
| [.../remoting/transport/netty4/NettyClientHandler.java](https://codecov.io/gh/apache/incubator-dubbo/pull/2966/diff?src=pr&el=tree#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctbmV0dHk0L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9yZW1vdGluZy90cmFuc3BvcnQvbmV0dHk0L05ldHR5Q2xpZW50SGFuZGxlci5qYXZh) | `75% <0%> (-11.12%)` | `0% <0%> (ø)` | |
| ... and [254 more](https://codecov.io/gh/apache/incubator-dubbo/pull/2966/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/2966?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/2966?src=pr&el=footer). Last update [f5be817...1fdb434](https://codecov.io/gh/apache/incubator-dubbo/pull/2966?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
[ Full content available at: https://github.com/apache/incubator-dubbo/pull/2966 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org
[GitHub] [incubator-dubbo] beiwei30 closed pull request #2966: Add a
Constants value and util method to getIDByName
Posted by "beiwei30 (GitHub)" <gi...@apache.org>.
[ pull request closed by beiwei30 ]
[ Full content available at: https://github.com/apache/incubator-dubbo/pull/2966 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org
[GitHub] [incubator-dubbo] beiwei30 commented on pull request #2966:
Add a Constants value and util method to getIDByName
Posted by "beiwei30 (GitHub)" <gi...@apache.org>.
why should we introduce this?
[ Full content available at: https://github.com/apache/incubator-dubbo/pull/2966 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org
[GitHub] [incubator-dubbo] beiwei30 commented on issue #2966: Add a
Constants value and util method to getIDByName
Posted by "beiwei30 (GitHub)" <gi...@apache.org>.
this pull request not valid any longer, has talked to the author.
[ Full content available at: https://github.com/apache/incubator-dubbo/pull/2966 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org
[GitHub] [incubator-dubbo] beiwei30 commented on pull request #2966:
Add a Constants value and util method to getIDByName
Posted by "beiwei30 (GitHub)" <gi...@apache.org>.
**SERIALIZATIONNAME_ID_MAP** is better, in my opinion.
[ Full content available at: https://github.com/apache/incubator-dubbo/pull/2966 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org
[GitHub] [incubator-dubbo] Jeff-Lv commented on pull request #2966:
Add a Constants value and util method to getIDByName
Posted by "Jeff-Lv (GitHub)" <gi...@apache.org>.
good advice.
[ Full content available at: https://github.com/apache/incubator-dubbo/pull/2966 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org