You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2021/01/14 10:47:30 UTC

[GitHub] [flink] chaozwn opened a new pull request #14645: [FLINK-20967][docs] HBase properties 'properties.*' function Description

chaozwn opened a new pull request #14645:
URL: https://github.com/apache/flink/pull/14645


   <!--
   *Thank you very much for contributing to Apache Flink - we are happy that you want to help us improve Flink. To help the community review your contribution in the best possible way, please go through the checklist below, which will get the contribution into a shape in which it can be best reviewed.*
   
   *Please understand that we do not do this to make contributions to Flink a hassle. In order to uphold a high standard of quality for code contributions, while at the same time managing a large number of contributions, we need contributors to prepare the contributions well, and give reviewers enough contextual information for the review. Please also understand that contributions that do not follow this guide will take longer to review and thus typically be picked up with lower priority by the community.*
   
   ## Contribution Checklist
   
     - Make sure that the pull request corresponds to a [JIRA issue](https://issues.apache.org/jira/projects/FLINK/issues). Exceptions are made for typos in JavaDoc or documentation files, which need no JIRA issue.
     
     - Name the pull request in the form "[FLINK-XXXX] [component] Title of the pull request", where *FLINK-XXXX* should be replaced by the actual issue number. Skip *component* if you are unsure about which is the best component.
     Typo fixes that have no associated JIRA issue should be named following this pattern: `[hotfix] [docs] Fix typo in event time introduction` or `[hotfix] [javadocs] Expand JavaDoc for PuncuatedWatermarkGenerator`.
   
     - Fill out the template below to describe the changes contributed by the pull request. That will give reviewers the context they need to do the review.
     
     - Make sure that the change passes the automated tests, i.e., `mvn clean verify` passes. You can set up Azure Pipelines CI to do that following [this guide](https://cwiki.apache.org/confluence/display/FLINK/Azure+Pipelines#AzurePipelines-Tutorial:SettingupAzurePipelinesforaforkoftheFlinkrepository).
   
     - Each pull request should address only one issue, not mix up code from multiple issues.
     
     - Each commit in the pull request has a meaningful commit message (including the JIRA id)
   
     - Once all items of the checklist are addressed, remove the above text and this checklist, leaving only the filled out template below.
   
   
   **(The sections below can be removed for hotfixes of typos)**
   -->
   
   ## What is the purpose of the change
   
   add change doc.
   
   
   ## Brief change log
   
   
   ## Verifying this change
   
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): no
     - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: no
     - The serializers: no
     - The runtime per-record code paths (performance sensitive): no
     - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: no
     - The S3 file system connector: no
   
   ## Documentation
   
     - Does this pull request introduce a new feature? (yes / no)
     - If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #14645: [FLINK-20967][docs] HBase properties 'properties.*' function Description

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14645:
URL: https://github.com/apache/flink/pull/14645#issuecomment-760128893


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "c58e00c4a12a5eb33daa61822172c1366093a4ff",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12047",
       "triggerID" : "c58e00c4a12a5eb33daa61822172c1366093a4ff",
       "triggerType" : "PUSH"
     }, {
       "hash" : "377185e7ca78d74e7e95479f97c27e20b215dce4",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "377185e7ca78d74e7e95479f97c27e20b215dce4",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * c58e00c4a12a5eb33daa61822172c1366093a4ff Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12047) 
   * 377185e7ca78d74e7e95479f97c27e20b215dce4 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] wuchong commented on pull request #14645: [FLINK-20967][docs] HBase properties 'properties.*' function Description

Posted by GitBox <gi...@apache.org>.
wuchong commented on pull request #14645:
URL: https://github.com/apache/flink/pull/14645#issuecomment-760171481


   Thanks for the explanation and working on this. 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] chaozwn commented on pull request #14645: [FLINK-20967][docs] HBase properties 'properties.*' function Description

Posted by GitBox <gi...@apache.org>.
chaozwn commented on pull request #14645:
URL: https://github.com/apache/flink/pull/14645#issuecomment-760167669


   > Why adding new pages instead of updating the existing one? `docs/dev/table/connectors/hbase.md`
   
   sorry,because the first pr I submitted was not copied from the master branch, and the previous commit was mixed, I copied the two changed files and resubmitted a new pr. It doesn't matter, the two documents are actually the same. I will revise it tomorrow.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #14645: [FLINK-20967][docs] HBase properties 'properties.*' function Description

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14645:
URL: https://github.com/apache/flink/pull/14645#issuecomment-760128893


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "c58e00c4a12a5eb33daa61822172c1366093a4ff",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12047",
       "triggerID" : "c58e00c4a12a5eb33daa61822172c1366093a4ff",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * c58e00c4a12a5eb33daa61822172c1366093a4ff Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12047) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] wuchong commented on a change in pull request #14645: [FLINK-20967][docs] HBase properties 'properties.*' function Description

Posted by GitBox <gi...@apache.org>.
wuchong commented on a change in pull request #14645:
URL: https://github.com/apache/flink/pull/14645#discussion_r557913884



##########
File path: docs/dev/table/connectors/hbase.md
##########
@@ -172,6 +172,15 @@ Connector Options
       <td>Integer</td>
       <td>Defines the parallelism of the HBase sink operator. By default, the parallelism is determined by the framework using the same parallelism of the upstream chained operator.</td>
     </tr>
+    <tr>
+      <td><h5>properties.*</h5></td>
+      <td>optional</td>
+      <td style="word-wrap: break-word;">(none)</td>
+      <td>String</td>
+      <td>
+         This can set and pass arbitrary HBase configurations. Suffix names must match the configuration key defined in <a href="https://abloz.com/hbase/book.html#perf.configurations">HBase Configuration documentation</a>. Flink will remove the "properties." key prefix and pass the transformed key and values to the underlying HBaseClient. For example, you can add a kerberos authentication parameter <code>'properties.hbase.security.authentication' = 'kerberos'</code>.

Review comment:
       Please use an official HBase link, e.g. http://hbase.apache.org/2.3/book.html#hbase_default_configurations ?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #14645: [FLINK-20967][docs] HBase properties 'properties.*' function Description

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14645:
URL: https://github.com/apache/flink/pull/14645#issuecomment-760117300


   Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
   to review your pull request. We will use this comment to track the progress of the review.
   
   
   ## Automated Checks
   Last check on commit 130e09ba6abaec1b647f89fed3aee7bb364977da (Fri May 28 07:08:28 UTC 2021)
   
   **Warnings:**
    * No documentation files were touched! Remember to keep the Flink docs up to date!
   
   
   <sub>Mention the bot in a comment to re-run the automated checks.</sub>
   ## Review Progress
   
   * ❓ 1. The [description] looks good.
   * ❓ 2. There is [consensus] that the contribution should go into to Flink.
   * ❓ 3. Needs [attention] from.
   * ❓ 4. The change fits into the overall [architecture].
   * ❓ 5. Overall code [quality] is good.
   
   Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
    The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
    - `@flinkbot approve all` to approve all aspects
    - `@flinkbot approve-until architecture` to approve everything until `architecture`
    - `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
    - `@flinkbot disapprove architecture` to remove an approval you gave earlier
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] wuchong merged pull request #14645: [FLINK-20967][docs] HBase properties 'properties.*' function Description

Posted by GitBox <gi...@apache.org>.
wuchong merged pull request #14645:
URL: https://github.com/apache/flink/pull/14645


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] wuchong edited a comment on pull request #14645: [FLINK-20967][docs] HBase properties 'properties.*' function Description

Posted by GitBox <gi...@apache.org>.
wuchong edited a comment on pull request #14645:
URL: https://github.com/apache/flink/pull/14645#issuecomment-760171481


   Thanks for the explanation and working on this @chaozwn. 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] chaozwn commented on pull request #14645: [FLINK-20967][docs] HBase properties 'properties.*' function Description

Posted by GitBox <gi...@apache.org>.
chaozwn commented on pull request #14645:
URL: https://github.com/apache/flink/pull/14645#issuecomment-760588151


   > Thanks for the explanation and working on this @chaozwn.
   
   I have modified the corresponding document, please help to check whether the description is accurate.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot commented on pull request #14645: [FLINK-20967][docs] HBase properties 'properties.*' function Description

Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #14645:
URL: https://github.com/apache/flink/pull/14645#issuecomment-760128893


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "c58e00c4a12a5eb33daa61822172c1366093a4ff",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "c58e00c4a12a5eb33daa61822172c1366093a4ff",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * c58e00c4a12a5eb33daa61822172c1366093a4ff UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #14645: [FLINK-20967][docs] HBase properties 'properties.*' function Description

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14645:
URL: https://github.com/apache/flink/pull/14645#issuecomment-760128893


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "c58e00c4a12a5eb33daa61822172c1366093a4ff",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12047",
       "triggerID" : "c58e00c4a12a5eb33daa61822172c1366093a4ff",
       "triggerType" : "PUSH"
     }, {
       "hash" : "377185e7ca78d74e7e95479f97c27e20b215dce4",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12081",
       "triggerID" : "377185e7ca78d74e7e95479f97c27e20b215dce4",
       "triggerType" : "PUSH"
     }, {
       "hash" : "130e09ba6abaec1b647f89fed3aee7bb364977da",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12099",
       "triggerID" : "130e09ba6abaec1b647f89fed3aee7bb364977da",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 130e09ba6abaec1b647f89fed3aee7bb364977da Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12099) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #14645: [FLINK-20967][docs] HBase properties 'properties.*' function Description

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14645:
URL: https://github.com/apache/flink/pull/14645#issuecomment-760128893


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "c58e00c4a12a5eb33daa61822172c1366093a4ff",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12047",
       "triggerID" : "c58e00c4a12a5eb33daa61822172c1366093a4ff",
       "triggerType" : "PUSH"
     }, {
       "hash" : "377185e7ca78d74e7e95479f97c27e20b215dce4",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12081",
       "triggerID" : "377185e7ca78d74e7e95479f97c27e20b215dce4",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 377185e7ca78d74e7e95479f97c27e20b215dce4 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12081) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #14645: [FLINK-20967][docs] HBase properties 'properties.*' function Description

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14645:
URL: https://github.com/apache/flink/pull/14645#issuecomment-760128893


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "c58e00c4a12a5eb33daa61822172c1366093a4ff",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12047",
       "triggerID" : "c58e00c4a12a5eb33daa61822172c1366093a4ff",
       "triggerType" : "PUSH"
     }, {
       "hash" : "377185e7ca78d74e7e95479f97c27e20b215dce4",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12081",
       "triggerID" : "377185e7ca78d74e7e95479f97c27e20b215dce4",
       "triggerType" : "PUSH"
     }, {
       "hash" : "130e09ba6abaec1b647f89fed3aee7bb364977da",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "130e09ba6abaec1b647f89fed3aee7bb364977da",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 377185e7ca78d74e7e95479f97c27e20b215dce4 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12081) 
   * 130e09ba6abaec1b647f89fed3aee7bb364977da UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot commented on pull request #14645: [FLINK-20967][docs] HBase properties 'properties.*' function Description

Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #14645:
URL: https://github.com/apache/flink/pull/14645#issuecomment-760117300


   Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
   to review your pull request. We will use this comment to track the progress of the review.
   
   
   ## Automated Checks
   Last check on commit c58e00c4a12a5eb33daa61822172c1366093a4ff (Thu Jan 14 10:50:02 UTC 2021)
   
    ✅no warnings
   
   <sub>Mention the bot in a comment to re-run the automated checks.</sub>
   ## Review Progress
   
   * ❓ 1. The [description] looks good.
   * ❓ 2. There is [consensus] that the contribution should go into to Flink.
   * ❓ 3. Needs [attention] from.
   * ❓ 4. The change fits into the overall [architecture].
   * ❓ 5. Overall code [quality] is good.
   
   Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
    The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
    - `@flinkbot approve all` to approve all aspects
    - `@flinkbot approve-until architecture` to approve everything until `architecture`
    - `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
    - `@flinkbot disapprove architecture` to remove an approval you gave earlier
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org