You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@couchdb.apache.org by "nickva (via GitHub)" <gi...@apache.org> on 2023/10/06 04:55:54 UTC

[PR] Another attempt at fixing the flaky ddoc_cache test [couchdb]

nickva opened a new pull request, #4803:
URL: https://github.com/apache/couchdb/pull/4803

   This test has been the most flaky one lately.
   
   DDoc cache does quite a bit async process spawning. It's possible that entry processes never finish opening before the test already proceeds and expects all 10 entries to be removed.
   
   Also, to increase isolation between tests switch eunit `setup` to `foreach`. This will restart the whole ddoc app and reduce possible influence of one test on another.
   
   Fix: https://github.com/apache/couchdb/issues/4793
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@couchdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Another attempt at fixing the flaky ddoc_cache test [couchdb]

Posted by "nickva (via GitHub)" <gi...@apache.org>.
nickva commented on code in PR #4803:
URL: https://github.com/apache/couchdb/pull/4803#discussion_r1348246710


##########
src/ddoc_cache/test/eunit/ddoc_cache_lru_test.erl:
##########
@@ -200,10 +200,23 @@ check_cache_refill({DbName, _}) ->
         lists:seq(1, 5)
     ),
 
+    % Wait for all 10 entries (5 ddocid + 5 ddocid_rev) to be inserted into the
+    % LRU before preceeding

Review Comment:
   Good catch. Thanks!



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@couchdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Another attempt at fixing the flaky ddoc_cache test [couchdb]

Posted by "nickva (via GitHub)" <gi...@apache.org>.
nickva merged PR #4803:
URL: https://github.com/apache/couchdb/pull/4803


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@couchdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Another attempt at fixing the flaky ddoc_cache test [couchdb]

Posted by "jaydoane (via GitHub)" <gi...@apache.org>.
jaydoane commented on code in PR #4803:
URL: https://github.com/apache/couchdb/pull/4803#discussion_r1348245812


##########
src/ddoc_cache/test/eunit/ddoc_cache_lru_test.erl:
##########
@@ -200,10 +200,23 @@ check_cache_refill({DbName, _}) ->
         lists:seq(1, 5)
     ),
 
+    % Wait for all 10 entries (5 ddocid + 5 ddocid_rev) to be inserted into the
+    % LRU before preceeding

Review Comment:
   s/preceeding/proceeding/



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@couchdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org