You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ofbiz.apache.org by Adam Heath <do...@brainfood.com> on 2009/06/24 05:46:19 UTC
Re: svn commit: r787890 - in /ofbiz/trunk/applications/marketing:
config/MarketingUiLabels.xml script/org/ofbiz/sfa/lead/LeadServices.xml
apatel@apache.org wrote:
> Author: apatel
> Date: Wed Jun 24 02:48:28 2009
> New Revision: 787890
>
> URL: http://svn.apache.org/viewvc?rev=787890&view=rev
> Log:
> Minor code clean up in createLead service. Convert lead now expires relationship instead of deleting it.
>
> Modified:
> ofbiz/trunk/applications/marketing/config/MarketingUiLabels.xml
> ofbiz/trunk/applications/marketing/script/org/ofbiz/sfa/lead/LeadServices.xml
>
> Modified: ofbiz/trunk/applications/marketing/script/org/ofbiz/sfa/lead/LeadServices.xml
> URL: http://svn.apache.org/viewvc/ofbiz/trunk/applications/marketing/script/org/ofbiz/sfa/lead/LeadServices.xml?rev=787890&r1=787889&r2=787890&view=diff
> ==============================================================================
> --- ofbiz/trunk/applications/marketing/script/org/ofbiz/sfa/lead/LeadServices.xml (original)
> +++ ofbiz/trunk/applications/marketing/script/org/ofbiz/sfa/lead/LeadServices.xml Wed Jun 24 02:48:28 2009
> @@ -52,15 +52,18 @@
> <set field="parameters.roleTypeId" value="LEAD"/>
> <call-simple-method method-name="createPersonRoleAndContactMechs" xml-resource="component://party/script/org/ofbiz/party/party/PartySimpleMethods.xml"/>
> <check-errors/>
> +
> + <set field="leadContactPartyId" from-field="partyId"/>
> + <clear-field field="partyId"/>
> <set field="partyRelationshipCtx.partyIdFrom" from-field="userLogin.partyId"/>
> - <set field="partyRelationshipCtx.partyIdTo" from-field="partyId"/>
> + <set field="partyRelationshipCtx.partyIdTo" from-field="leadContactPartyId"/>
Service is createLead, but returns leadContactPartyId? That doesn't
seem sensible.
Re: svn commit: r787890 - in /ofbiz/trunk/applications/marketing:
config/MarketingUiLabels.xml script/org/ofbiz/sfa/lead/LeadServices.xml
Posted by Adam Heath <do...@brainfood.com>.
Anil Patel wrote:
> Adam,
> The service is returning id of two parties created in in the service. I
> don't see anything bad about it. Can you please explain why is it not good?
>
> Also in this modification I have changed variable name used in method,
> partyId out parameter was there before my this commit.
Sure, no problem returning any number of party ids. I was saying it
should return 'leadPartyId', to match the name of the service,
'createLead'. The name of the service is *not* createLeadContact.
Re: svn commit: r787890 - in /ofbiz/trunk/applications/marketing: config/MarketingUiLabels.xml script/org/ofbiz/sfa/lead/LeadServices.xml
Posted by Anil Patel <an...@hotwaxmedia.com>.
Adam,
The service is returning id of two parties created in in the service.
I don't see anything bad about it. Can you please explain why is it
not good?
Also in this modification I have changed variable name used in method,
partyId out parameter was there before my this commit.
Regards
Anil Patel
On Jun 23, 2009, at 11:46 PM, Adam Heath wrote:
> apatel@apache.org wrote:
>> Author: apatel
>> Date: Wed Jun 24 02:48:28 2009
>> New Revision: 787890
>>
>> URL: http://svn.apache.org/viewvc?rev=787890&view=rev
>> Log:
>> Minor code clean up in createLead service. Convert lead now expires
>> relationship instead of deleting it.
>>
>> Modified:
>> ofbiz/trunk/applications/marketing/config/MarketingUiLabels.xml
>> ofbiz/trunk/applications/marketing/script/org/ofbiz/sfa/lead/
>> LeadServices.xml
>>
>> Modified: ofbiz/trunk/applications/marketing/script/org/ofbiz/sfa/
>> lead/LeadServices.xml
>> URL: http://svn.apache.org/viewvc/ofbiz/trunk/applications/marketing/script/org/ofbiz/sfa/lead/LeadServices.xml?rev=787890&r1=787889&r2=787890&view=diff
>> =
>> =
>> =
>> =
>> =
>> =
>> =
>> =
>> =
>> =====================================================================
>> --- ofbiz/trunk/applications/marketing/script/org/ofbiz/sfa/lead/
>> LeadServices.xml (original)
>> +++ ofbiz/trunk/applications/marketing/script/org/ofbiz/sfa/lead/
>> LeadServices.xml Wed Jun 24 02:48:28 2009
>> @@ -52,15 +52,18 @@
>> <set field="parameters.roleTypeId" value="LEAD"/>
>> <call-simple-method method-
>> name="createPersonRoleAndContactMechs" xml-resource="component://
>> party/script/org/ofbiz/party/party/PartySimpleMethods.xml"/>
>> <check-errors/>
>> +
>> + <set field="leadContactPartyId" from-
>> field="partyId"/>
>> + <clear-field field="partyId"/>
>> <set field="partyRelationshipCtx.partyIdFrom" from-
>> field="userLogin.partyId"/>
>> - <set field="partyRelationshipCtx.partyIdTo" from-
>> field="partyId"/>
>> + <set field="partyRelationshipCtx.partyIdTo" from-
>> field="leadContactPartyId"/>
>
> Service is createLead, but returns leadContactPartyId? That doesn't
> seem sensible.
Re: svn commit: r787890 - in /ofbiz/trunk/applications/marketing:
config/MarketingUiLabels.xml script/org/ofbiz/sfa/lead/LeadServices.xml
Posted by Rishi Solanki <ri...@gmail.com>.
Hi,
As the createLead service is creating PartyRelationship record on the basis
of some parameters conditions so it should return the both partyId only, and
the code committed is improved code to make it more sensible so that the
partyId is now in whole service identified by the leadContactPartyId,
finally it just change way of outing the partyId. I think the code is fine
and creating a lead means tie up a party in the LEAD role with the
PartyGroup. I do not seen any problem in returning the leadContactPartyId as
partyId.
Rishi Solanki
Enterprise Software Developer
HotWax Media Pvt. Ltd.
On Wed, Jun 24, 2009 at 11:51 AM, Anil Patel <an...@hotwaxmedia.com>wrote:
> Adam,
> The service is returning id of two parties created in in the service.
> I don't see anything bad about it. Can you please explain why is it
> not good?
>
> Also in this modification I have changed variable name used in method,
> partyId out parameter was there before my this commit.
>
> Regards
> Anil Patel
>
>
>
> On Jun 23, 2009, at 11:46 PM, Adam Heath wrote:
>
> apatel@apache.org wrote:
>>
>>> Author: apatel
>>> Date: Wed Jun 24 02:48:28 2009
>>> New Revision: 787890
>>>
>>> URL: http://svn.apache.org/viewvc?rev=787890&view=rev
>>> Log:
>>> Minor code clean up in createLead service. Convert lead now expires
>>> relationship instead of deleting it.
>>>
>>> Modified:
>>> ofbiz/trunk/applications/marketing/config/MarketingUiLabels.xml
>>>
>>> ofbiz/trunk/applications/marketing/script/org/ofbiz/sfa/lead/LeadServices.xml
>>>
>>> Modified:
>>> ofbiz/trunk/applications/marketing/script/org/ofbiz/sfa/lead/LeadServices.xml
>>> URL:
>>> http://svn.apache.org/viewvc/ofbiz/trunk/applications/marketing/script/org/ofbiz/sfa/lead/LeadServices.xml?rev=787890&r1=787889&r2=787890&view=diff
>>>
>>> ==============================================================================
>>> ---
>>> ofbiz/trunk/applications/marketing/script/org/ofbiz/sfa/lead/LeadServices.xml
>>> (original)
>>> +++
>>> ofbiz/trunk/applications/marketing/script/org/ofbiz/sfa/lead/LeadServices.xml
>>> Wed Jun 24 02:48:28 2009
>>> @@ -52,15 +52,18 @@
>>> <set field="parameters.roleTypeId" value="LEAD"/>
>>> <call-simple-method
>>> method-name="createPersonRoleAndContactMechs"
>>> xml-resource="component://party/script/org/ofbiz/party/party/PartySimpleMethods.xml"/>
>>> <check-errors/>
>>> +
>>> + <set field="leadContactPartyId" from-field="partyId"/>
>>> + <clear-field field="partyId"/>
>>> <set field="partyRelationshipCtx.partyIdFrom"
>>> from-field="userLogin.partyId"/>
>>> - <set field="partyRelationshipCtx.partyIdTo"
>>> from-field="partyId"/>
>>> + <set field="partyRelationshipCtx.partyIdTo"
>>> from-field="leadContactPartyId"/>
>>>
>>
>> Service is createLead, but returns leadContactPartyId? That doesn't
>> seem sensible.
>>
>
>
Re: svn commit: r787890 - in /ofbiz/trunk/applications/marketing: config/MarketingUiLabels.xml script/org/ofbiz/sfa/lead/LeadServices.xml
Posted by Anil Patel <an...@hotwaxmedia.com>.
Adam,
The service is returning id of two parties created in in the service.
I don't see anything bad about it. Can you please explain why is it
not good?
Also in this modification I have changed variable name used in method,
partyId out parameter was there before my this commit.
Regards
Anil Patel
On Jun 23, 2009, at 11:46 PM, Adam Heath wrote:
> apatel@apache.org wrote:
>> Author: apatel
>> Date: Wed Jun 24 02:48:28 2009
>> New Revision: 787890
>>
>> URL: http://svn.apache.org/viewvc?rev=787890&view=rev
>> Log:
>> Minor code clean up in createLead service. Convert lead now expires
>> relationship instead of deleting it.
>>
>> Modified:
>> ofbiz/trunk/applications/marketing/config/MarketingUiLabels.xml
>> ofbiz/trunk/applications/marketing/script/org/ofbiz/sfa/lead/
>> LeadServices.xml
>>
>> Modified: ofbiz/trunk/applications/marketing/script/org/ofbiz/sfa/
>> lead/LeadServices.xml
>> URL: http://svn.apache.org/viewvc/ofbiz/trunk/applications/marketing/script/org/ofbiz/sfa/lead/LeadServices.xml?rev=787890&r1=787889&r2=787890&view=diff
>> =
>> =
>> =
>> =
>> =
>> =
>> =
>> =
>> =
>> =====================================================================
>> --- ofbiz/trunk/applications/marketing/script/org/ofbiz/sfa/lead/
>> LeadServices.xml (original)
>> +++ ofbiz/trunk/applications/marketing/script/org/ofbiz/sfa/lead/
>> LeadServices.xml Wed Jun 24 02:48:28 2009
>> @@ -52,15 +52,18 @@
>> <set field="parameters.roleTypeId" value="LEAD"/>
>> <call-simple-method method-
>> name="createPersonRoleAndContactMechs" xml-resource="component://
>> party/script/org/ofbiz/party/party/PartySimpleMethods.xml"/>
>> <check-errors/>
>> +
>> + <set field="leadContactPartyId" from-
>> field="partyId"/>
>> + <clear-field field="partyId"/>
>> <set field="partyRelationshipCtx.partyIdFrom" from-
>> field="userLogin.partyId"/>
>> - <set field="partyRelationshipCtx.partyIdTo" from-
>> field="partyId"/>
>> + <set field="partyRelationshipCtx.partyIdTo" from-
>> field="leadContactPartyId"/>
>
> Service is createLead, but returns leadContactPartyId? That doesn't
> seem sensible.