You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@lucene.apache.org by "Robert Muir (Jira)" <ji...@apache.org> on 2020/03/06 02:10:00 UTC

[jira] [Commented] (LUCENE-9241) fix most memory-hungry tests

    [ https://issues.apache.org/jira/browse/LUCENE-9241?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17052668#comment-17052668 ] 

Robert Muir commented on LUCENE-9241:
-------------------------------------

[~dweiss] I saw a recent URLclassloader windows leak thread on the jdk list and it reminded me of this issue.

I'll remove the use of getResource (*please keep in mind there are many of these elsewhere in the codebase if you are actually concerned about this*).

Instead, if the user screws up here in their test, they'll get a NullPointerException and they can follow the stack trace. Soon the default NPE from the JDK will actually be more helpful than such custom messages like this anyway.

> fix most memory-hungry tests
> ----------------------------
>
>                 Key: LUCENE-9241
>                 URL: https://issues.apache.org/jira/browse/LUCENE-9241
>             Project: Lucene - Core
>          Issue Type: Improvement
>            Reporter: Robert Muir
>            Priority: Major
>         Attachments: LUCENE-9241.patch
>
>
> Currently each test jvm has Xmx of 512M. With a modern macbook pro this is 4GB which is pretty crazy.
> On the other hand, if we fix a few edge cases, tests can work with lower heaps such as 128M. This can save many gigabytes (also it finds interesting memory waste/issues).



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org