You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@pekko.apache.org by "pjfanning (via GitHub)" <gi...@apache.org> on 2024/02/12 12:00:49 UTC
[PR] Create nightly-1.0-builds.yml [incubator-pekko]
pjfanning opened a new pull request, #1120:
URL: https://github.com/apache/incubator-pekko/pull/1120
see #1119
I prefer keeping this yml separate so that we can tailor what we want to run
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
Re: [PR] Create nightly-1.0-builds.yml [incubator-pekko]
Posted by "pjfanning (via GitHub)" <gi...@apache.org>.
pjfanning merged PR #1120:
URL: https://github.com/apache/incubator-pekko/pull/1120
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
Re: [PR] Create nightly-1.0-builds.yml [incubator-pekko]
Posted by "pjfanning (via GitHub)" <gi...@apache.org>.
pjfanning commented on code in PR #1120:
URL: https://github.com/apache/incubator-pekko/pull/1120#discussion_r1486128707
##########
.github/workflows/nightly-1.0-builds.yml:
##########
@@ -0,0 +1,142 @@
+name: Nightly Builds (1.0)
+
+on:
+ schedule:
+ - cron: "0 0 * * *"
+ workflow_dispatch:
+
+permissions: {}
Review Comment:
it's an attempt to limit the permissions for the GitHub token - this setting basically says we don't need it at all
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
Re: [PR] Create nightly-1.0-builds.yml [incubator-pekko]
Posted by "raboof (via GitHub)" <gi...@apache.org>.
raboof commented on code in PR #1120:
URL: https://github.com/apache/incubator-pekko/pull/1120#discussion_r1486126732
##########
.github/workflows/nightly-1.0-builds.yml:
##########
@@ -0,0 +1,142 @@
+name: Nightly Builds (1.0)
+
+on:
+ schedule:
+ - cron: "0 0 * * *"
+ workflow_dispatch:
+
+permissions: {}
Review Comment:
I'm curious what this does?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
Re: [PR] Create nightly-1.0-builds.yml [incubator-pekko]
Posted by "raboof (via GitHub)" <gi...@apache.org>.
raboof commented on code in PR #1120:
URL: https://github.com/apache/incubator-pekko/pull/1120#discussion_r1486149812
##########
.github/workflows/nightly-1.0-builds.yml:
##########
@@ -0,0 +1,142 @@
+name: Nightly Builds (1.0)
+
+on:
+ schedule:
+ - cron: "0 0 * * *"
+ workflow_dispatch:
+
+permissions: {}
Review Comment:
right, so the default permissions are wider than `{}` (https://docs.github.com/en/actions/using-jobs/assigning-permissions-to-jobs) :+1: great!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org