[GitHub] [arrow] xhochy commented on a change in pull request #9096: [Python][Packaging] Refactor manylinux and windows wheel building [WIP]

[GitBox <gi...@apache.org>]

xhochy commented on a change in pull request #9096:
URL: https://github.com/apache/arrow/pull/9096#discussion_r553926908



##########
File path: python/setup.py
##########
@@ -385,17 +385,19 @@ def _bundle_arrow_cpp(self, build_prefix, build_lib):
                 build_prefix, build_lib,
                 "{}_regex".format(self.boost_namespace),
                 implib_required=False)
-        if sys.platform == 'win32':
-            # zlib uses zlib.dll for Windows
-            zlib_lib_name = 'zlib'
-            move_shared_libs(build_prefix, build_lib, zlib_lib_name,
-                             implib_required=False)
-            if self.with_flight:
-                # DLL dependencies for gRPC / Flight
-                for lib_name in ['libcrypto-1_1-x64',
-                                 'libssl-1_1-x64']:
-                    move_shared_libs(build_prefix, build_lib, lib_name,
-                                     implib_required=False)
+        # TODO(kszucs): consider to bundle the following shared libraries

Review comment:
       In the case of OpenSSL, if we bundled a shared version the version in the main system will be preferred. Not sure though where this is updated from. In `conda-forge` we explicitly have a Python setup that takes care that one is not used.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org