[GitHub] JaroslavTulach commented on a change in pull request #505: [NETBEANS-615] When nb-javac is not installed, don't let CoS run, but…

[GitBox <gi...@apache.org>]

JaroslavTulach commented on a change in pull request #505: [NETBEANS-615] When nb-javac is not installed, don't let CoS run, but…
URL: https://github.com/apache/incubator-netbeans/pull/505#discussion_r181956914
 
 

 ##########
 File path: java.source.base/src/org/netbeans/modules/java/source/indexing/JavaCustomIndexer.java
 ##########
 @@ -130,6 +130,7 @@
     private static final String APT_SOURCE_OUTPUT = "apSrcOut"; //NOI18N
     private static final Pattern ANONYMOUS = Pattern.compile("\\$[0-9]"); //NOI18N
     private static final ClassPath EMPTY = ClassPathSupport.createClassPath(new URL[0]);
+    private static final String PROP_NB_JAVAC = "nb-javac.installed"; //NOI18N
 
 Review comment:
   Wild, terrible hack.
   
   Wouldn't it be more constructive to record version of `javac` that is used for indexing and if the version changes (due to `nbjavac` being installed or due to change of `JDK` etc.) reparse?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists