You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2022/05/16 07:13:43 UTC
[GitHub] [incubator-doris] morrySnow opened a new pull request, #9589: [fix](planner)VecNotImplException thrown when query need rewrite and some slot cannot changed to nullable
morrySnow opened a new pull request, #9589:
URL: https://github.com/apache/incubator-doris/pull/9589
…some slot cannot changed to nullable
# Proposed changes
Issue Number: close #9588
## Problem Summary:
Could reproduced by:
```sql
create table test.tbl1
(k1 int, k2 int, v1 int)
distributed by hash(k1)
properties("replication_num" = "1");
explain select * from test.tbl1 t1 where (select count(*) from test.tbl1 t2 where t1.k1 = t2.k1) > 0;
```
## Checklist(Required)
1. Does it affect the original behavior: (No)
2. Has unit tests been added: (Yes)
3. Has document been added or modified: (No Need)
4. Does it need to update dependencies: (No)
5. Are there any changes that cannot be rolled back: (No)
## Further comments
If this is a relatively large or complex change, kick off the discussion at [dev@doris.apache.org](mailto:dev@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] github-actions[bot] commented on pull request #9589: [fix](planner)VecNotImplException thrown when query need rewrite and some slot cannot changed to nullable
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #9589:
URL: https://github.com/apache/incubator-doris/pull/9589#issuecomment-1127436455
PR approved by at least one committer and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] EmmyMiao87 commented on a diff in pull request #9589: [fix](planner)VecNotImplException thrown when query need rewrite and some slot cannot changed to nullable
Posted by GitBox <gi...@apache.org>.
EmmyMiao87 commented on code in PR #9589:
URL: https://github.com/apache/incubator-doris/pull/9589#discussion_r873457641
##########
fe/fe-core/src/main/java/org/apache/doris/common/util/VectorizedUtil.java:
##########
@@ -63,10 +58,14 @@ public static void switchToQueryNonVec() {
if (connectContext == null) {
return;
}
- Analyzer analyzer = connectContext.getExecutor().getAnalyzer();
- if (analyzer == null) {
- return;
+ SessionVariable sessionVariable = connectContext.getSessionVariable();
+ sessionVariable.setIsSingleSetVar(true);
Review Comment:
Where is the declare of this var ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] yiguolei merged pull request #9589: [fix](planner)VecNotImplException thrown when query need rewrite and some slot cannot changed to nullable
Posted by GitBox <gi...@apache.org>.
yiguolei merged PR #9589:
URL: https://github.com/apache/incubator-doris/pull/9589
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] EmmyMiao87 commented on a diff in pull request #9589: [fix](planner)VecNotImplException thrown when query need rewrite and some slot cannot changed to nullable
Posted by GitBox <gi...@apache.org>.
EmmyMiao87 commented on code in PR #9589:
URL: https://github.com/apache/incubator-doris/pull/9589#discussion_r873506424
##########
fe/fe-core/src/main/java/org/apache/doris/common/util/VectorizedUtil.java:
##########
@@ -63,10 +58,14 @@ public static void switchToQueryNonVec() {
if (connectContext == null) {
return;
}
- Analyzer analyzer = connectContext.getExecutor().getAnalyzer();
- if (analyzer == null) {
- return;
+ SessionVariable sessionVariable = connectContext.getSessionVariable();
+ sessionVariable.setIsSingleSetVar(true);
Review Comment:
Sorry, I didn't find this function just now
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] github-actions[bot] commented on pull request #9589: [fix](planner)VecNotImplException thrown when query need rewrite and some slot cannot changed to nullable
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #9589:
URL: https://github.com/apache/incubator-doris/pull/9589#issuecomment-1127436502
PR approved by anyone and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org