You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@artemis.apache.org by "ASF GitHub Bot (Jira)" <ji...@apache.org> on 2026/09/03 16:26:00 UTC

[jira] [Work logged] (ARTEMIS-6116) Fix tests for windows OS

     [ https://issues.apache.org/jira/browse/ARTEMIS-6116?focusedWorklogId=1039491&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-1039491 ]

ASF GitHub Bot logged work on ARTEMIS-6116:
-------------------------------------------

                Author: ASF GitHub Bot
            Created on: 03/Sep/26 16:25
            Start Date: 03/Sep/26 16:25
    Worklog Time Spent: 10m 
      Work Description: jbertram commented on PR #6513:
URL: https://github.com/apache/artemis/pull/6513#issuecomment-5528762255

   Most of this looks good. I only have qualms with two commits:
   
   - "Release file handles in MessageSerializerTest" - this appears to be masking an actual leak, at least in regards to the `Producer`.
   - "Replace ':' in filename with '_'" - this appears to have genuine upgrade problems. Lock files created with `:` will no longer be loaded once this code is changed. This change should include a note in `versions.adoc` as well as code to detect & rename existing files using `:`. Alternatively, it may be simpler to just detect the OS and adjust accordingly so that non-Windows use-cases didn't need to change.
   
   I'll merge the rest but I'm dropping these two commits.




Issue Time Tracking
-------------------

    Worklog Id:     (was: 1039491)
    Time Spent: 3h  (was: 2h 50m)

> Fix tests for windows OS
> ------------------------
>
>                 Key: ARTEMIS-6116
>                 URL: https://issues.apache.org/jira/browse/ARTEMIS-6116
>             Project: Artemis
>          Issue Type: Test
>          Components: Broker, Tests
>    Affects Versions: 2.54.0
>            Reporter: Gašper Čefarin
>            Priority: Major
>              Labels: pull-request-available
>          Time Spent: 3h
>  Remaining Estimate: 0h
>
> Some of the tests are failing when running them on windows OS.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@artemis.apache.org
For additional commands, e-mail: issues-help@artemis.apache.org