You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2020/04/30 10:57:35 UTC

[GitHub] [arrow] liyafan82 commented on a change in pull request #6672: ARROW-8169: [Java] Improve the performance of JDBC adapter by allocating memory proactively

liyafan82 commented on a change in pull request #6672:
URL: https://github.com/apache/arrow/pull/6672#discussion_r417926598



##########
File path: java/adapter/jdbc/src/main/java/org/apache/arrow/adapter/jdbc/consumer/DateConsumer.java
##########
@@ -89,7 +89,7 @@ public void consume(ResultSet resultSet) throws SQLException {
         if (day < 0 || day > MAX_DAY) {
           throw new IllegalArgumentException("Day overflow: " + day);
         }
-        vector.setSafe(currentIndex, day);
+        vector.set(currentIndex, day);

Review comment:
       Comments added. Thank you for the good suggestion. 




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org