You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2020/09/17 12:58:46 UTC
[GitHub] [apisix] gy09535 opened a new issue #2249: feat: build docker image with source code
gy09535 opened a new issue #2249:
URL: https://github.com/apache/apisix/issues/2249
### Issue description
Sometime we should add some special logical for ourself business, we should build docker image with source code. So maybe we should add dockerfile in source code.
### Environment
* apisix version (cmd: `apisix version`):
* OS:
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] gy09535 commented on issue #2249: feat: build docker image with source code
Posted by GitBox <gi...@apache.org>.
gy09535 commented on issue #2249:
URL: https://github.com/apache/apisix/issues/2249#issuecomment-694691589
I think it can not build code from local repos
> is https://github.com/apache/apisix-docker good for you?
I think it can not build images from our private repository for secondary develop. If I change some code for our different logical, https://github.com/apache/apisix-docker can not work for me.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] moonming commented on issue #2249: feat: build docker image with source code
Posted by GitBox <gi...@apache.org>.
moonming commented on issue #2249:
URL: https://github.com/apache/apisix/issues/2249#issuecomment-694633629
is https://github.com/apache/apisix-docker good for you?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] moonming commented on issue #2249: feat: build docker image with source code
Posted by GitBox <gi...@apache.org>.
moonming commented on issue #2249:
URL: https://github.com/apache/apisix/issues/2249#issuecomment-720262659
@gy09535 Which part of the code did you modify? I'm not sure whether exposing the code directory will solve this problem?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] moonming commented on issue #2249: feat: build docker image with source code
Posted by GitBox <gi...@apache.org>.
moonming commented on issue #2249:
URL: https://github.com/apache/apisix/issues/2249#issuecomment-722052016
@gy09535 Got it.
The current dockerfile does not consider the situation of building from local source code. Welcome to PR to add, I transferred this issue to the apisix-docker project
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] gy09535 commented on issue #2249: feat: build docker image with source code
Posted by GitBox <gi...@apache.org>.
gy09535 commented on issue #2249:
URL: https://github.com/apache/apisix/issues/2249#issuecomment-720882727
> @gy09535 Which part of the code did you modify? I'm not sure whether exposing the code directory will solve this problem?
I want build the code with source code ,but I have change some code such as self define plugins. The https://github.com/apache/apisix-docker/blob/master/alpine/Dockerfile is build the code from gitlab , but our code in our private repository . Now when the apache apisix has new release I merge it in our self repository and build a new image for our business. I think some company maybe has the same problem? So I think maybe we should add the Docker file in the source code and build with source code other then git hub code.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] gy09535 edited a comment on issue #2249: feat: build docker image with source code
Posted by GitBox <gi...@apache.org>.
gy09535 edited a comment on issue #2249:
URL: https://github.com/apache/apisix/issues/2249#issuecomment-720882727
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] juzhiyuan commented on issue #2249: feat: build docker image with source code
Posted by GitBox <gi...@apache.org>.
juzhiyuan commented on issue #2249:
URL: https://github.com/apache/apisix/issues/2249#issuecomment-720259099
Do we have a final discussion result here?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org