You are viewing a plain text version of this content. The canonical link for it is here.
Posted to oak-dev@jackrabbit.apache.org by Julian Reschke <ju...@gmx.de> on 2013/12/09 16:23:16 UTC

clarification on _modCount / mongomk.md

Hi there,

I was trying to understand where support for _modCount actually happens.

As far as I can tell, a DocumentStore implementation is free to use it 
or not. The only non-MongoDocumentStore traces I could see is the string 
constant in Document.java, right?

Best regards, Julian

RE: clarification on _modCount / mongomk.md

Posted by Marcel Reutegger <mr...@adobe.com>.
Hi,

> As the use of MODCOUNT is somewhat internal to a DocumentStore impl,
> wouldn't it make sense to remove this signature and let the impls just
> to a regular Document.get(property)?

sounds reasonable. can you please create an issue? thanks.

regards
 marcel

Re: clarification on _modCount / mongomk.md

Posted by Julian Reschke <ju...@gmx.de>.
On 2013-12-09 16:29, Marcel Reutegger wrote:
> Hi,
>
>> I was trying to understand where support for _modCount actually happens.
>>
>> As far as I can tell, a DocumentStore implementation is free to use it
>> or not. The only non-MongoDocumentStore traces I could see is the string
>> constant in Document.java, right?
>
> this is correct. The JavaDoc for the field isn't really specific about this, but the
> return value of getModCount() is annotated with @CheckForNull, indicating
> that a Document may not have a mod count.

Right, forgot about that case.

As the use of MODCOUNT is somewhat internal to a DocumentStore impl, 
wouldn't it make sense to remove this signature and let the impls just 
to a regular Document.get(property)?

Best regards, Julian

RE: clarification on _modCount / mongomk.md

Posted by Marcel Reutegger <mr...@adobe.com>.
Hi,

> I was trying to understand where support for _modCount actually happens.
> 
> As far as I can tell, a DocumentStore implementation is free to use it
> or not. The only non-MongoDocumentStore traces I could see is the string
> constant in Document.java, right?

this is correct. The JavaDoc for the field isn't really specific about this, but the
return value of getModCount() is annotated with @CheckForNull, indicating
that a Document may not have a mod count.

Regards
 Marcel