You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hop.apache.org by "mattcasters (via GitHub)" <gi...@apache.org> on 2026/07/19 14:55:44 UTC
[PR] issue #7549 : content editor toolbar/context menu (help for #7550) (hop)
mattcasters opened a new pull request, #7576:
URL: https://github.com/apache/hop/pull/7576
## Summary
Helps unblock [@nadment](https://github.com/nadment)'s [#7550](https://github.com/apache/hop/pull/7550) / [#7549](https://github.com/apache/hop/issues/7549).
Includes Nicolas's original change (shared content-editor toolbar + context menu on RCP, cut/paste capabilities on text file types) plus fixes for the three gaps he called out:
1. **RAP compile** — `IContentEditorWidget.getLanguage()` implemented on Monaco and fallback RAP widgets (CI was failing on `hop-ui-rap`).
2. **Shared toolbar on hop-web** — RAP builds `ContentEditor-Toolbar` so plugin actions (Markdown preview) show in web, not only desktop.
3. **Markdown preview listener** — `BaseGuiWidgets` resolves static toolbar methods with **assignable** parameter types (interface/facade), so `previewMarkdown(IContentEditorWidget)` works when the registered instance is `ContentEditorWidget` or a RAP widget. Preview is restored as that static method.
Also dedupes content-editor i18n keys and adds a small unit test for static listener resolution.
Nicolas: if you prefer to keep ownership on #7550, you can cherry-pick `d221789455` (or merge this branch) into `7549` and close this PR.
## Test plan
- [x] `./mvnw -pl ui,rcp,rap,plugins/transforms/textfile -am install -DskipTests` (includes `hop-ui-rap`)
- [x] `./mvnw -pl ui test -Dtest=BaseGuiWidgetsStaticListenerTest`
- [x] `./mvnw -pl plugins/transforms/textfile,rcp test`
- [ ] Manual RCP: open `.md` → shared toolbar Preview works; cut/copy/paste/context menu on text
- [ ] Manual hop-web: open `.md` → Preview button visible and works
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] issue #7549 : content editor toolbar/context menu (help for #7550) (hop)
Posted by "mattcasters (via GitHub)" <gi...@apache.org>.
mattcasters commented on PR #7576:
URL: https://github.com/apache/hop/pull/7576#issuecomment-5016436094
Pushed: **Monaco dark theme** for Hop Web content editors.
When the session is dark (`PropsUi.isDarkMode()` / `/ui-dark`), Monaco is created with theme `vs-dark`; light sessions use `vs`. Same idea as canvas `themeId`.
Try: http://localhost:8080/ui-dark → open a text/markdown file → editor background should match the dark UI.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] issue #7549 : content editor toolbar/context menu (help for #7550) (hop)
Posted by "mattcasters (via GitHub)" <gi...@apache.org>.
mattcasters commented on PR #7576:
URL: https://github.com/apache/hop/pull/7576#issuecomment-5016443165
<img width="3027" height="1694" alt="image" src="https://github.com/user-attachments/assets/bb1583fb-7a42-4c8b-a362-151089124ae2" />
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] issue #7549 : content editor toolbar/context menu (help for #7550) (hop)
Posted by "hansva (via GitHub)" <gi...@apache.org>.
hansva merged PR #7576:
URL: https://github.com/apache/hop/pull/7576
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] issue #7549 : content editor toolbar/context menu (help for #7550) (hop)
Posted by "mattcasters (via GitHub)" <gi...@apache.org>.
mattcasters commented on PR #7576:
URL: https://github.com/apache/hop/pull/7576#issuecomment-5016423839
Pushed additional commits after Hop Web validation:
- Exclude `hop-ui-rcp` from Hop Web packaging (fixes context startup / 404)
- Shared `ContentEditorActions` GuiPlugin for content-editor toolbar on desktop + web
- Markdown preview on Hop Web via in-app `ShowBrowserDialog` (file:// temp files do not work for RAP clients)
Verified locally: toolbars above text editors, Preview only for Markdown, Preview dialog works in Hop Web.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] issue #7549 : content editor toolbar/context menu (help for #7550) (hop)
Posted by "mattcasters (via GitHub)" <gi...@apache.org>.
mattcasters commented on PR #7576:
URL: https://github.com/apache/hop/pull/7576#issuecomment-5016281406
`you're a genius`
Flattering always works but to be completely fair it's Grok Build 4.5 doing the heavy lifting.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] issue #7549 : content editor toolbar/context menu (help for #7550) (hop)
Posted by "nadment (via GitHub)" <gi...@apache.org>.
nadment commented on PR #7576:
URL: https://github.com/apache/hop/pull/7576#issuecomment-5016270593
For the RCP client, it works like a charm: you're a genius and so fast!
We'll keep your PR, and I'll close my old one.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] issue #7549 : content editor toolbar/context menu (help for #7550) (hop)
Posted by "mattcasters (via GitHub)" <gi...@apache.org>.
mattcasters commented on PR #7576:
URL: https://github.com/apache/hop/pull/7576#issuecomment-5016278736
I don't know. I'm still seeing issues but perhaps I need to rebuild my Hop Web container.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@hop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org