You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2020/06/24 21:11:01 UTC
[GitHub] [incubator-superset] codecov-commenter edited a comment on pull request #10124: refactor: Re-enable lint for 3 files
codecov-commenter edited a comment on pull request #10124:
URL: https://github.com/apache/incubator-superset/pull/10124#issuecomment-648982261
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10124?src=pr&el=h1) Report
> Merging [#10124](https://codecov.io/gh/apache/incubator-superset/pull/10124?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/c544ebd87687ea50f7ee162d4e09100b51f98ca6&el=desc) will **decrease** coverage by `0.03%`.
> The diff coverage is `65.90%`.
[![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/10124/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/10124?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #10124 +/- ##
==========================================
- Coverage 65.85% 65.82% -0.04%
==========================================
Files 594 594
Lines 31385 31388 +3
Branches 3214 3214
==========================================
- Hits 20670 20661 -9
- Misses 10534 10546 +12
Partials 181 181
```
| Flag | Coverage Δ | |
|---|---|---|
| #javascript | `59.65% <ø> (ø)` | |
| #python | `70.22% <65.90%> (-0.07%)` | :arrow_down: |
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/10124?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/connectors/druid/views.py](https://codecov.io/gh/apache/incubator-superset/pull/10124/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9kcnVpZC92aWV3cy5weQ==) | `69.38% <44.44%> (+0.46%)` | :arrow_up: |
| [superset/views/core.py](https://codecov.io/gh/apache/incubator-superset/pull/10124/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `75.15% <69.38%> (-0.15%)` | :arrow_down: |
| [superset/utils/dashboard\_import\_export.py](https://codecov.io/gh/apache/incubator-superset/pull/10124/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvZGFzaGJvYXJkX2ltcG9ydF9leHBvcnQucHk=) | `62.79% <100.00%> (-0.85%)` | :arrow_down: |
| [superset/db\_engine\_specs/mysql.py](https://codecov.io/gh/apache/incubator-superset/pull/10124/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL215c3FsLnB5) | `78.26% <0.00%> (-13.05%)` | :arrow_down: |
| [superset/models/core.py](https://codecov.io/gh/apache/incubator-superset/pull/10124/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `85.71% <0.00%> (-0.86%)` | :arrow_down: |
| [superset/connectors/sqla/models.py](https://codecov.io/gh/apache/incubator-superset/pull/10124/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL21vZGVscy5weQ==) | `88.97% <0.00%> (-0.15%)` | :arrow_down: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10124?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10124?src=pr&el=footer). Last update [c544ebd...93d809f](https://codecov.io/gh/apache/incubator-superset/pull/10124?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org