You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@accumulo.apache.org by GitBox <gi...@apache.org> on 2020/12/09 18:27:46 UTC
[GitHub] [accumulo-website] EdColeman opened a new pull request #253: update draft notes with commit changes
EdColeman opened a new pull request #253:
URL: https://github.com/apache/accumulo-website/pull/253
First cut at adding text for commits since 1.10 release
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [accumulo-website] ctubbsii commented on a change in pull request #253: update draft notes with commit changes
Posted by GitBox <gi...@apache.org>.
ctubbsii commented on a change in pull request #253:
URL: https://github.com/apache/accumulo-website/pull/253#discussion_r539615771
##########
File path: _posts/release/2020-12-09-accumulo-1.10.1.md
##########
@@ -32,11 +32,16 @@ problems you encounter, as well as perform some troubleshooting steps of your
own, in order to get the best response.
## Major Bug Fixes
-
+* Remove redundant audit message and order of authentication checks.
Review comment:
1831 is unrelated. The issue you want to mention is 1828/1830.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [accumulo-website] milleruntime commented on a change in pull request #253: update draft notes with commit changes
Posted by GitBox <gi...@apache.org>.
milleruntime commented on a change in pull request #253:
URL: https://github.com/apache/accumulo-website/pull/253#discussion_r539589351
##########
File path: _posts/release/2020-12-09-accumulo-1.10.1.md
##########
@@ -32,11 +32,16 @@ problems you encounter, as well as perform some troubleshooting steps of your
own, in order to get the best response.
## Major Bug Fixes
-
+* Remove redundant audit message and order of authentication checks.
Review comment:
OK I wasn't sure if that is going into 1.10 or not. I asked on https://github.com/apache/accumulo/pull/1831
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [accumulo-website] EdColeman commented on a change in pull request #253: update draft notes with commit changes
Posted by GitBox <gi...@apache.org>.
EdColeman commented on a change in pull request #253:
URL: https://github.com/apache/accumulo-website/pull/253#discussion_r547488417
##########
File path: _posts/release/2020-12-09-accumulo-1.10.1.md
##########
@@ -9,8 +9,8 @@ draft: true
Apache Accumulo 1.10.1 is a bug fix release of the 1.10 LTM release line.
-This release contains contributions from more than X contributors from the
-Apace Accumulo community in over X commits. These release notes are highlights of those changes. The full
+This release contains contributions from more than 6 contributors from the
+Apace Accumulo community in over 19 commits. These release notes are highlights of those changes. The full
Review comment:
I dropped the numbers - and accepted all of the other suggestions.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [accumulo-website] milleruntime commented on a change in pull request #253: update draft notes with commit changes
Posted by GitBox <gi...@apache.org>.
milleruntime commented on a change in pull request #253:
URL: https://github.com/apache/accumulo-website/pull/253#discussion_r539567719
##########
File path: _posts/release/2020-12-09-accumulo-1.10.1.md
##########
@@ -32,11 +32,16 @@ problems you encounter, as well as perform some troubleshooting steps of your
own, in order to get the best response.
## Major Bug Fixes
-
+* Remove redundant audit message and order of authentication checks.
Review comment:
I am not seeing this in 1.10 branch. Did you take this from the main commit for:
`Fix unneeded audit message about denial (#1827)`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [accumulo-website] ctubbsii commented on a change in pull request #253: update draft notes with commit changes
Posted by GitBox <gi...@apache.org>.
ctubbsii commented on a change in pull request #253:
URL: https://github.com/apache/accumulo-website/pull/253#discussion_r547482650
##########
File path: _posts/release/2020-12-09-accumulo-1.10.1.md
##########
@@ -33,22 +33,32 @@ own, in order to get the best response.
## Major Bug Fixes
-### TODO title bug fix
+* Update exceptions when permission checks fail (PR [#1830] - backport of [#1828]).
-## Other Miscellaneous Bug Fixes
+### Other Bug Fixes
+
+* Improve log message in Delete Cleanup FATE.
-* {% ghi 1644 %} TODO Describe bugs
+## Other Miscellaneous Bug Fixes
+* Testing and build improvements.
+* Support building native libraries on alpine-based distros.
+* Enforce build requirements for java to be at least java 11 and strictly less than java 15.
+* Update tool.sh script used for MR examples to support hadoop 2.0 and 3.0 and ZooKeeper 3.4, 3.5
+* Update release candidate script
Review comment:
Some of these are internal development stuff, and not worth highlighting. Removing the ones that don't need to be there, especially those that are very vague, can bring more attention to the ones that users should pay attention to:
```suggestion
* Support building native libraries on alpine-based distros.
* Enforce build requirements for java to be at least java 11 and strictly less than java 15 (JDK 15 breaks, because it drops support for the CMS garbage collector that 1.10 still supports/assumes by default, especially in minicluster).
* Update tool.sh script used for MR examples to support hadoop 2.0 and 3.0 and ZooKeeper 3.4, 3.5
```
##########
File path: _posts/release/2020-12-09-accumulo-1.10.1.md
##########
@@ -9,8 +9,8 @@ draft: true
Apache Accumulo 1.10.1 is a bug fix release of the 1.10 LTM release line.
-This release contains contributions from more than X contributors from the
-Apace Accumulo community in over X commits. These release notes are highlights of those changes. The full
+This release contains contributions from more than 6 contributors from the
+Apace Accumulo community in over 19 commits. These release notes are highlights of those changes. The full
Review comment:
I think we started adding these numbers around 2.0.0 when the numbers were large and the degree of collaborative effort was impressive. When the numbers are low, I don't think it's necessary to include these. We can probably find some other way of wording it. That said, I don't care that much.
##########
File path: _posts/release/2020-12-09-accumulo-1.10.1.md
##########
@@ -33,22 +33,32 @@ own, in order to get the best response.
## Major Bug Fixes
-### TODO title bug fix
+* Update exceptions when permission checks fail (PR [#1830] - backport of [#1828]).
-## Other Miscellaneous Bug Fixes
+### Other Bug Fixes
+
+* Improve log message in Delete Cleanup FATE.
-* {% ghi 1644 %} TODO Describe bugs
+## Other Miscellaneous Bug Fixes
+* Testing and build improvements.
+* Support building native libraries on alpine-based distros.
+* Enforce build requirements for java to be at least java 11 and strictly less than java 15.
+* Update tool.sh script used for MR examples to support hadoop 2.0 and 3.0 and ZooKeeper 3.4, 3.5
+* Update release candidate script
+
## Useful Links
* [Release VOTE email thread][vote-emails]
* [All Changes since 1.10.0][all-changes]
* [GitHub] - List of issues tracked on GitHub corresponding to this release
+[#1828]: https://github.com/apache/accumulo/pull/1828
+[#1830]: https://github.com/apache/accumulo/pull/1830
[GitHub]: https://github.com/apache/accumulo/issues?q=project%3Aapache%2Faccumulo%2F8
[LTM]: {{ site.baseurl }}/contributor/versioning#LTM
[all-changes]: https://github.com/apache/accumulo/compare/rel/1.10.0...apache:rel/1.10.1
[contact]: {{ site.baseurl }}/contact-us
[issues]: https://github.com/apache/accumulo/issues
[semver]: https://semver.org/spec/v2.0.0.html
-[vote-emails]: https://lists.apache.org/thread.html/rd4731d4fd87c30958ad82a8b0be9375f2562ab0a9531ea037e646f3c%40%3Cdev.accumulo.apache.org%3E
+[vote-emails]: https://lists.apache.org/thread.html/[XXX]dev.accumulo.apache.org%3E
Review comment:
```suggestion
[vote-emails]: https://lists.apache.org/thread.html/r90ac3cc0d2356c86a94abf2b6859965e9659b8bcdb6cfd18b69941ac%40%3Cdev.accumulo.apache.org%3E
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [accumulo-website] ctubbsii merged pull request #253: update draft notes with commit changes
Posted by GitBox <gi...@apache.org>.
ctubbsii merged pull request #253:
URL: https://github.com/apache/accumulo-website/pull/253
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [accumulo-website] EdColeman commented on a change in pull request #253: update draft notes with commit changes
Posted by GitBox <gi...@apache.org>.
EdColeman commented on a change in pull request #253:
URL: https://github.com/apache/accumulo-website/pull/253#discussion_r539580931
##########
File path: _posts/release/2020-12-09-accumulo-1.10.1.md
##########
@@ -32,11 +32,16 @@ problems you encounter, as well as perform some troubleshooting steps of your
own, in order to get the best response.
## Major Bug Fixes
-
+* Remove redundant audit message and order of authentication checks.
Review comment:
I used the language from the PR #1831. This text is just a place-holder until the changes are complete and the release is ready.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org