You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2021/02/15 11:43:08 UTC

[GitHub] [superset] villebro commented on a change in pull request #13100: chore: upgrade to npm 7 and superset-ui 0.17.9

villebro commented on a change in pull request #13100:
URL: https://github.com/apache/superset/pull/13100#discussion_r576132554



##########
File path: CONTRIBUTING.md
##########
@@ -464,7 +473,7 @@ Frontend assets (TypeScript, JavaScript, CSS, and images) must be compiled in or
 
 ##### nvm and node
 
-First, be sure you are using recent versions of NodeJS and npm. We recommend using [nvm](https://github.com/nvm-sh/nvm) to manage your node environment:
+First, be sure you are using recent versions of node.js and npm. We recommend using [nvm](https://github.com/nvm-sh/nvm) to manage your node environment:

Review comment:
       I did some quick googling, and it appears the commonly used name is Node.js with a capital N: https://en.wikipedia.org/wiki/Node.js




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org