You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@oozie.apache.org by Rohini Palaniswamy <ro...@gmail.com> on 2013/06/17 23:26:12 UTC
Review Request: [OOZIE-1421] UI for SLA
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11916/
-----------------------------------------------------------
Review request for oozie.
Description
-------
The graph tab and final cleanup was done by me and rest else was done by Virag. The patch also includes css files and js files from the libraries (jquery, datatables and flot) that we used. Need to review only files starting with oozie-sla.
Diff2 has some whitespace fixes from Diff1.
This addresses bug OOZIE-1421.
https://issues.apache.org/jira/browse/OOZIE-1421
Diffs
-----
http://svn.apache.org/repos/asf/oozie/trunk/core/src/main/java/org/apache/oozie/sla/SLASummaryBean.java 1493893
http://svn.apache.org/repos/asf/oozie/trunk/pom.xml 1493893
http://svn.apache.org/repos/asf/oozie/trunk/webapp/src/main/webapp/WEB-INF/web-common.xml 1493893
http://svn.apache.org/repos/asf/oozie/trunk/webapp/src/main/webapp/console/sla/css/ColVis.css PRE-CREATION
http://svn.apache.org/repos/asf/oozie/trunk/webapp/src/main/webapp/console/sla/css/TableTools.css PRE-CREATION
http://svn.apache.org/repos/asf/oozie/trunk/webapp/src/main/webapp/console/sla/css/jquery-ui-1.10.3.custom.min.css PRE-CREATION
http://svn.apache.org/repos/asf/oozie/trunk/webapp/src/main/webapp/console/sla/css/jquery.dataTables.css PRE-CREATION
http://svn.apache.org/repos/asf/oozie/trunk/webapp/src/main/webapp/console/sla/css/oozie-sla-graph.css PRE-CREATION
http://svn.apache.org/repos/asf/oozie/trunk/webapp/src/main/webapp/console/sla/css/oozie-sla-table.css PRE-CREATION
http://svn.apache.org/repos/asf/oozie/trunk/webapp/src/main/webapp/console/sla/css/oozie-sla.css PRE-CREATION
http://svn.apache.org/repos/asf/oozie/trunk/webapp/src/main/webapp/console/sla/js/graph/jquery.flot.min.js PRE-CREATION
http://svn.apache.org/repos/asf/oozie/trunk/webapp/src/main/webapp/console/sla/js/graph/jquery.flot.navigate.min.js PRE-CREATION
http://svn.apache.org/repos/asf/oozie/trunk/webapp/src/main/webapp/console/sla/js/graph/jquery.flot.selection.min.js PRE-CREATION
http://svn.apache.org/repos/asf/oozie/trunk/webapp/src/main/webapp/console/sla/js/graph/jquery.flot.time.min.js PRE-CREATION
http://svn.apache.org/repos/asf/oozie/trunk/webapp/src/main/webapp/console/sla/js/oozie-sla-graph.js PRE-CREATION
http://svn.apache.org/repos/asf/oozie/trunk/webapp/src/main/webapp/console/sla/js/oozie-sla-table.js PRE-CREATION
http://svn.apache.org/repos/asf/oozie/trunk/webapp/src/main/webapp/console/sla/js/oozie-sla.js PRE-CREATION
http://svn.apache.org/repos/asf/oozie/trunk/webapp/src/main/webapp/console/sla/js/table/ColVis.min.js PRE-CREATION
http://svn.apache.org/repos/asf/oozie/trunk/webapp/src/main/webapp/console/sla/js/table/TableTools.min.js PRE-CREATION
http://svn.apache.org/repos/asf/oozie/trunk/webapp/src/main/webapp/console/sla/js/table/jquery-1.8.3.min.js PRE-CREATION
http://svn.apache.org/repos/asf/oozie/trunk/webapp/src/main/webapp/console/sla/js/table/jquery-ui-1.10.3.custom.min.js PRE-CREATION
http://svn.apache.org/repos/asf/oozie/trunk/webapp/src/main/webapp/console/sla/js/table/jquery-ui-timepicker-addon.js PRE-CREATION
http://svn.apache.org/repos/asf/oozie/trunk/webapp/src/main/webapp/console/sla/js/table/jquery.dataTables.min.js PRE-CREATION
http://svn.apache.org/repos/asf/oozie/trunk/webapp/src/main/webapp/console/sla/oozie-sla.html PRE-CREATION
http://svn.apache.org/repos/asf/oozie/trunk/webapp/src/main/webapp/index.html 1493893
http://svn.apache.org/repos/asf/oozie/trunk/webapp/src/main/webapp/index.jsp PRE-CREATION
http://svn.apache.org/repos/asf/oozie/trunk/webapp/src/main/webapp/oozie-console.js 1493893
Diff: https://reviews.apache.org/r/11916/diff/
Testing
-------
Yes. No unit tests since it is UI.
Thanks,
Rohini Palaniswamy
Re: Review Request: [OOZIE-1421] UI for SLA
Posted by Rohini Palaniswamy <ro...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11916/
-----------------------------------------------------------
(Updated June 17, 2013, 11:56 p.m.)
Review request for oozie.
Changes
-------
Addressed Mona's review comments + some sizing changes to the graph tab.
Description
-------
The graph tab and final cleanup was done by me and rest else was done by Virag. The patch also includes css files and js files from the libraries (jquery, datatables and flot) that we used. Need to review only files starting with oozie-sla.
Diff2 has some whitespace fixes from Diff1.
This addresses bug OOZIE-1421.
https://issues.apache.org/jira/browse/OOZIE-1421
Diffs (updated)
-----
http://svn.apache.org/repos/asf/oozie/trunk/core/src/main/java/org/apache/oozie/sla/SLASummaryBean.java 1493893
http://svn.apache.org/repos/asf/oozie/trunk/pom.xml 1493893
http://svn.apache.org/repos/asf/oozie/trunk/webapp/src/main/webapp/WEB-INF/web-common.xml 1493893
http://svn.apache.org/repos/asf/oozie/trunk/webapp/src/main/webapp/console/sla/css/ColVis.css PRE-CREATION
http://svn.apache.org/repos/asf/oozie/trunk/webapp/src/main/webapp/console/sla/css/TableTools.css PRE-CREATION
http://svn.apache.org/repos/asf/oozie/trunk/webapp/src/main/webapp/console/sla/css/jquery-ui-1.10.3.custom.min.css PRE-CREATION
http://svn.apache.org/repos/asf/oozie/trunk/webapp/src/main/webapp/console/sla/css/jquery.dataTables.css PRE-CREATION
http://svn.apache.org/repos/asf/oozie/trunk/webapp/src/main/webapp/console/sla/css/oozie-sla-graph.css PRE-CREATION
http://svn.apache.org/repos/asf/oozie/trunk/webapp/src/main/webapp/console/sla/css/oozie-sla-table.css PRE-CREATION
http://svn.apache.org/repos/asf/oozie/trunk/webapp/src/main/webapp/console/sla/css/oozie-sla.css PRE-CREATION
http://svn.apache.org/repos/asf/oozie/trunk/webapp/src/main/webapp/console/sla/js/graph/jquery.flot.min.js PRE-CREATION
http://svn.apache.org/repos/asf/oozie/trunk/webapp/src/main/webapp/console/sla/js/graph/jquery.flot.navigate.min.js PRE-CREATION
http://svn.apache.org/repos/asf/oozie/trunk/webapp/src/main/webapp/console/sla/js/graph/jquery.flot.selection.min.js PRE-CREATION
http://svn.apache.org/repos/asf/oozie/trunk/webapp/src/main/webapp/console/sla/js/graph/jquery.flot.time.min.js PRE-CREATION
http://svn.apache.org/repos/asf/oozie/trunk/webapp/src/main/webapp/console/sla/js/oozie-sla-graph.js PRE-CREATION
http://svn.apache.org/repos/asf/oozie/trunk/webapp/src/main/webapp/console/sla/js/oozie-sla-table.js PRE-CREATION
http://svn.apache.org/repos/asf/oozie/trunk/webapp/src/main/webapp/console/sla/js/oozie-sla.js PRE-CREATION
http://svn.apache.org/repos/asf/oozie/trunk/webapp/src/main/webapp/console/sla/js/table/ColVis.min.js PRE-CREATION
http://svn.apache.org/repos/asf/oozie/trunk/webapp/src/main/webapp/console/sla/js/table/TableTools.min.js PRE-CREATION
http://svn.apache.org/repos/asf/oozie/trunk/webapp/src/main/webapp/console/sla/js/table/jquery-1.8.3.min.js PRE-CREATION
http://svn.apache.org/repos/asf/oozie/trunk/webapp/src/main/webapp/console/sla/js/table/jquery-ui-1.10.3.custom.min.js PRE-CREATION
http://svn.apache.org/repos/asf/oozie/trunk/webapp/src/main/webapp/console/sla/js/table/jquery-ui-timepicker-addon.js PRE-CREATION
http://svn.apache.org/repos/asf/oozie/trunk/webapp/src/main/webapp/console/sla/js/table/jquery.dataTables.min.js PRE-CREATION
http://svn.apache.org/repos/asf/oozie/trunk/webapp/src/main/webapp/console/sla/oozie-sla.html PRE-CREATION
http://svn.apache.org/repos/asf/oozie/trunk/webapp/src/main/webapp/index.html 1493893
http://svn.apache.org/repos/asf/oozie/trunk/webapp/src/main/webapp/index.jsp PRE-CREATION
http://svn.apache.org/repos/asf/oozie/trunk/webapp/src/main/webapp/oozie-console.js 1493893
Diff: https://reviews.apache.org/r/11916/diff/
Testing
-------
Yes. No unit tests since it is UI.
Thanks,
Rohini Palaniswamy
Re: Review Request: [OOZIE-1421] UI for SLA
Posted by Rohini Palaniswamy <ro...@gmail.com>.
> On June 17, 2013, 10:38 p.m., Mona Chitnis wrote:
> > http://svn.apache.org/repos/asf/oozie/trunk/webapp/src/main/webapp/console/sla/oozie-sla.html, line 78
> > <https://reviews.apache.org/r/11916/diff/2/?file=307215#file307215line78>
> >
> > From the screenshot and the prototype I saw, it appears like "Graph" tab is in focus when we are actually seeing 'Table' tab's contents underneath and vice versa.
Not a issue. Its actually fine, also text appears in bold.
> On June 17, 2013, 10:38 p.m., Mona Chitnis wrote:
> > http://svn.apache.org/repos/asf/oozie/trunk/webapp/src/main/webapp/console/sla/css/TableTools.css, line 119
> > <https://reviews.apache.org/r/11916/diff/2/?file=307196#file307196line119>
> >
> > is this commented code required?
This is not our file. Can't change it.
- Rohini
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11916/#review22024
-----------------------------------------------------------
On June 17, 2013, 9:26 p.m., Rohini Palaniswamy wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/11916/
> -----------------------------------------------------------
>
> (Updated June 17, 2013, 9:26 p.m.)
>
>
> Review request for oozie.
>
>
> Description
> -------
>
> The graph tab and final cleanup was done by me and rest else was done by Virag. The patch also includes css files and js files from the libraries (jquery, datatables and flot) that we used. Need to review only files starting with oozie-sla.
>
> Diff2 has some whitespace fixes from Diff1.
>
>
> This addresses bug OOZIE-1421.
> https://issues.apache.org/jira/browse/OOZIE-1421
>
>
> Diffs
> -----
>
> http://svn.apache.org/repos/asf/oozie/trunk/core/src/main/java/org/apache/oozie/sla/SLASummaryBean.java 1493893
> http://svn.apache.org/repos/asf/oozie/trunk/pom.xml 1493893
> http://svn.apache.org/repos/asf/oozie/trunk/webapp/src/main/webapp/WEB-INF/web-common.xml 1493893
> http://svn.apache.org/repos/asf/oozie/trunk/webapp/src/main/webapp/console/sla/css/ColVis.css PRE-CREATION
> http://svn.apache.org/repos/asf/oozie/trunk/webapp/src/main/webapp/console/sla/css/TableTools.css PRE-CREATION
> http://svn.apache.org/repos/asf/oozie/trunk/webapp/src/main/webapp/console/sla/css/jquery-ui-1.10.3.custom.min.css PRE-CREATION
> http://svn.apache.org/repos/asf/oozie/trunk/webapp/src/main/webapp/console/sla/css/jquery.dataTables.css PRE-CREATION
> http://svn.apache.org/repos/asf/oozie/trunk/webapp/src/main/webapp/console/sla/css/oozie-sla-graph.css PRE-CREATION
> http://svn.apache.org/repos/asf/oozie/trunk/webapp/src/main/webapp/console/sla/css/oozie-sla-table.css PRE-CREATION
> http://svn.apache.org/repos/asf/oozie/trunk/webapp/src/main/webapp/console/sla/css/oozie-sla.css PRE-CREATION
> http://svn.apache.org/repos/asf/oozie/trunk/webapp/src/main/webapp/console/sla/js/graph/jquery.flot.min.js PRE-CREATION
> http://svn.apache.org/repos/asf/oozie/trunk/webapp/src/main/webapp/console/sla/js/graph/jquery.flot.navigate.min.js PRE-CREATION
> http://svn.apache.org/repos/asf/oozie/trunk/webapp/src/main/webapp/console/sla/js/graph/jquery.flot.selection.min.js PRE-CREATION
> http://svn.apache.org/repos/asf/oozie/trunk/webapp/src/main/webapp/console/sla/js/graph/jquery.flot.time.min.js PRE-CREATION
> http://svn.apache.org/repos/asf/oozie/trunk/webapp/src/main/webapp/console/sla/js/oozie-sla-graph.js PRE-CREATION
> http://svn.apache.org/repos/asf/oozie/trunk/webapp/src/main/webapp/console/sla/js/oozie-sla-table.js PRE-CREATION
> http://svn.apache.org/repos/asf/oozie/trunk/webapp/src/main/webapp/console/sla/js/oozie-sla.js PRE-CREATION
> http://svn.apache.org/repos/asf/oozie/trunk/webapp/src/main/webapp/console/sla/js/table/ColVis.min.js PRE-CREATION
> http://svn.apache.org/repos/asf/oozie/trunk/webapp/src/main/webapp/console/sla/js/table/TableTools.min.js PRE-CREATION
> http://svn.apache.org/repos/asf/oozie/trunk/webapp/src/main/webapp/console/sla/js/table/jquery-1.8.3.min.js PRE-CREATION
> http://svn.apache.org/repos/asf/oozie/trunk/webapp/src/main/webapp/console/sla/js/table/jquery-ui-1.10.3.custom.min.js PRE-CREATION
> http://svn.apache.org/repos/asf/oozie/trunk/webapp/src/main/webapp/console/sla/js/table/jquery-ui-timepicker-addon.js PRE-CREATION
> http://svn.apache.org/repos/asf/oozie/trunk/webapp/src/main/webapp/console/sla/js/table/jquery.dataTables.min.js PRE-CREATION
> http://svn.apache.org/repos/asf/oozie/trunk/webapp/src/main/webapp/console/sla/oozie-sla.html PRE-CREATION
> http://svn.apache.org/repos/asf/oozie/trunk/webapp/src/main/webapp/index.html 1493893
> http://svn.apache.org/repos/asf/oozie/trunk/webapp/src/main/webapp/index.jsp PRE-CREATION
> http://svn.apache.org/repos/asf/oozie/trunk/webapp/src/main/webapp/oozie-console.js 1493893
>
> Diff: https://reviews.apache.org/r/11916/diff/
>
>
> Testing
> -------
>
> Yes. No unit tests since it is UI.
>
>
> Thanks,
>
> Rohini Palaniswamy
>
>
Re: Review Request: [OOZIE-1421] UI for SLA
Posted by Mona Chitnis <mo...@yahoo.in>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11916/#review22024
-----------------------------------------------------------
Always kinda tricky to review Javascript :) Didnt find any glaring issues just some minor ones..
http://svn.apache.org/repos/asf/oozie/trunk/webapp/src/main/webapp/console/sla/css/TableTools.css
<https://reviews.apache.org/r/11916/#comment45339>
is this commented code required?
http://svn.apache.org/repos/asf/oozie/trunk/webapp/src/main/webapp/console/sla/oozie-sla.html
<https://reviews.apache.org/r/11916/#comment45341>
From the screenshot and the prototype I saw, it appears like "Graph" tab is in focus when we are actually seeing 'Table' tab's contents underneath and vice versa.
http://svn.apache.org/repos/asf/oozie/trunk/webapp/src/main/webapp/index.jsp
<https://reviews.apache.org/r/11916/#comment45340>
can use the static function SLAService.isEnabled() instead
- Mona Chitnis
On June 17, 2013, 9:26 p.m., Rohini Palaniswamy wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/11916/
> -----------------------------------------------------------
>
> (Updated June 17, 2013, 9:26 p.m.)
>
>
> Review request for oozie.
>
>
> Description
> -------
>
> The graph tab and final cleanup was done by me and rest else was done by Virag. The patch also includes css files and js files from the libraries (jquery, datatables and flot) that we used. Need to review only files starting with oozie-sla.
>
> Diff2 has some whitespace fixes from Diff1.
>
>
> This addresses bug OOZIE-1421.
> https://issues.apache.org/jira/browse/OOZIE-1421
>
>
> Diffs
> -----
>
> http://svn.apache.org/repos/asf/oozie/trunk/core/src/main/java/org/apache/oozie/sla/SLASummaryBean.java 1493893
> http://svn.apache.org/repos/asf/oozie/trunk/pom.xml 1493893
> http://svn.apache.org/repos/asf/oozie/trunk/webapp/src/main/webapp/WEB-INF/web-common.xml 1493893
> http://svn.apache.org/repos/asf/oozie/trunk/webapp/src/main/webapp/console/sla/css/ColVis.css PRE-CREATION
> http://svn.apache.org/repos/asf/oozie/trunk/webapp/src/main/webapp/console/sla/css/TableTools.css PRE-CREATION
> http://svn.apache.org/repos/asf/oozie/trunk/webapp/src/main/webapp/console/sla/css/jquery-ui-1.10.3.custom.min.css PRE-CREATION
> http://svn.apache.org/repos/asf/oozie/trunk/webapp/src/main/webapp/console/sla/css/jquery.dataTables.css PRE-CREATION
> http://svn.apache.org/repos/asf/oozie/trunk/webapp/src/main/webapp/console/sla/css/oozie-sla-graph.css PRE-CREATION
> http://svn.apache.org/repos/asf/oozie/trunk/webapp/src/main/webapp/console/sla/css/oozie-sla-table.css PRE-CREATION
> http://svn.apache.org/repos/asf/oozie/trunk/webapp/src/main/webapp/console/sla/css/oozie-sla.css PRE-CREATION
> http://svn.apache.org/repos/asf/oozie/trunk/webapp/src/main/webapp/console/sla/js/graph/jquery.flot.min.js PRE-CREATION
> http://svn.apache.org/repos/asf/oozie/trunk/webapp/src/main/webapp/console/sla/js/graph/jquery.flot.navigate.min.js PRE-CREATION
> http://svn.apache.org/repos/asf/oozie/trunk/webapp/src/main/webapp/console/sla/js/graph/jquery.flot.selection.min.js PRE-CREATION
> http://svn.apache.org/repos/asf/oozie/trunk/webapp/src/main/webapp/console/sla/js/graph/jquery.flot.time.min.js PRE-CREATION
> http://svn.apache.org/repos/asf/oozie/trunk/webapp/src/main/webapp/console/sla/js/oozie-sla-graph.js PRE-CREATION
> http://svn.apache.org/repos/asf/oozie/trunk/webapp/src/main/webapp/console/sla/js/oozie-sla-table.js PRE-CREATION
> http://svn.apache.org/repos/asf/oozie/trunk/webapp/src/main/webapp/console/sla/js/oozie-sla.js PRE-CREATION
> http://svn.apache.org/repos/asf/oozie/trunk/webapp/src/main/webapp/console/sla/js/table/ColVis.min.js PRE-CREATION
> http://svn.apache.org/repos/asf/oozie/trunk/webapp/src/main/webapp/console/sla/js/table/TableTools.min.js PRE-CREATION
> http://svn.apache.org/repos/asf/oozie/trunk/webapp/src/main/webapp/console/sla/js/table/jquery-1.8.3.min.js PRE-CREATION
> http://svn.apache.org/repos/asf/oozie/trunk/webapp/src/main/webapp/console/sla/js/table/jquery-ui-1.10.3.custom.min.js PRE-CREATION
> http://svn.apache.org/repos/asf/oozie/trunk/webapp/src/main/webapp/console/sla/js/table/jquery-ui-timepicker-addon.js PRE-CREATION
> http://svn.apache.org/repos/asf/oozie/trunk/webapp/src/main/webapp/console/sla/js/table/jquery.dataTables.min.js PRE-CREATION
> http://svn.apache.org/repos/asf/oozie/trunk/webapp/src/main/webapp/console/sla/oozie-sla.html PRE-CREATION
> http://svn.apache.org/repos/asf/oozie/trunk/webapp/src/main/webapp/index.html 1493893
> http://svn.apache.org/repos/asf/oozie/trunk/webapp/src/main/webapp/index.jsp PRE-CREATION
> http://svn.apache.org/repos/asf/oozie/trunk/webapp/src/main/webapp/oozie-console.js 1493893
>
> Diff: https://reviews.apache.org/r/11916/diff/
>
>
> Testing
> -------
>
> Yes. No unit tests since it is UI.
>
>
> Thanks,
>
> Rohini Palaniswamy
>
>