You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@carbondata.apache.org by xuchuanyin <gi...@git.apache.org> on 2018/05/10 01:04:11 UTC

[GitHub] carbondata pull request #2235: [CARBONDATA-2465] Improve the carbondata file...

Github user xuchuanyin commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/2235#discussion_r187216778
  
    --- Diff: processing/src/main/java/org/apache/carbondata/processing/store/writer/AbstractFactDataWriter.java ---
    @@ -152,6 +152,9 @@
        */
       private boolean enableDirectlyWriteData2Hdfs = false;
     
    +  // Initially write 3 replicas and set the cluster configured replication once file write finished
    +  private short initialWriteReplication = 3;
    --- End diff --
    
    please get the initial replication from hdfs default, like below 
    ```
    short replication = FileFactory.getDefaultReplication(fileName, fileType);
    ``
    
    We only need to modify Line361, use this value to replace 1.


---